[COMMITTED] tst-res_hconf_reorder: Set RESOLV_REORDER environment variable
Commit Message
Otherwise, the problematic code does not run.
Another option would have been to make this an xtest, with instructions
how system configuration needs to be changed, but I think this is better
because xtests are run less frequently.
Florian
Comments
On Fri, Dec 04, 2015 at 07:05:18PM +0100, Florian Weimer wrote:
> Otherwise, the problematic code does not run.
Is setting RESOLV_REORDER via tst-res_hconf_reorder-ENV in resolv/Makefile
not enough?
On 12/04/2015 07:16 PM, Dmitry V. Levin wrote:
> On Fri, Dec 04, 2015 at 07:05:18PM +0100, Florian Weimer wrote:
>> Otherwise, the problematic code does not run.
>
> Is setting RESOLV_REORDER via tst-res_hconf_reorder-ENV in resolv/Makefile
> not enough?
It is, I had overlooked this part of the Makefile change. Oh well,
shall I revert my commit?
Florian
On Fri, Dec 04, 2015 at 07:18:59PM +0100, Florian Weimer wrote:
> On 12/04/2015 07:16 PM, Dmitry V. Levin wrote:
> > On Fri, Dec 04, 2015 at 07:05:18PM +0100, Florian Weimer wrote:
> >> Otherwise, the problematic code does not run.
> >
> > Is setting RESOLV_REORDER via tst-res_hconf_reorder-ENV in resolv/Makefile
> > not enough?
>
> It is, I had overlooked this part of the Makefile change. Oh well,
> shall I revert my commit?
Please either revert or remove tst-res_hconf_reorder-ENV.
On 12/04/2015 07:23 PM, Dmitry V. Levin wrote:
> On Fri, Dec 04, 2015 at 07:18:59PM +0100, Florian Weimer wrote:
>> On 12/04/2015 07:16 PM, Dmitry V. Levin wrote:
>>> On Fri, Dec 04, 2015 at 07:05:18PM +0100, Florian Weimer wrote:
>>>> Otherwise, the problematic code does not run.
>>>
>>> Is setting RESOLV_REORDER via tst-res_hconf_reorder-ENV in resolv/Makefile
>>> not enough?
>>
>> It is, I had overlooked this part of the Makefile change. Oh well,
>> shall I revert my commit?
>
> Please either revert or remove tst-res_hconf_reorder-ENV.
Okay, it's gone. Sorry about that.
Florian
2015-12-04 Florian Weimer <fweimer@redhat.com>
* resolv/tst-res_hconf_reorder.c (do_test): Set RESOLV_REORDER
environment variable.
@@ -71,6 +71,9 @@ do_test (void)
unsigned int i;
int result = 0;
+ /* Enabled code to be tested. */
+ setenv ("RESOLV_REORDER", "on", 1);
+
/* turn on realloc slowdown */
ts.tv_nsec = 100000000;