diff mbox series

RISC-V: Remove svvptc from riscv-ext-bitmask.def

Message ID tencent_E3411AED37C7115C9598FF109746473E5C07@qq.com
State Committed
Commit d24a5e2d381b290d4def659ed83e969b65d07f02
Headers
Series RISC-V: Remove svvptc from riscv-ext-bitmask.def |

Checks

Context Check Description
rivoscibot/toolchain-ci-rivos-lint success Lint passed
rivoscibot/toolchain-ci-rivos-apply-patch success Patch applied
rivoscibot/toolchain-ci-rivos-build--newlib-rv64gc-lp64d-non-multilib success Build passed
linaro-tcwg-bot/tcwg_gcc_build--master-arm success Build passed
linaro-tcwg-bot/tcwg_gcc_check--master-arm success Test passed
linaro-tcwg-bot/tcwg_gcc_build--master-aarch64 success Build passed
rivoscibot/toolchain-ci-rivos-build--newlib-rv64gcv-lp64d-multilib success Build passed
rivoscibot/toolchain-ci-rivos-build--linux-rv64gc_zba_zbb_zbc_zbs-lp64d-multilib success Build passed
rivoscibot/toolchain-ci-rivos-build--linux-rv64gcv-lp64d-multilib success Build passed
rivoscibot/toolchain-ci-rivos-build--linux-rv64gc-lp64d-non-multilib success Build passed
rivoscibot/toolchain-ci-rivos-test success Testing passed
linaro-tcwg-bot/tcwg_gcc_check--master-aarch64 success Test passed

Commit Message

Yangyu Chen Dec. 16, 2024, 4:37 p.m. UTC 
  There should be no svvptc in the riscv-ext-bitmask.def file since it has
not yet been added to the RISC-V C API Specification or the Linux
hwprobe. And there is no need for userspace software to know that this
extension exists. So remove it from the riscv-ext-bitmask.def file.

Fixes: e4f4b2dc08 ("RISC-V: Minimal support for svvptc extension.")
Signed-off-by: Yangyu Chen <cyy@cyyself.name>

gcc/ChangeLog:

	* common/config/riscv/riscv-ext-bitmask.def (RISCV_EXT_BITMASK): Remove svvptc.
---
 gcc/common/config/riscv/riscv-ext-bitmask.def | 1 -
 1 file changed, 1 deletion(-)

Comments

Palmer Dabbelt Dec. 16, 2024, 5:28 p.m. UTC | #1 
On Mon, 16 Dec 2024 08:37:13 PST (-0800), cyy@cyyself.name wrote:
> There should be no svvptc in the riscv-ext-bitmask.def file since it has
> not yet been added to the RISC-V C API Specification or the Linux
> hwprobe. And there is no need for userspace software to know that this
> extension exists. So remove it from the riscv-ext-bitmask.def file.
>
> Fixes: e4f4b2dc08 ("RISC-V: Minimal support for svvptc extension.")
> Signed-off-by: Yangyu Chen <cyy@cyyself.name>
>
> gcc/ChangeLog:
>
> 	* common/config/riscv/riscv-ext-bitmask.def (RISCV_EXT_BITMASK): Remove svvptc.
> ---
>  gcc/common/config/riscv/riscv-ext-bitmask.def | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/gcc/common/config/riscv/riscv-ext-bitmask.def b/gcc/common/config/riscv/riscv-ext-bitmask.def
> index a733533df98..ca5df1740f3 100644
> --- a/gcc/common/config/riscv/riscv-ext-bitmask.def
> +++ b/gcc/common/config/riscv/riscv-ext-bitmask.def
> @@ -79,6 +79,5 @@ RISCV_EXT_BITMASK ("zcd",		1,  4)
>  RISCV_EXT_BITMASK ("zcf",		1,  5)
>  RISCV_EXT_BITMASK ("zcmop",		1,  6)
>  RISCV_EXT_BITMASK ("zawrs",		1,  7)
> -RISCV_EXT_BITMASK ("svvptc",		1,  8)
>
>  #undef RISCV_EXT_BITMASK

Reviewed-by: Palmer Dabbelt <palmer@rivosinc.com>
Acked-by: Palmer Dabbelt <palmer@rivosinc.com>

I think we'll likely never expose this to userspace, the mappings are 
all hidden behind kernel interfaces so userspace shouldn't need to know.
Jeff Law Dec. 17, 2024, 2:43 p.m. UTC | #2 
On 12/16/24 10:28 AM, Palmer Dabbelt wrote:
> On Mon, 16 Dec 2024 08:37:13 PST (-0800), cyy@cyyself.name wrote:
>> There should be no svvptc in the riscv-ext-bitmask.def file since it has
>> not yet been added to the RISC-V C API Specification or the Linux
>> hwprobe. And there is no need for userspace software to know that this
>> extension exists. So remove it from the riscv-ext-bitmask.def file.
>>
>> Fixes: e4f4b2dc08 ("RISC-V: Minimal support for svvptc extension.")
>> Signed-off-by: Yangyu Chen <cyy@cyyself.name>
>>
>> gcc/ChangeLog:
>>
>>     * common/config/riscv/riscv-ext-bitmask.def (RISCV_EXT_BITMASK): 
>> Remove svvptc.
>> ---
>>  gcc/common/config/riscv/riscv-ext-bitmask.def | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/gcc/common/config/riscv/riscv-ext-bitmask.def b/gcc/ 
>> common/config/riscv/riscv-ext-bitmask.def
>> index a733533df98..ca5df1740f3 100644
>> --- a/gcc/common/config/riscv/riscv-ext-bitmask.def
>> +++ b/gcc/common/config/riscv/riscv-ext-bitmask.def
>> @@ -79,6 +79,5 @@ RISCV_EXT_BITMASK ("zcd",        1,  4)
>>  RISCV_EXT_BITMASK ("zcf",        1,  5)
>>  RISCV_EXT_BITMASK ("zcmop",        1,  6)
>>  RISCV_EXT_BITMASK ("zawrs",        1,  7)
>> -RISCV_EXT_BITMASK ("svvptc",        1,  8)
>>
>>  #undef RISCV_EXT_BITMASK
> 
> Reviewed-by: Palmer Dabbelt <palmer@rivosinc.com>
> Acked-by: Palmer Dabbelt <palmer@rivosinc.com>
> 
> I think we'll likely never expose this to userspace, the mappings are 
> all hidden behind kernel interfaces so userspace shouldn't need to know.
I've pushed this patch to the trunk.

jeff
diff mbox series

Patch

diff --git a/gcc/common/config/riscv/riscv-ext-bitmask.def b/gcc/common/config/riscv/riscv-ext-bitmask.def
index a733533df98..ca5df1740f3 100644
--- a/gcc/common/config/riscv/riscv-ext-bitmask.def
+++ b/gcc/common/config/riscv/riscv-ext-bitmask.def
@@ -79,6 +79,5 @@  RISCV_EXT_BITMASK ("zcd",		1,  4)
 RISCV_EXT_BITMASK ("zcf",		1,  5)
 RISCV_EXT_BITMASK ("zcmop",		1,  6)
 RISCV_EXT_BITMASK ("zawrs",		1,  7)
-RISCV_EXT_BITMASK ("svvptc",		1,  8)
 
 #undef RISCV_EXT_BITMASK