PPC64/ELF: adjust comment wrt ABI versions
Checks
Context |
Check |
Description |
linaro-tcwg-bot/tcwg_binutils_build--master-arm |
success
|
Testing passed
|
linaro-tcwg-bot/tcwg_binutils_build--master-aarch64 |
success
|
Testing passed
|
linaro-tcwg-bot/tcwg_binutils_check--master-aarch64 |
success
|
Testing passed
|
linaro-tcwg-bot/tcwg_binutils_check--master-arm |
success
|
Testing passed
|
Commit Message
While having been moved a couple of times since its introduction in
f6c7c3e8b742 ("Referencing a function's address on PowerPC64 ELFv2"),
the wording has always remained the same. In particular ELFv1 and ELFv2
have always been the wrong way round.
Comments
On Fri, Jan 05, 2024 at 09:31:23AM +0100, Jan Beulich wrote:
> While having been moved a couple of times since its introduction in
> f6c7c3e8b742 ("Referencing a function's address on PowerPC64 ELFv2"),
> the wording has always remained the same. In particular ELFv1 and ELFv2
> have always been the wrong way round.
Thanks for the fix.
> --- a/bfd/elf64-ppc.c
> +++ b/bfd/elf64-ppc.c
> @@ -4498,7 +4498,7 @@ ppc64_elf_before_check_relocs (bfd *ibfd
> {
> /* For input files without an explicit abiversion in e_flags
> we should have flagged any with symbol st_other bits set
> - as ELFv1 and above flagged those with .opd as ELFv2.
> + as ELFv2 and above flagged those with .opd as ELFv1.
> Set the output abiversion if not yet set, and for any input
> still ambiguous, take its abiversion from the output.
> Differences in ABI are reported later. */
@@ -4498,7 +4498,7 @@ ppc64_elf_before_check_relocs (bfd *ibfd
{
/* For input files without an explicit abiversion in e_flags
we should have flagged any with symbol st_other bits set
- as ELFv1 and above flagged those with .opd as ELFv2.
+ as ELFv2 and above flagged those with .opd as ELFv1.
Set the output abiversion if not yet set, and for any input
still ambiguous, take its abiversion from the output.
Differences in ABI are reported later. */