Message ID | 20231030150212.21445-1-jose.marchesi@oracle.com |
---|---|
State | New |
Headers |
Return-Path: <binutils-bounces+patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 517EE3857702 for <patchwork@sourceware.org>; Mon, 30 Oct 2023 15:02:48 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 25A133858D37 for <binutils@sourceware.org>; Mon, 30 Oct 2023 15:02:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 25A133858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 25A133858D37 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1698678151; cv=pass; b=mcV5O+EwsqvoYUav1ievgDn0vXdtDswG10wWrAwJYphb3HTh/3corpaow/W/o2Bq5oHY4+QbozYXuv1e07HNslpziNSQ1o1anTs+/nmIamBcnSt0cMdbLyZrA3Q8Z4tmQKwwiaWXizLJEds0RRFTo52D+DTz5IdZm3GhAUsPF9A= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1698678151; c=relaxed/simple; bh=Yx/Wq1IzvRbRKyLhF1co06+QYdVp+VzMJpeG3Xt6ICw=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-Id: MIME-Version; b=aC4lOtN8zSu1pJWcqBbnVZDux3GigNfmFQcy7W0U9Igem0nEn8GF/obTOTaujRnC7gwsAM8jqmlJ0tG3nFZAdNjVOd+6rRow2E1ifBDIHNAfYdtB39n636ey37Y7+n7rzy5F6uCDcY9LEoo5wDriso+Kt45rmDCDnQmVwVSKHlM= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 39UDWbMU030222 for <binutils@sourceware.org>; Mon, 30 Oct 2023 15:02:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : subject : date : message-id : content-transfer-encoding : content-type : mime-version; s=corp-2023-03-30; bh=/9NRme1jKyuIKXfGKu/nQzliGSfsf9zZPT227TBNnC8=; b=YmPLYig1nsbdliz8yUpKrcgEh+w9fn9FIyBQZWTWruIAvZFHt9jCk1rDL7p0tlBTbDrs ZyQKX7EdmYIw3w+zSs1GcpOlCTfE7x5bODeJvW8LdL7h0Jjw4zrbtJeyZzjgkEWGghDH mfPNwk1eDZHL4EdFw/rrOpGks5SQYeEwbuOuEWNWuIuEybhgjFGq8uJL8UIfBLWYSLfr 4te0P1g4K/5aJjdV9raDkGqtGxXtQ2NtbWRriNZZfofWB6AGLAE+kVChGmjKGPp3HhFT 4tUkLaQANe03ivoTu9lCsXRXd3b8UFO1Pr75h7rZHMlixWhRaf9V3r4S+tu5shxgdaLy Wg== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3u0rqdu110-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for <binutils@sourceware.org>; Mon, 30 Oct 2023 15:02:20 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 39UE3QYs001084 for <binutils@sourceware.org>; Mon, 30 Oct 2023 15:02:19 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2100.outbound.protection.outlook.com [104.47.58.100]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3u0rr4ra99-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for <binutils@sourceware.org>; Mon, 30 Oct 2023 15:02:19 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=adpWjfmxOvkT4VCx71oxa/GJvGDQ05ikL4k67yMc91f/jwTNzA4SdUo0fV5clofFvVA8MJblXgY7/VkQreWd5X0Y/cmYXTD616DKdrBHfK7kHgKZDEjWke6pwU8Pu8490IDWJXhdLtcpQFOqEPQ791BBkXhr0S5XLCDrHso6/8XBIVagZ7rkdf0+JeAQ8YnabZcYaBXT+sDsM6WXFaHg8UskjsVCIyCmercnZRiTtsSg9LXT+qC9lmCsJwdIV/4CnGArhhdTXR87fVav+ug4vCuDj2bIhxvLG8/c+FK4RBX9reYQyvwQq5KDpOsINSblvmzFecJFvEXdYTkFIvcZOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/9NRme1jKyuIKXfGKu/nQzliGSfsf9zZPT227TBNnC8=; b=kIj+M2N5ueF85To1dC0NQELR+47W5Sg/z4KFzV2w29xHy5fb7n6xrSk6u6yNZhL06B7726Rt5iwfCPyQ07XdlXgcobIsqyECowLgNvXloX/pCk8O98OLOrB3K3jMz0tWGdYutdxJ2xFfD/OtjyEZHmjMrGgzpy+gPQrR4CrgNxnb1lZwXYk7IP1dGdHcjsM0zgp+pwTUoCLzd6eloGFnQp9gXoDguZiKuAjlFOarf9zpEuyDc9toWY6DTGDgWN9BcTc3cfjgqOuPb5QdNcVuDVipGWNRmlHWUoHaU23T1fYDckXkC2dE7ajjpasZ1x/mF0QuaSPzWhZ289ChK0VMjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/9NRme1jKyuIKXfGKu/nQzliGSfsf9zZPT227TBNnC8=; b=fWIx3f8yl7+EA5QcZYGR1TLQ4zf2zy7/8HGRj7knxArohMYwAX7eZRgprQfyWqs+EqhOwfHbe73JUamY/e+Aarmq/KV/5qi4qgWsH0CEiG0vneIcOohyDof0HRJ54T0QWI9Y2vaarJQYK2DFJDMToIeRU82KfBC5NB+NT5pULpA= Received: from BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) by MN2PR10MB4206.namprd10.prod.outlook.com (2603:10b6:208:1df::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.33; Mon, 30 Oct 2023 15:02:17 +0000 Received: from BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::d5fc:906c:6936:713d]) by BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::d5fc:906c:6936:713d%6]) with mapi id 15.20.6933.023; Mon, 30 Oct 2023 15:02:16 +0000 From: "Jose E. Marchesi" <jose.marchesi@oracle.com> To: binutils@sourceware.org Subject: [PATCH] gas: bpf: new test for MOV with C-like numbers ll suffix Date: Mon, 30 Oct 2023 16:02:12 +0100 Message-Id: <20231030150212.21445-1-jose.marchesi@oracle.com> X-Mailer: git-send-email 2.30.2 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: LO4P302CA0036.GBRP302.PROD.OUTLOOK.COM (2603:10a6:600:317::7) To BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB2888:EE_|MN2PR10MB4206:EE_ X-MS-Office365-Filtering-Correlation-Id: eda81cbb-0ee9-4525-f81a-08dbd95934d6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dUV+jMv0+WlkmnzoM42hGJoman0BFEpMDYi7CveS1UfKPca7Z59/ZbiDbLjXWR92+dJA4+yp9Ns+mwk2tirWaJsTB0OCDv/OjfwkoM5ps4cTDYruD6Exw8h9RPSz5+8M02f6VRetmVN8UCIFHKXVipWlCzrqfiRMUIC26EMCF5VvJ1oPhjwp7ddbRa9Wtih3Dtgo9UxJZVxtUBFN/KQUdOcL2jotG/AoXArnnKmApO70eCd/Hwp0HG7qLTuEOpvSUJEmZSQUuPZZYDtqRd5KkVTkcX4DnaWpYVLtXzIdtXFvnnBQntWluYxOqrp2dCUbts/89kKpNsEJH/qXi1IvRC+2/Qu6BS+yBIK1mtTsUcOonSEBsKke1NX9n5LQLdqqfLreFD4F73z0eIDVwmQuPGUOgkQ/50O+x2Zcn36ov80zu/+AAXTygu3lErOWBLOafmuh69a8famlYs3i60RUzeyQz3uQ0y/Qc3Xk1hYeL5ebuOWZmodL1oVbSv5wXRlzyPBN4h2lk/WIqp8QaokprBFFooQDYtRILUTO59PzU0vupn67YjQ/GTqZHn3VLfFk X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR10MB2888.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(366004)(39860400002)(376002)(136003)(346002)(230922051799003)(451199024)(186009)(64100799003)(1800799009)(8936002)(86362001)(8676002)(316002)(66946007)(6916009)(66556008)(66476007)(41300700001)(5660300002)(6486002)(478600001)(2906002)(6512007)(6506007)(6666004)(4001150100001)(2616005)(36756003)(1076003)(83380400001)(38100700002)(26005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: HgbBTNsFDlKfuyAmYDVS3N6SxqrZ5LRQOg4KhRgHCAL2RRu/y8tj81Rd7jFyHdH6cwakWh5lBi2DtCYZpcw+M1uUbucDSuQ/6tI7nbNYxI2u5VaOWLSn7UIoyGu3GRpI4sdCp/7pGjGWkRkMR5mL0tD7Yeco2MnXEMnUwmaW6dcrUqyhwQIF1XFXOM0VH/BDoJ6L95obQb1LYkPzBLwGcYbvDlb36Jyyl03hA42G0daRJC+34psSc7lxxhwAB34UNqDeDG3GhkpeDjalaw7BKLI01PvJoRJmxWKK59gE4Uo6lchXwgiQ6HZtpyxFewhiFgeFiJWwc8oGVmomK/XiXys1apnOg+MgVQMb+cdbJltkFlQGceh+dtYi0/Kh2jlkBVqvmJxO44p2PkChgP3ldIo+oesJ/nVf090AHkwhSXYhR7YIWn53PFepVJBpFuyfd6f9EtDqKdK6EOsUUBbp3WiMvnGOhv+nTqs+8W5EGcpOz5VJEsLnvI0bN4zfvNaXcq210NMRYt6kvVzYqDK7DXk+QpnqQz23dbYW7CYgkxpwIV7KRTgh0pdstSG08kUrvlJP6FD30FdxEIL3/msja5ukuYXUAHs3syMwW46nPxBkpwEQ9n73Rf/xG/3vHcI4etinY2DjKPBNUqN6HGmSlYLZC1sSvTdwJ4HfF0O/taCUxvjruEGmK/Ky09XWGhl7xGycGrI+oh2Atv1lBevmeWhRtIfj6NFLMR19yznk6TSwmoWp3SQkmmRkxThod/bZAWGnIDMjXpzJH4B1xREVFvMudWLVXCPfkoSKc5ap5rTZARj6rRA9rDqPLEeX6GfZaR1ak764C5OWn9ds7t+dLPqwANsvSxaszhpIcbP9KghHFSSzi7R/7r8PAn4OzaB9PhsuPJ9I+0sOHqD/6yG465MyiMB4WkQ5go5BDkEjKuvr6o167vvj6IJdb1PyX07SrRoVRWEvdc0UhRvYD2gK5PRYufzxYNibG+UU+D+FW2yxE5801hH8M9ol/rKF0RCnN3wFoMPDzcNXpt3azCIQOTBjDm0301Kn4FsfXeH7JGxMACmuLVLQMLZN9yn88e85q6xIB3dcgt8/nahDG7gtehbkEpi2hWwjn3gCzkZWDUcMVNHYSvj8NNVBsCh/wVPxpfqAHnHO+Aobt3IXyJMMIm/EaEufdaPuwowB0FmR9iLKWTxNahNZpu24cr8PsubR1507bd03xULVWc7+wCxQ3PpAaO04Q5KfDRkHDrRzcyzWrCbv+Maj/AI4CJH9GZ8A+ZVKAOujd4XCULo3088gtY286nf7fG4W3/o899fIQPcjh4XO5ITHZfRX7p95Ob5alxqgJk5F5df7iQbmGOOysma9VRUZXiq6lCx1de0VuGR6kZxINivmVbj3rmx0fmKMJWNS90yc7QLfXkfzvfSvy0myxZ2lYDOA7kfnr+bTNtMXV2KlR0NdPOvvxUc0HDfhizxBU6vGFvB4xhYy+9HNLnNchB3ABWp8nTf+9FqqHIYzrvi5ffgKHIm5EnH0E3opAdK/Hjn7YPvPRQMq97AKqFW5syu+At6iA0a3yu2u1ANW1b0my3EnCn7+Q26J2L22zjkQBakrxiq7AHq1ibHUNg== X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: C17LPl6mXjbVyWrK0WWcA5tdDUkVVQ026eS/sYErwfhGd1fttLV3HpIUkWhZYDjcmMlo6dkWvHpAYsU8YD2b4DuRspIsu97Mbh8QgsyDZAcXmJ4ewCJsktN526YlQA/JreeT2JA0mtA/tJkVy8ssyTN2xMba+c3Kygmsu5sEglH3WVkHEr/RsB3K1jy8aA5r7QbA0cyWdiPKDJioGwDG5QYVoijh+KIDbNCUXGypMUeDieJqhoUdLLzZEEFVd8focwpGDMkB8rFukEXhKXcCIhcLp/nvZondMHyYQI2TrrkZHILNGPNnGxC9M8eZrRX97GzMnCCSUyjPo5NRxsMTNg48vG8SruQ2UHU03uBGfDt5sLGK39vDq08DMQMEnlWcmfWmw6PSQovKwf+Og8sfLn9ey5ek3MReEqAwizFuDyPpxZQQNSpbVuYBfQywwseftFBSG9114hXoqWcrYl4mZj3SzqRjptETfBl0Oo24cTsFJc4r5sS7ZyCfYnA5uAkGh0uRnkzAFrI84onfEafqTBVDw16E5hLMf0afUUds3pLPYN+j0obsYQUthk4QYy2LiQBQiBvUkEnABXyA06JNqReIS/q/Fnb5dWR4H0nhLigoq7NyvfFrff8taI1Qtob9IrUw6+e64V+Sd/qGVz2BlVmbEUkcPhOIzniGSOZ0tioQInSyB3KIzj2O0q+b3z5wPkm18N6gR3vspJ0A0/gQVIcCvVyF39XvGSD1l6EZ6QM+ATbK7Pghi6UW4WH9p14DD2s/3qgH3yaqs0trRzGe4g== X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: eda81cbb-0ee9-4525-f81a-08dbd95934d6 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2888.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2023 15:02:16.8173 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UZICKU3T+Ne7GChV9jw42kOA/Hnp9LCLyK38JMd6Ks2lTsFH9ujKpV5Yr9lz89/G8F9sGIviN/IHuEi31k8f1ODXuMAKm158LCW5l0kIWA0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4206 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-30_10,2023-10-27_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 suspectscore=0 malwarescore=0 phishscore=0 spamscore=0 adultscore=0 bulkscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2310240000 definitions=main-2310300115 X-Proofpoint-ORIG-GUID: 6TJKdwL_wBb3kCDa8xHDd5Fbi5gswk_A X-Proofpoint-GUID: 6TJKdwL_wBb3kCDa8xHDd5Fbi5gswk_A X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list <binutils.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/binutils>, <mailto:binutils-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/binutils/> List-Post: <mailto:binutils@sourceware.org> List-Help: <mailto:binutils-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/binutils>, <mailto:binutils-request@sourceware.org?subject=subscribe> Errors-To: binutils-bounces+patchwork=sourceware.org@sourceware.org |
Series |
gas: bpf: new test for MOV with C-like numbers ll suffix
|
|
Checks
Context | Check | Description |
---|---|---|
linaro-tcwg-bot/tcwg_binutils_check--master-arm | warning | Patch is already merged |
linaro-tcwg-bot/tcwg_binutils_build--master-arm | warning | Patch is already merged |
linaro-tcwg-bot/tcwg_binutils_build--master-aarch64 | warning | Patch is already merged |
linaro-tcwg-bot/tcwg_binutils_check--master-aarch64 | warning | Patch is already merged |
Commit Message
Jose E. Marchesi
Oct. 30, 2023, 3:02 p.m. UTC
The BPF pseudo-c syntax supports both MOV and LDDW instructions: mov: r1 = EXPR lddw: r1 = EXPR ll Note that the white space between EXPR and `ll' is necessary in order to avoid ambiguity with the assembler's support for C-like numerical suffixes. This patch adds a new test to the GAS BPF testsuite to make sure that instructions like: r1 = 666ll are interpreted as `mov %r1,666', not as `lddw %r1,666'. This matches clang's assembler behavior. 2023-10-30 Jose E. Marchesi <jose.marchesi@oracle.com> * testsuite/gas/bpf/alu-pseudoc.s: Add test to make sure C-like suffix `ll' is not interpreted as lddw syntax. * testsuite/gas/bpf/alu-pseudoc.d: Update expected results. * testsuite/gas/bpf/alu-be-pseudoc.d: Likewise. --- gas/ChangeLog | 7 +++++++ gas/testsuite/gas/bpf/alu-be-pseudoc.d | 1 + gas/testsuite/gas/bpf/alu-pseudoc.d | 1 + gas/testsuite/gas/bpf/alu-pseudoc.s | 2 ++ 4 files changed, 11 insertions(+)
Comments
This is pushed. > The BPF pseudo-c syntax supports both MOV and LDDW instructions: > > mov: r1 = EXPR > lddw: r1 = EXPR ll > > Note that the white space between EXPR and `ll' is necessary in order > to avoid ambiguity with the assembler's support for C-like numerical > suffixes. This patch adds a new test to the GAS BPF testsuite to make > sure that instructions like: > > r1 = 666ll > > are interpreted as `mov %r1,666', not as `lddw %r1,666'. > > This matches clang's assembler behavior. > > 2023-10-30 Jose E. Marchesi <jose.marchesi@oracle.com> > > * testsuite/gas/bpf/alu-pseudoc.s: Add test to make sure C-like > suffix `ll' is not interpreted as lddw syntax. > * testsuite/gas/bpf/alu-pseudoc.d: Update expected results. > * testsuite/gas/bpf/alu-be-pseudoc.d: Likewise. > --- > gas/ChangeLog | 7 +++++++ > gas/testsuite/gas/bpf/alu-be-pseudoc.d | 1 + > gas/testsuite/gas/bpf/alu-pseudoc.d | 1 + > gas/testsuite/gas/bpf/alu-pseudoc.s | 2 ++ > 4 files changed, 11 insertions(+) > > diff --git a/gas/ChangeLog b/gas/ChangeLog > index fef3c248196..230a4a73039 100644 > --- a/gas/ChangeLog > +++ b/gas/ChangeLog > @@ -1,3 +1,10 @@ > +2023-10-30 Jose E. Marchesi <jose.marchesi@oracle.com> > + > + * testsuite/gas/bpf/alu-pseudoc.s: Add test to make sure C-like > + suffix `ll' is not interpreted as lddw syntax. > + * testsuite/gas/bpf/alu-pseudoc.d: Update expected results. > + * testsuite/gas/bpf/alu-be-pseudoc.d: Likewise. > + > 2023-10-02 Nick Clifton <nickc@redhat.com> > > PR 30861 > diff --git a/gas/testsuite/gas/bpf/alu-be-pseudoc.d b/gas/testsuite/gas/bpf/alu-be-pseudoc.d > index 4c0f6ba9ca6..80d167c46ff 100644 > --- a/gas/testsuite/gas/bpf/alu-be-pseudoc.d > +++ b/gas/testsuite/gas/bpf/alu-be-pseudoc.d > @@ -69,3 +69,4 @@ Disassembly of section .text: > 1d0: d7 10 00 00 00 00 00 10 r1 = bswap16 r1 > 1d8: d7 20 00 00 00 00 00 20 r2 = bswap32 r2 > 1e0: d7 30 00 00 00 00 00 40 r3 = bswap64 r3 > + 1e8: b7 20 00 00 00 00 02 9a r2=0x29a > diff --git a/gas/testsuite/gas/bpf/alu-pseudoc.d b/gas/testsuite/gas/bpf/alu-pseudoc.d > index b5ab569563c..ea08c9a10da 100644 > --- a/gas/testsuite/gas/bpf/alu-pseudoc.d > +++ b/gas/testsuite/gas/bpf/alu-pseudoc.d > @@ -69,3 +69,4 @@ Disassembly of section .text: > 1d0: d7 01 00 00 10 00 00 00 r1 = bswap16 r1 > 1d8: d7 02 00 00 20 00 00 00 r2 = bswap32 r2 > 1e0: d7 03 00 00 40 00 00 00 r3 = bswap64 r3 > + 1e8: b7 02 00 00 9a 02 00 00 r2=0x29a > \ No newline at end of file > diff --git a/gas/testsuite/gas/bpf/alu-pseudoc.s b/gas/testsuite/gas/bpf/alu-pseudoc.s > index 323a6522f22..3d60d4f7a77 100644 > --- a/gas/testsuite/gas/bpf/alu-pseudoc.s > +++ b/gas/testsuite/gas/bpf/alu-pseudoc.s > @@ -61,3 +61,5 @@ > r1 = bswap16 r1 > r2 = bswap32 r2 > r3 = bswap64 r3 > + ;; The following is to be interpreted as a mov, not lddw. > + r2 = 666ll
On 30.10.2023 16:02, Jose E. Marchesi wrote: > --- a/gas/testsuite/gas/bpf/alu-pseudoc.d > +++ b/gas/testsuite/gas/bpf/alu-pseudoc.d > @@ -69,3 +69,4 @@ Disassembly of section .text: > 1d0: d7 01 00 00 10 00 00 00 r1 = bswap16 r1 > 1d8: d7 02 00 00 20 00 00 00 r2 = bswap32 r2 > 1e0: d7 03 00 00 40 00 00 00 r3 = bswap64 r3 > + 1e8: b7 02 00 00 9a 02 00 00 r2=0x29a > \ No newline at end of file Just as a remark - issues like this would be really nice to be taken care of as files are touched. Imo much better than waiting for a separate cleanup patch. Jan
> On 30.10.2023 16:02, Jose E. Marchesi wrote: >> --- a/gas/testsuite/gas/bpf/alu-pseudoc.d >> +++ b/gas/testsuite/gas/bpf/alu-pseudoc.d >> @@ -69,3 +69,4 @@ Disassembly of section .text: >> 1d0: d7 01 00 00 10 00 00 00 r1 = bswap16 r1 >> 1d8: d7 02 00 00 20 00 00 00 r2 = bswap32 r2 >> 1e0: d7 03 00 00 40 00 00 00 r3 = bswap64 r3 >> + 1e8: b7 02 00 00 9a 02 00 00 r2=0x29a >> \ No newline at end of file > > Just as a remark - issues like this would be really nice to be taken > care of as files are touched. Imo much better than waiting for a > separate cleanup patch. Your point being?
On 30.10.2023 18:34, Jose E. Marchesi wrote: > >> On 30.10.2023 16:02, Jose E. Marchesi wrote: >>> --- a/gas/testsuite/gas/bpf/alu-pseudoc.d >>> +++ b/gas/testsuite/gas/bpf/alu-pseudoc.d >>> @@ -69,3 +69,4 @@ Disassembly of section .text: >>> 1d0: d7 01 00 00 10 00 00 00 r1 = bswap16 r1 >>> 1d8: d7 02 00 00 20 00 00 00 r2 = bswap32 r2 >>> 1e0: d7 03 00 00 40 00 00 00 r3 = bswap64 r3 >>> + 1e8: b7 02 00 00 9a 02 00 00 r2=0x29a >>> \ No newline at end of file >> >> Just as a remark - issues like this would be really nice to be taken >> care of as files are touched. Imo much better than waiting for a >> separate cleanup patch. > > Your point being? "No newline at end of file" is something that shouldn't happen in any source files. Therefore when changing adjacent code it would be nice if the missing newline was inserted at the same time. Jan
> On 30.10.2023 18:34, Jose E. Marchesi wrote: >> >>> On 30.10.2023 16:02, Jose E. Marchesi wrote: >>>> --- a/gas/testsuite/gas/bpf/alu-pseudoc.d >>>> +++ b/gas/testsuite/gas/bpf/alu-pseudoc.d >>>> @@ -69,3 +69,4 @@ Disassembly of section .text: >>>> 1d0: d7 01 00 00 10 00 00 00 r1 = bswap16 r1 >>>> 1d8: d7 02 00 00 20 00 00 00 r2 = bswap32 r2 >>>> 1e0: d7 03 00 00 40 00 00 00 r3 = bswap64 r3 >>>> + 1e8: b7 02 00 00 9a 02 00 00 r2=0x29a >>>> \ No newline at end of file >>> >>> Just as a remark - issues like this would be really nice to be taken >>> care of as files are touched. Imo much better than waiting for a >>> separate cleanup patch. >> >> Your point being? > > "No newline at end of file" is something that shouldn't happen in any > source files. Therefore when changing adjacent code it would be nice > if the missing newline was inserted at the same time. Yes, agreed. In all candour, in this case I didn't even notice it before pushing (was in a rush) or i would have done it. Would you say the same applies to typos and other trivial fixes? Usually I refrain from fixing these that I happen to notice while working on something else, unless they are very coupled with the change (like a typo in a comment describing the code I am changing) even if it is very tempting to do otherwise. I guess it is a question of degree.
On 31.10.2023 11:12, Jose E. Marchesi wrote: > >> On 30.10.2023 18:34, Jose E. Marchesi wrote: >>> >>>> On 30.10.2023 16:02, Jose E. Marchesi wrote: >>>>> --- a/gas/testsuite/gas/bpf/alu-pseudoc.d >>>>> +++ b/gas/testsuite/gas/bpf/alu-pseudoc.d >>>>> @@ -69,3 +69,4 @@ Disassembly of section .text: >>>>> 1d0: d7 01 00 00 10 00 00 00 r1 = bswap16 r1 >>>>> 1d8: d7 02 00 00 20 00 00 00 r2 = bswap32 r2 >>>>> 1e0: d7 03 00 00 40 00 00 00 r3 = bswap64 r3 >>>>> + 1e8: b7 02 00 00 9a 02 00 00 r2=0x29a >>>>> \ No newline at end of file >>>> >>>> Just as a remark - issues like this would be really nice to be taken >>>> care of as files are touched. Imo much better than waiting for a >>>> separate cleanup patch. >>> >>> Your point being? >> >> "No newline at end of file" is something that shouldn't happen in any >> source files. Therefore when changing adjacent code it would be nice >> if the missing newline was inserted at the same time. > > Yes, agreed. In all candour, in this case I didn't even notice it > before pushing (was in a rush) or i would have done it. > > Would you say the same applies to typos and other trivial fixes? > Usually I refrain from fixing these that I happen to notice while > working on something else, unless they are very coupled with the change > (like a typo in a comment describing the code I am changing) even if it > is very tempting to do otherwise. I guess it is a question of degree. My rule of thumb is that anything that's touched anyway can also have cosmetic corrections alongside the main intended adjustment(s). Jan
diff --git a/gas/ChangeLog b/gas/ChangeLog index fef3c248196..230a4a73039 100644 --- a/gas/ChangeLog +++ b/gas/ChangeLog @@ -1,3 +1,10 @@ +2023-10-30 Jose E. Marchesi <jose.marchesi@oracle.com> + + * testsuite/gas/bpf/alu-pseudoc.s: Add test to make sure C-like + suffix `ll' is not interpreted as lddw syntax. + * testsuite/gas/bpf/alu-pseudoc.d: Update expected results. + * testsuite/gas/bpf/alu-be-pseudoc.d: Likewise. + 2023-10-02 Nick Clifton <nickc@redhat.com> PR 30861 diff --git a/gas/testsuite/gas/bpf/alu-be-pseudoc.d b/gas/testsuite/gas/bpf/alu-be-pseudoc.d index 4c0f6ba9ca6..80d167c46ff 100644 --- a/gas/testsuite/gas/bpf/alu-be-pseudoc.d +++ b/gas/testsuite/gas/bpf/alu-be-pseudoc.d @@ -69,3 +69,4 @@ Disassembly of section .text: 1d0: d7 10 00 00 00 00 00 10 r1 = bswap16 r1 1d8: d7 20 00 00 00 00 00 20 r2 = bswap32 r2 1e0: d7 30 00 00 00 00 00 40 r3 = bswap64 r3 + 1e8: b7 20 00 00 00 00 02 9a r2=0x29a diff --git a/gas/testsuite/gas/bpf/alu-pseudoc.d b/gas/testsuite/gas/bpf/alu-pseudoc.d index b5ab569563c..ea08c9a10da 100644 --- a/gas/testsuite/gas/bpf/alu-pseudoc.d +++ b/gas/testsuite/gas/bpf/alu-pseudoc.d @@ -69,3 +69,4 @@ Disassembly of section .text: 1d0: d7 01 00 00 10 00 00 00 r1 = bswap16 r1 1d8: d7 02 00 00 20 00 00 00 r2 = bswap32 r2 1e0: d7 03 00 00 40 00 00 00 r3 = bswap64 r3 + 1e8: b7 02 00 00 9a 02 00 00 r2=0x29a \ No newline at end of file diff --git a/gas/testsuite/gas/bpf/alu-pseudoc.s b/gas/testsuite/gas/bpf/alu-pseudoc.s index 323a6522f22..3d60d4f7a77 100644 --- a/gas/testsuite/gas/bpf/alu-pseudoc.s +++ b/gas/testsuite/gas/bpf/alu-pseudoc.s @@ -61,3 +61,5 @@ r1 = bswap16 r1 r2 = bswap32 r2 r3 = bswap64 r3 + ;; The following is to be interpreted as a mov, not lddw. + r2 = 666ll