Adjust some timeouts for slow CPUs
Commit Message
Hi, this was submitted earlier with the nios2 patches, but Joseph
suggested it to be a separate patch.
Some tests take a really long time to run on slow CPUs, often with no
FPU, like typical Nios II soft-cores; I noticed a few tests started to
timeout after they were updated to use test-skeleton.c.
So I'm seeking permission to adjust the timeouts as attached. This
won't unstabilize anything, okay to commit?
Thanks,
Chung-Lin
2015-01-24 Chung-Lin Tang <cltang@codesourcery.com>
* libio/tst-memstream2.c (TIMEOUT): Define as 100.
* math/atest-exp.c (TIMEOUT): Adjust to 200.
* math/atest-exp2.c (TIMEOUT): Adjust to 300.
* math/atest-sincos.c (TIMEOUT): Adjust to 600.
Comments
Ping?
On 2015/1/24 02:10 PM, Chung-Lin Tang wrote:
> Hi, this was submitted earlier with the nios2 patches, but Joseph
> suggested it to be a separate patch.
>
> Some tests take a really long time to run on slow CPUs, often with no
> FPU, like typical Nios II soft-cores; I noticed a few tests started to
> timeout after they were updated to use test-skeleton.c.
>
> So I'm seeking permission to adjust the timeouts as attached. This
> won't unstabilize anything, okay to commit?
>
> Thanks,
> Chung-Lin
>
> 2015-01-24 Chung-Lin Tang <cltang@codesourcery.com>
>
> * libio/tst-memstream2.c (TIMEOUT): Define as 100.
> * math/atest-exp.c (TIMEOUT): Adjust to 200.
> * math/atest-exp2.c (TIMEOUT): Adjust to 300.
> * math/atest-sincos.c (TIMEOUT): Adjust to 600.
>
From: Chung-Lin Tang <cltang@codesourcery.com>
Date: Tue, 3 Feb 2015 09:37:18 +0800
> Ping?
>
> On 2015/1/24 02:10 PM, Chung-Lin Tang wrote:
>> Hi, this was submitted earlier with the nios2 patches, but Joseph
>> suggested it to be a separate patch.
>>
>> Some tests take a really long time to run on slow CPUs, often with no
>> FPU, like typical Nios II soft-cores; I noticed a few tests started to
>> timeout after they were updated to use test-skeleton.c.
>>
>> So I'm seeking permission to adjust the timeouts as attached. This
>> won't unstabilize anything, okay to commit?
I personally am fine with this. But with it being so close to
making the release branch it's probably best if Carlos makes
the call.
On 02/02/2015 08:37 PM, Chung-Lin Tang wrote:
> Ping?
>
> On 2015/1/24 02:10 PM, Chung-Lin Tang wrote:
>> Hi, this was submitted earlier with the nios2 patches, but Joseph
>> suggested it to be a separate patch.
>>
>> Some tests take a really long time to run on slow CPUs, often with no
>> FPU, like typical Nios II soft-cores; I noticed a few tests started to
>> timeout after they were updated to use test-skeleton.c.
>>
>> So I'm seeking permission to adjust the timeouts as attached. This
>> won't unstabilize anything, okay to commit?
>>
>> Thanks,
>> Chung-Lin
>>
>> 2015-01-24 Chung-Lin Tang <cltang@codesourcery.com>
>>
>> * libio/tst-memstream2.c (TIMEOUT): Define as 100.
>> * math/atest-exp.c (TIMEOUT): Adjust to 200.
>> * math/atest-exp2.c (TIMEOUT): Adjust to 300.
>> * math/atest-sincos.c (TIMEOUT): Adjust to 600.
>>
>
OK, for 2.22 when it opens.
All of our tests should work consistently for all of our supported
machines, and now that Nios II is checked in, this patch has a reason
to exist.
I'm sure you know, but just to reiterate, you could use TIMEOUTFACTOR
env-var to work around this, but it's always good to make this work
out of the box.
Cheers,
Carlos.
On 02/03/2015 01:33 PM, Carlos O'Donell wrote:
> On 02/02/2015 08:37 PM, Chung-Lin Tang wrote:
>> Ping?
>>
>> On 2015/1/24 02:10 PM, Chung-Lin Tang wrote:
>>> Hi, this was submitted earlier with the nios2 patches, but Joseph
>>> suggested it to be a separate patch.
>>>
>>> Some tests take a really long time to run on slow CPUs, often with no
>>> FPU, like typical Nios II soft-cores; I noticed a few tests started to
>>> timeout after they were updated to use test-skeleton.c.
>>>
>>> So I'm seeking permission to adjust the timeouts as attached. This
>>> won't unstabilize anything, okay to commit?
>>>
>>> Thanks,
>>> Chung-Lin
>>>
>>> 2015-01-24 Chung-Lin Tang <cltang@codesourcery.com>
>>>
>>> * libio/tst-memstream2.c (TIMEOUT): Define as 100.
>>> * math/atest-exp.c (TIMEOUT): Adjust to 200.
>>> * math/atest-exp2.c (TIMEOUT): Adjust to 300.
>>> * math/atest-sincos.c (TIMEOUT): Adjust to 600.
>>>
>>
>
> OK, for 2.22 when it opens.
>
> All of our tests should work consistently for all of our supported
> machines, and now that Nios II is checked in, this patch has a reason
> to exist.
>
> I'm sure you know, but just to reiterate, you could use TIMEOUTFACTOR
> env-var to work around this, but it's always good to make this work
> out of the box.
2.22 is open and this is ACK'd.
Please check this in.
Cheers,
Carlos.
On 2015/2/20 01:44 AM, Carlos O'Donell wrote:
> On 02/03/2015 01:33 PM, Carlos O'Donell wrote:
>> On 02/02/2015 08:37 PM, Chung-Lin Tang wrote:
>>> Ping?
>>>
>>> On 2015/1/24 02:10 PM, Chung-Lin Tang wrote:
>>>> Hi, this was submitted earlier with the nios2 patches, but Joseph
>>>> suggested it to be a separate patch.
>>>>
>>>> Some tests take a really long time to run on slow CPUs, often with no
>>>> FPU, like typical Nios II soft-cores; I noticed a few tests started to
>>>> timeout after they were updated to use test-skeleton.c.
>>>>
>>>> So I'm seeking permission to adjust the timeouts as attached. This
>>>> won't unstabilize anything, okay to commit?
>>>>
>>>> Thanks,
>>>> Chung-Lin
>>>>
>>>> 2015-01-24 Chung-Lin Tang <cltang@codesourcery.com>
>>>>
>>>> * libio/tst-memstream2.c (TIMEOUT): Define as 100.
>>>> * math/atest-exp.c (TIMEOUT): Adjust to 200.
>>>> * math/atest-exp2.c (TIMEOUT): Adjust to 300.
>>>> * math/atest-sincos.c (TIMEOUT): Adjust to 600.
>>>>
>>>
>>
>> OK, for 2.22 when it opens.
>>
>> All of our tests should work consistently for all of our supported
>> machines, and now that Nios II is checked in, this patch has a reason
>> to exist.
>>
>> I'm sure you know, but just to reiterate, you could use TIMEOUTFACTOR
>> env-var to work around this, but it's always good to make this work
>> out of the box.
>
> 2.22 is open and this is ACK'd.
>
> Please check this in.
>
> Cheers,
> Carlos.
Done.
Thanks,
Chung-Lin
@@ -100,5 +100,6 @@ do_test (void)
return 0;
}
+#define TIMEOUT 100
#define TEST_FUNCTION do_test ()
#include "../test-skeleton.c"
@@ -191,6 +191,6 @@ do_test (void)
return failures == 0 ? 0 : 1;
}
-#define TIMEOUT 10
+#define TIMEOUT 200
#define TEST_FUNCTION do_test ()
#include "../test-skeleton.c"
@@ -228,6 +228,6 @@ do_test (void)
return failures == 0 ? 0 : 1;
}
-#define TIMEOUT 10
+#define TIMEOUT 300
#define TEST_FUNCTION do_test ()
#include "../test-skeleton.c"
@@ -278,6 +278,6 @@ do_test (void)
return (sin_failures == 0 && cos_failures == 0) ? 0 : 1;
}
-#define TIMEOUT 10
+#define TIMEOUT 600
#define TEST_FUNCTION do_test ()
#include "../test-skeleton.c"