[hurd,commited] hurd: Fix _NOFLSH value
Checks
Commit Message
shifting 1 (thus an integer) left 31 bit is undefined behavior. We have to
make it an unsigned integer to properly get 0x80000000 (like done in other
places).
---
bits/termios.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 15/1/23 20:56, Samuel Thibault wrote:
> shifting 1 (thus an integer) left 31 bit is undefined behavior. We have to
> make it an unsigned integer to properly get 0x80000000 (like done in other
> places).
> ---
> bits/termios.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
@@ -246,7 +246,7 @@ struct termios
# define NOKERNINFO (1 << 25) /* Disable VSTATUS. */
# define PENDIN (1 << 29) /* Retype pending input (state). */
#endif
-#define _NOFLSH (1 << 31) /* Disable flush after interrupt. */
+#define _NOFLSH (1U << 31) /* Disable flush after interrupt. */
#define NOFLSH _NOFLSH
/* Control characters. */