diff mbox series

stdio-common: Add missing dependencies (bug 29780)

Message ID mvmtu2sa35c.fsf@suse.de
State Committed
Commit a46956e65d037358161e7512a9f0fd408ea1333a
Delegated to: Adhemerval Zanella Netto
Headers
Series stdio-common: Add missing dependencies (bug 29780) |

Checks

Context Check Description
dj/TryBot-apply_patch success Patch applied to master at the time it was sent
dj/TryBot-32bit success Build for i686

Commit Message

Andreas Schwab Nov. 21, 2022, 12:43 p.m. UTC 
  Handle all object suffixes for dependencies of errlist-data and siglist
objects.
---
 stdio-common/Makefile | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Florian Weimer Nov. 21, 2022, 4:06 p.m. UTC | #1 
* Andreas Schwab via Libc-alpha:

> Handle all object suffixes for dependencies of errlist-data and siglist
> objects.
> ---
>  stdio-common/Makefile | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/stdio-common/Makefile b/stdio-common/Makefile
> index 401dac69de..fe57dbdf56 100644
> --- a/stdio-common/Makefile
> +++ b/stdio-common/Makefile
> @@ -272,7 +272,8 @@ ifndef no_deps
>  endif
>  
>  $(objpfx)errlist-data.os: $(objpfx)errlist-data-aux-shared.S
> -$(objpfx)errlist-data.o: $(objpfx)errlist-data-aux.S
> +$(addprefix $(objpfx)errlist-data, $(object-suffixes-noshared)): \
> +  $(objpfx)errlist-data-aux.S
>  
>  $(objpfx)siglist-aux-shared.S: siglist-gen.c
>  	$(make-target-directory)
> @@ -287,7 +288,8 @@ ifndef no_deps
>  endif
>  
>  $(objpfx)siglist.os: $(objpfx)siglist-aux-shared.S
> -$(objpfx)siglist.o: $(objpfx)siglist-aux.S
> +$(addprefix $(objpfx)siglist, $(object-suffixes-noshared)): \
> +  $(objpfx)siglist-aux.S
>  
>  ifeq ($(run-built-tests),yes)
>  LOCALES := \

Looks okay, thanks.

Reviewed-by: Florian Weimer <fweimer@redhat.com>

Florian
diff mbox series

Patch

diff --git a/stdio-common/Makefile b/stdio-common/Makefile
index 401dac69de..fe57dbdf56 100644
--- a/stdio-common/Makefile
+++ b/stdio-common/Makefile
@@ -272,7 +272,8 @@  ifndef no_deps
 endif
 
 $(objpfx)errlist-data.os: $(objpfx)errlist-data-aux-shared.S
-$(objpfx)errlist-data.o: $(objpfx)errlist-data-aux.S
+$(addprefix $(objpfx)errlist-data, $(object-suffixes-noshared)): \
+  $(objpfx)errlist-data-aux.S
 
 $(objpfx)siglist-aux-shared.S: siglist-gen.c
 	$(make-target-directory)
@@ -287,7 +288,8 @@  ifndef no_deps
 endif
 
 $(objpfx)siglist.os: $(objpfx)siglist-aux-shared.S
-$(objpfx)siglist.o: $(objpfx)siglist-aux.S
+$(addprefix $(objpfx)siglist, $(object-suffixes-noshared)): \
+  $(objpfx)siglist-aux.S
 
 ifeq ($(run-built-tests),yes)
 LOCALES := \