benchtests: Updated json bench-variant attribute
Commit Message
This patch updates json "bench-variant" attribute of "bench-memset.c"
to "default" so that the script "benchtests/scripts/plot_strings.py"
can generate a file "memset_time_default_linear.png".
Without this patch, the script "benchtests/scripts/plot_strings.py"
generates a file "memset_time__linear.png" which has inconsistent form
with "memcpy_time_default_linear.png" and
"memmove_time_default_linear.png".
---
benchtests/bench-memset.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 2/8/21 1:29 PM, Naohiro Tamura wrote:
> This patch updates json "bench-variant" attribute of "bench-memset.c"
> to "default" so that the script "benchtests/scripts/plot_strings.py"
> can generate a file "memset_time_default_linear.png".
> Without this patch, the script "benchtests/scripts/plot_strings.py"
> generates a file "memset_time__linear.png" which has inconsistent form
> with "memcpy_time_default_linear.png" and
> "memmove_time_default_linear.png".
That's nicer, I agree. Looks good to me, I'll commit it if you don't
have access.
Siddhesh
Siddhesh-san,
> -----Original Message-----
> From: Siddhesh Poyarekar <siddhesh@gotplt.org>
> Sent: Monday, February 8, 2021 11:09 PM
> To: Tamura, Naohiro/田村 直広 <naohirot@fujitsu.com>;
> libc-alpha@sourceware.org
> Subject: Re: [PATCH] benchtests: Updated json bench-variant attribute
>
> On 2/8/21 1:29 PM, Naohiro Tamura wrote:
> > This patch updates json "bench-variant" attribute of "bench-memset.c"
> > to "default" so that the script "benchtests/scripts/plot_strings.py"
> > can generate a file "memset_time_default_linear.png".
> > Without this patch, the script "benchtests/scripts/plot_strings.py"
> > generates a file "memset_time__linear.png" which has inconsistent form
> > with "memcpy_time_default_linear.png" and
> > "memmove_time_default_linear.png".
>
> That's nicer, I agree. Looks good to me, I'll commit it if you don't have access.
Thank you for reviewing quickly.
Yes, please, I don't have the access. I appreciate that!
Naohiro
> Siddhesh
@@ -97,7 +97,7 @@ test_main (void)
json_attr_object_begin (&json_ctx, "functions");
json_attr_object_begin (&json_ctx, TEST_NAME);
- json_attr_string (&json_ctx, "bench-variant", "");
+ json_attr_string (&json_ctx, "bench-variant", "default");
json_array_begin (&json_ctx, "ifuncs");
FOR_EACH_IMPL (impl, 0)