Message ID | cover.1585914979.git.fweimer@redhat.com |
---|---|
Headers |
Return-Path: <fweimer@redhat.com> X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by sourceware.org (Postfix) with ESMTP id A91F0385B833 for <libc-alpha@sourceware.org>; Fri, 3 Apr 2020 12:02:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A91F0385B833 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-122-zrwEiA1MPoKSN9hR2fOX3Q-1; Fri, 03 Apr 2020 08:02:48 -0400 X-MC-Unique: zrwEiA1MPoKSN9hR2fOX3Q-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B78761005509 for <libc-alpha@sourceware.org>; Fri, 3 Apr 2020 12:02:47 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-113-15.ams2.redhat.com [10.36.113.15]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1EF2D5DDB1 for <libc-alpha@sourceware.org>; Fri, 3 Apr 2020 12:02:46 +0000 (UTC) From: Florian Weimer <fweimer@redhat.com> To: libc-alpha@sourceware.org Subject: [PATCH 0/3] Add DT_AUDIT support [BZ #24943] Message-Id: <cover.1585914979.git.fweimer@redhat.com> Date: Fri, 03 Apr 2020 14:02:45 +0200 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-18.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org> List-Unsubscribe: <http://sourceware.org/mailman/options/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help> List-Subscribe: <http://sourceware.org/mailman/listinfo/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=subscribe> X-List-Received-Date: Fri, 03 Apr 2020 12:02:51 -0000 |
Series | Add DT_AUDIT support [BZ #24943] | |
Message
Florian Weimer
April 3, 2020, 12:02 p.m. UTC
xgetline has been committed separately with slightly different behavior. I think the zero-on-EOF behavior is preferable, so I'm switching the implementation to that. It turns out that it is possible to simplify the audit string list processing, so the second commit does that. Tested on x86_64-linux-gnu and i686-linux-gnu. Thanks, Florian Florian Weimer (3): support: Change xgetline to return 0 on EOF elf: Simplify handling of lists of audit strings elf: Implement DT_AUDIT, DT_DEPAUDIT support [BZ #24943] NEWS | 3 + elf/Makefile | 22 ++- elf/rtld.c | 247 +++++++++++++++++--------------- elf/tst-audit14.c | 46 ++++++ elf/tst-audit15.c | 50 +++++++ elf/tst-audit16.c | 54 +++++++ elf/tst-auditlogmod-1.c | 27 ++++ elf/tst-auditlogmod-2.c | 27 ++++ elf/tst-auditlogmod-3.c | 27 ++++ support/support_process_state.c | 2 +- support/xgetline.c | 22 +-- support/xstdio.h | 5 +- 12 files changed, 405 insertions(+), 127 deletions(-) create mode 100644 elf/tst-audit14.c create mode 100644 elf/tst-audit15.c create mode 100644 elf/tst-audit16.c create mode 100644 elf/tst-auditlogmod-1.c create mode 100644 elf/tst-auditlogmod-2.c create mode 100644 elf/tst-auditlogmod-3.c
Comments
On 4/3/20 8:02 AM, Florian Weimer via Libc-alpha wrote: > xgetline has been committed separately with slightly different behavior. > I think the zero-on-EOF behavior is preferable, so I'm switching the > implementation to that. > > It turns out that it is possible to simplify the audit string list > processing, so the second commit does that. > > Tested on x86_64-linux-gnu and i686-linux-gnu. Thanks for working on this. The auditors, despite the implementation being a bit immature, are a useful way to alter the dynamic loaders behaviour. Your patches go a long way to improving this framework, and you add some nice internal API design examples.