Don't use PSEUDO_END for non-PSEUDO function
Commit Message
* sysdeps/unix/sysv/linux/riscv/setcontext.S: Use END instead of
PSEUDO_END.
---
sysdeps/unix/sysv/linux/riscv/setcontext.S | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
* Andreas Schwab:
> * sysdeps/unix/sysv/linux/riscv/setcontext.S: Use END instead of
> PSEUDO_END.
Is this just about cosmetics, or does this change fix a bug?
Thanks,
Florian
On Okt 22 2018, Florian Weimer <fweimer@redhat.com> wrote:
> * Andreas Schwab:
>
>> * sysdeps/unix/sysv/linux/riscv/setcontext.S: Use END instead of
>> PSEUDO_END.
>
> Is this just about cosmetics, or does this change fix a bug?
Neither. PSEUDO_END defines a useless syscall error label.
Andreas.
On Mon, 22 Oct 2018 03:16:53 PDT (-0700), schwab@suse.de wrote:
> * sysdeps/unix/sysv/linux/riscv/setcontext.S: Use END instead of
> PSEUDO_END.
I'm terrible with changelogs, but I think this should contain the functions
that were modified. I'd have it look like
* sysdeps/unix/sysv/linux/riscv/setcontext.S (__setcontext): Use END
instead of PSEUDO_END.
(__start_context): Likewise.
I might be wrong, though.
> ---
> sysdeps/unix/sysv/linux/riscv/setcontext.S | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sysdeps/unix/sysv/linux/riscv/setcontext.S b/sysdeps/unix/sysv/linux/riscv/setcontext.S
> index d676fa9329..ed2c38ef2b 100644
> --- a/sysdeps/unix/sysv/linux/riscv/setcontext.S
> +++ b/sysdeps/unix/sysv/linux/riscv/setcontext.S
> @@ -94,7 +94,7 @@ LEAF (__setcontext)
>
> 99: j __syscall_error
>
> -PSEUDO_END (__setcontext)
> +END (__setcontext)
> weak_alias (__setcontext, setcontext)
>
> LEAF (__start_context)
> @@ -112,4 +112,4 @@ LEAF (__start_context)
> jal __setcontext
> 1: j exit
>
> -PSEUDO_END (__start_context)
> +END (__start_context)
Thanks. Do you commit to glibc or do you want me to?
On Okt 22 2018, Palmer Dabbelt <palmer@sifive.com> wrote:
> On Mon, 22 Oct 2018 03:16:53 PDT (-0700), schwab@suse.de wrote:
>> * sysdeps/unix/sysv/linux/riscv/setcontext.S: Use END instead of
>> PSEUDO_END.
>
> I'm terrible with changelogs, but I think this should contain the
> functions that were modified. I'd have it look like
>
> * sysdeps/unix/sysv/linux/riscv/setcontext.S (__setcontext): Use END
> instead of PSEUDO_END.
> (__start_context): Likewise.
>
> I might be wrong, though.
You're right, I should have known better.
Andreas.
@@ -94,7 +94,7 @@ LEAF (__setcontext)
99: j __syscall_error
-PSEUDO_END (__setcontext)
+END (__setcontext)
weak_alias (__setcontext, setcontext)
LEAF (__start_context)
@@ -112,4 +112,4 @@ LEAF (__start_context)
jal __setcontext
1: j exit
-PSEUDO_END (__start_context)
+END (__start_context)