S390: Fix remaining Wundef ONE_DIRECTION warning messages
Commit Message
Hi,
This patch fixes the remaining Wundef ONE_DIRECTION warnings for s390
specific conversions.
It defines ONE_DIRECTION to 0 like the patch from Steve Ellcey:
https://www.sourceware.org/ml/libc-alpha/2014-05/msg00039.html
OK to commit?
Bye
Stefan
---
2014-07-31 Stefan Liebler <stli@linux.vnet.ibm.com>
* sysdeps/s390/s390-64/utf16-utf32-z9.c
(ONE_DIRECTION): Define.
* sysdeps/s390/s390-64/utf8-utf16-z9.c
(ONE_DIRECTION): Define.
* sysdeps/s390/s390-64/utf8-utf32-z9.c
(ONE_DIRECTION): Define.
commit 7507692a7e2ea9a17268ec75f1bd04bc2d6ddeb1
Author: Stefan Liebler <stli@linux.vnet.ibm.com>
Date: Thu Jul 31 10:50:48 2014 +0200
[PATCH] S390: Fix remaining ONE_DIRECTION warning messages
This patch fixes the remaining ONE_DIRECTION warnings for s390 specific conversions.
It defines ONE_DIRECTION to 0 like the patch from Steve Ellcey:
https://www.sourceware.org/ml/libc-alpha/2014-05/msg00039.html
Changelog:
* sysdeps/s390/s390-64/utf16-utf32-z9.c
(ONE_DIRECTION): Define.
* sysdeps/s390/s390-64/utf8-utf16-z9.c
(ONE_DIRECTION): Define.
* sysdeps/s390/s390-64/utf8-utf32-z9.c
(ONE_DIRECTION): Define.
Comments
On Thu, Jul 31, 2014 at 12:15:44PM +0200, Stefan Liebler wrote:
> Hi,
>
> This patch fixes the remaining Wundef ONE_DIRECTION warnings for s390
> specific conversions.
>
> It defines ONE_DIRECTION to 0 like the patch from Steve Ellcey:
> https://www.sourceware.org/ml/libc-alpha/2014-05/msg00039.html
>
> OK to commit?
OK if you have verified that the generated source is identical.
Thanks,
Siddhesh
On 07/31/2014 12:38 PM, Siddhesh Poyarekar wrote:
> On Thu, Jul 31, 2014 at 12:15:44PM +0200, Stefan Liebler wrote:
>> Hi,
>>
>> This patch fixes the remaining Wundef ONE_DIRECTION warnings for s390
>> specific conversions.
>>
>> It defines ONE_DIRECTION to 0 like the patch from Steve Ellcey:
>> https://www.sourceware.org/ml/libc-alpha/2014-05/msg00039.html
>>
>> OK to commit?
>
> OK if you have verified that the generated source is identical.
>
> Thanks,
> Siddhesh
>
Yes, the generated source and the objdumps are identical.
Thanks
Stefan
@@ -44,6 +44,7 @@
#define FROM_LOOP from_utf16_loop
#define TO_LOOP to_utf16_loop
#define FROM_DIRECTION (dir == from_utf16)
+#define ONE_DIRECTION 0
#define PREPARE_LOOP \
enum direction dir = ((struct utf16_data *) step->__data)->dir; \
int emit_bom = ((struct utf16_data *) step->__data)->emit_bom; \
@@ -42,6 +42,7 @@
#define FROM_LOOP from_utf8_loop
#define TO_LOOP to_utf8_loop
#define FROM_DIRECTION (dir == from_utf8)
+#define ONE_DIRECTION 0
#define PREPARE_LOOP \
enum direction dir = ((struct utf8_data *) step->__data)->dir; \
int emit_bom = ((struct utf8_data *) step->__data)->emit_bom; \
@@ -44,6 +44,7 @@
#define FROM_LOOP from_utf8_loop
#define TO_LOOP to_utf8_loop
#define FROM_DIRECTION (dir == from_utf8)
+#define ONE_DIRECTION 0
#define PREPARE_LOOP \
enum direction dir = ((struct utf8_data *) step->__data)->dir; \
int emit_bom = ((struct utf8_data *) step->__data)->emit_bom; \