licensing status for files without notice

Message ID dab1e14a-9123-cdbd-27d7-188daf91a97d@redhat.com
State Committed
Headers

Commit Message

Florian Weimer Jan. 2, 2018, 6:39 p.m. UTC
  On 01/02/2018 07:29 PM, Joseph Myers wrote:
> On Tue, 2 Jan 2018, Christoph Hellwig wrote:
> 
>> Hi all,
>>
>> what license are files in glibc under that do not have an explicit
>> copyright notice?
> 
> We should put a standard LGPL notice on any such files more than ten lines
> long.  (However, to get the copyright dates for an old file without a
> copyright notice it may be necessary to check history.git for when the
> file was actually created, because of problems with the coalescing of
> commits into subsequent ChangeLog commits in earlier history.)

I think the ChangeLog files themselves are sufficiently accurate to 
determine the year of the change.

Thanks,
Florian
  

Comments

Joseph Myers Jan. 2, 2018, 8:43 p.m. UTC | #1
On Tue, 2 Jan 2018, Florian Weimer wrote:

> On 01/02/2018 07:29 PM, Joseph Myers wrote:
> > On Tue, 2 Jan 2018, Christoph Hellwig wrote:
> > 
> > > Hi all,
> > > 
> > > what license are files in glibc under that do not have an explicit
> > > copyright notice?
> > 
> > We should put a standard LGPL notice on any such files more than ten lines
> > long.  (However, to get the copyright dates for an old file without a
> > copyright notice it may be necessary to check history.git for when the
> > file was actually created, because of problems with the coalescing of
> > commits into subsequent ChangeLog commits in earlier history.)
> 
> I think the ChangeLog files themselves are sufficiently accurate to determine
> the year of the change.

Yes, if the addition of such a file is mentioned in a ChangeLog, that can 
be used to determine the start year for the copyright range.
  
Carlos O'Donell Jan. 2, 2018, 9:04 p.m. UTC | #2
On 01/02/2018 10:39 AM, Florian Weimer wrote:
> On 01/02/2018 07:29 PM, Joseph Myers wrote:
>> On Tue, 2 Jan 2018, Christoph Hellwig wrote:
>>
>>> Hi all,
>>>
>>> what license are files in glibc under that do not have an explicit
>>> copyright notice?
>>
>> We should put a standard LGPL notice on any such files more than ten lines
>> long.  (However, to get the copyright dates for an old file without a
>> copyright notice it may be necessary to check history.git for when the
>> file was actually created, because of problems with the coalescing of
>> commits into subsequent ChangeLog commits in earlier history.)
> 
> I think the ChangeLog files themselves are sufficiently accurate to determine the year of the change.
> 
> Thanks,
> Florian
> 
> tst-pselect.patch
> 
> 
> Subject: [PATCH] misc/tst-pselect.c: Add copyright header
> To: libc-alpha@sourceware.org
> 
> The initial year is based on the date in the original ChangeLog entry
> (2006-01-21).
> 
> 2018-01-02  Florian Weimer  <fweimer@redhat.com>
> 
> 	* misc/tst-pselect.c: Add copyright header.

LGTM.

Relevant ChangeLog was ChangeLog.old/ChangeLog.16.

Entry was for 2006-01-21, the file in question was created by Ulrich Drepper
while at Red Hat.

The git history is also accurate.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>

> diff --git a/misc/tst-pselect.c b/misc/tst-pselect.c
> index 0d11a809a0..fc28d64238 100644
> --- a/misc/tst-pselect.c
> +++ b/misc/tst-pselect.c
> @@ -1,3 +1,20 @@
> +/* Copyright (C) 2006-2018 Free Software Foundation, Inc.
> +   This file is part of the GNU C Library.
> +
> +   The GNU C Library is free software; you can redistribute it and/or
> +   modify it under the terms of the GNU Lesser General Public
> +   License as published by the Free Software Foundation; either
> +   version 2.1 of the License, or (at your option) any later version.
> +
> +   The GNU C Library is distributed in the hope that it will be useful,
> +   but WITHOUT ANY WARRANTY; without even the implied warranty of
> +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> +   Lesser General Public License for more details.
> +
> +   You should have received a copy of the GNU Lesser General Public
> +   License along with the GNU C Library; if not, see
> +   <http://www.gnu.org/licenses/>.  */
> +
>  #include <errno.h>
>  #include <signal.h>
>  #include <stdio.h>
  

Patch

Subject: [PATCH] misc/tst-pselect.c: Add copyright header
To: libc-alpha@sourceware.org

The initial year is based on the date in the original ChangeLog entry
(2006-01-21).

2018-01-02  Florian Weimer  <fweimer@redhat.com>

	* misc/tst-pselect.c: Add copyright header.

diff --git a/misc/tst-pselect.c b/misc/tst-pselect.c
index 0d11a809a0..fc28d64238 100644
--- a/misc/tst-pselect.c
+++ b/misc/tst-pselect.c
@@ -1,3 +1,20 @@ 
+/* Copyright (C) 2006-2018 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <http://www.gnu.org/licenses/>.  */
+
 #include <errno.h>
 #include <signal.h>
 #include <stdio.h>