sparcv9: Restore fdiml@GLIBC_2.1 [Was Re: [PATCH 3/3] sparc32/sparcv9: add a VIS3 version of fdim]
Message ID | d29e26c5-c8e1-115a-9ec6-b51092cb1d82@linux.vnet.ibm.com |
---|---|
State | Committed |
Delegated to: | Aurelien Jarno |
Headers |
Received: (qmail 48976 invoked by alias); 26 Aug 2016 19:28:21 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <libc-alpha.sourceware.org> List-Unsubscribe: <mailto:libc-alpha-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 48958 invoked by uid 89); 26 Aug 2016 19:28:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL, BAYES_00, KAM_LAZY_DOMAIN_SECURITY, RCVD_IN_DNSWL_LOW, RCVD_IN_SEMBACKSCATTER autolearn=no version=3.3.2 spammy=F22, f22, D*GLIBC_2.1, D*1 X-HELO: mx0a-001b2d01.pphosted.com X-IBM-Helo: d03dlp03.boulder.ibm.com X-IBM-MailFrom: murphyp@linux.vnet.ibm.com Subject: [PATCH] sparcv9: Restore fdiml@GLIBC_2.1 [Was Re: [PATCH 3/3] sparc32/sparcv9: add a VIS3 version of fdim] References: <ec60b568-194d-10c1-d141-744cbbc5e184@linux.vnet.ibm.com> In-Reply-To: <ec60b568-194d-10c1-d141-744cbbc5e184@linux.vnet.ibm.com> To: Aurelien Jarno <aurelien@aurel32.net> Cc: "libc-alpha@sourceware.org" <libc-alpha@sourceware.org> From: "Paul E. Murphy" <murphyp@linux.vnet.ibm.com> X-Forwarded-Message-Id: <ec60b568-194d-10c1-d141-744cbbc5e184@linux.vnet.ibm.com> Date: Fri, 26 Aug 2016 14:28:12 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16082619-0008-0000-0000-0000056839EC X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00005644; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000183; SDB=6.00750112; UDB=6.00354234; IPR=6.00522747; BA=6.00004676; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00012480; XFM=3.00000011; UTC=2016-08-26 19:28:16 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16082619-0009-0000-0000-00003A9ADE13 Message-Id: <d29e26c5-c8e1-115a-9ec6-b51092cb1d82@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2016-08-26_13:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1608260246 |
Commit Message
Paul E. Murphy
Aug. 26, 2016, 7:28 p.m. UTC
Hi Aurelien, [Sorry for the duplicate, I forgot the CC to libc-alpha] I tested using the F22 cross-compiler on x86-64, and verified the symbol is once again exported. It turns out most other architectures don't have quite as convoluted Implies as ppc64. Likewise, doing "#include_next <s_fdim.c>" gave me a compiler error. I'll commit the following if it is ok. ---8<--- Use s_fdim.c from sysdeps/ieee754/ldbl-opt/ instead of math/ to ensure a compat symbol for fdiml is created. [BZ #20517] * sysdeps/sparc/sparc32/sparcv9/fpu/multiarch/s_fdim.c: Include ldbl-opt/s_fdim.c to ensure fdiml@GLIBC_2.1 is exported. --- sysdeps/sparc/sparc32/sparcv9/fpu/multiarch/s_fdim.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Hi, On 2016-08-26 14:28, Paul E. Murphy wrote: > > Hi Aurelien, > > [Sorry for the duplicate, I forgot the CC to libc-alpha] > > I tested using the F22 cross-compiler on x86-64, and verified > the symbol is once again exported. > > It turns out most other architectures don't have quite as > convoluted Implies as ppc64. > > Likewise, doing "#include_next <s_fdim.c>" gave me a > compiler error. > > I'll commit the following if it is ok. > > ---8<--- > Use s_fdim.c from sysdeps/ieee754/ldbl-opt/ instead of > math/ to ensure a compat symbol for fdiml is created. > > [BZ #20517] > * sysdeps/sparc/sparc32/sparcv9/fpu/multiarch/s_fdim.c: > Include ldbl-opt/s_fdim.c to ensure fdiml@GLIBC_2.1 is > exported. > --- > sysdeps/sparc/sparc32/sparcv9/fpu/multiarch/s_fdim.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sysdeps/sparc/sparc32/sparcv9/fpu/multiarch/s_fdim.c b/sysdeps/sparc/sparc32/sparcv9/fpu/multiarch/s_fdim.c > index c9c7704..9666741 100644 > --- a/sysdeps/sparc/sparc32/sparcv9/fpu/multiarch/s_fdim.c > +++ b/sysdeps/sparc/sparc32/sparcv9/fpu/multiarch/s_fdim.c > @@ -29,4 +29,4 @@ weak_alias (__fdim, fdim) > # define __fdim __fdim_generic > #endif > > -#include <math/s_fdim.c> > +#include <ldbl-opt/s_fdim.c> I confirm this patch is correct. I have done a 32-bit build and it works as expected, the symbol is back. I have added David Miller in Cc: so that he can also ack the patch. Aurelien
From: Aurelien Jarno <aurelien@aurel32.net> Date: Sat, 27 Aug 2016 12:48:23 +0200 > On 2016-08-26 14:28, Paul E. Murphy wrote: >> >> diff --git a/sysdeps/sparc/sparc32/sparcv9/fpu/multiarch/s_fdim.c b/sysdeps/sparc/sparc32/sparcv9/fpu/multiarch/s_fdim.c >> index c9c7704..9666741 100644 >> --- a/sysdeps/sparc/sparc32/sparcv9/fpu/multiarch/s_fdim.c >> +++ b/sysdeps/sparc/sparc32/sparcv9/fpu/multiarch/s_fdim.c >> @@ -29,4 +29,4 @@ weak_alias (__fdim, fdim) >> # define __fdim __fdim_generic >> #endif >> >> -#include <math/s_fdim.c> >> +#include <ldbl-opt/s_fdim.c> > > I confirm this patch is correct. I have done a 32-bit build and it works > as expected, the symbol is back. I have added David Miller in Cc: so > that he can also ack the patch. This is fine with me.
On 08/27/2016 11:50 PM, David Miller wrote: > From: Aurelien Jarno <aurelien@aurel32.net> > Date: Sat, 27 Aug 2016 12:48:23 +0200 > >> On 2016-08-26 14:28, Paul E. Murphy wrote: >>> >>> diff --git a/sysdeps/sparc/sparc32/sparcv9/fpu/multiarch/s_fdim.c b/sysdeps/sparc/sparc32/sparcv9/fpu/multiarch/s_fdim.c >>> index c9c7704..9666741 100644 >>> --- a/sysdeps/sparc/sparc32/sparcv9/fpu/multiarch/s_fdim.c >>> +++ b/sysdeps/sparc/sparc32/sparcv9/fpu/multiarch/s_fdim.c >>> @@ -29,4 +29,4 @@ weak_alias (__fdim, fdim) >>> # define __fdim __fdim_generic >>> #endif >>> >>> -#include <math/s_fdim.c> >>> +#include <ldbl-opt/s_fdim.c> >> >> I confirm this patch is correct. I have done a 32-bit build and it works >> as expected, the symbol is back. I have added David Miller in Cc: so >> that he can also ack the patch. > > This is fine with me. > Thanks. Committed as d47d27d.
diff --git a/sysdeps/sparc/sparc32/sparcv9/fpu/multiarch/s_fdim.c b/sysdeps/sparc/sparc32/sparcv9/fpu/multiarch/s_fdim.c index c9c7704..9666741 100644 --- a/sysdeps/sparc/sparc32/sparcv9/fpu/multiarch/s_fdim.c +++ b/sysdeps/sparc/sparc32/sparcv9/fpu/multiarch/s_fdim.c @@ -29,4 +29,4 @@ weak_alias (__fdim, fdim) # define __fdim __fdim_generic #endif -#include <math/s_fdim.c> +#include <ldbl-opt/s_fdim.c>