diff mbox series

[v3,14/19] RISC-V: Fix llrint and llround missing exceptions on RV32

Message ID b2373731b97952b74a5fda99dc96d649a9d780d8.1594568655.git.alistair.francis@wdc.com
State New
Headers show
Series glibc port for 32-bit RISC-V (RV32) | expand

Commit Message

Alistair Francis July 12, 2020, 3:47 p.m. UTC
From: Zong Li <zongbox@gmail.com>

Similar to the fix for MIPS, ARM and S/390, RV32 is missing
correct exception on overflow from llrint and llround functions because
cast from floating-point types to long long do not result in correct
exceptions on overflow.
---
 .../riscv/rv32/fix-fp-int-convert-overflow.h  | 38 +++++++++++++++++++
 1 file changed, 38 insertions(+)
 create mode 100644 sysdeps/riscv/rv32/fix-fp-int-convert-overflow.h

Comments

Maciej W. Rozycki July 14, 2020, 10:13 p.m. UTC | #1
On Sun, 12 Jul 2020, Alistair Francis via Libc-alpha wrote:

> Similar to the fix for MIPS, ARM and S/390, RV32 is missing
> correct exception on overflow from llrint and llround functions because
> cast from floating-point types to long long do not result in correct
> exceptions on overflow.

 Odd grammar and formatting.

> diff --git a/sysdeps/riscv/rv32/fix-fp-int-convert-overflow.h b/sysdeps/riscv/rv32/fix-fp-int-convert-overflow.h
> new file mode 100644
> index 0000000000..2ab1497587
> --- /dev/null
> +++ b/sysdeps/riscv/rv32/fix-fp-int-convert-overflow.h
> @@ -0,0 +1,38 @@
> +/* Fix for conversion of floating point to integer overflow. RISC-V version.

 Two spaces after a sentence please.

> +/* The generic libgcc2.c conversions from floating point
> +   to long long may not raise the correct exceptions on overflow (and
> +   may raise spurious "inexact" exceptions even in non-overflow cases,
> +   see <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59412>).  */

 Odd formatting as well, how about:

/* The generic libgcc2.c conversions from floating point to long long
   may not raise the correct exceptions on overflow (and may raise 
   spurious "inexact" exceptions even in non-overflow cases, see 
   <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59412>).  */

?

 Otherwise OK.

  Maciej
Alistair Francis July 22, 2020, 4:30 p.m. UTC | #2
On Tue, Jul 14, 2020 at 3:13 PM Maciej W. Rozycki via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> On Sun, 12 Jul 2020, Alistair Francis via Libc-alpha wrote:
>
> > Similar to the fix for MIPS, ARM and S/390, RV32 is missing
> > correct exception on overflow from llrint and llround functions because
> > cast from floating-point types to long long do not result in correct
> > exceptions on overflow.
>
>  Odd grammar and formatting.
>
> > diff --git a/sysdeps/riscv/rv32/fix-fp-int-convert-overflow.h b/sysdeps/riscv/rv32/fix-fp-int-convert-overflow.h
> > new file mode 100644
> > index 0000000000..2ab1497587
> > --- /dev/null
> > +++ b/sysdeps/riscv/rv32/fix-fp-int-convert-overflow.h
> > @@ -0,0 +1,38 @@
> > +/* Fix for conversion of floating point to integer overflow. RISC-V version.
>
>  Two spaces after a sentence please.
>
> > +/* The generic libgcc2.c conversions from floating point
> > +   to long long may not raise the correct exceptions on overflow (and
> > +   may raise spurious "inexact" exceptions even in non-overflow cases,
> > +   see <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59412>).  */
>
>  Odd formatting as well, how about:
>
> /* The generic libgcc2.c conversions from floating point to long long
>    may not raise the correct exceptions on overflow (and may raise
>    spurious "inexact" exceptions even in non-overflow cases, see
>    <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59412>).  */
>
> ?

Fixed!

Alistair

>
>  Otherwise OK.
>
>   Maciej
diff mbox series

Patch

diff --git a/sysdeps/riscv/rv32/fix-fp-int-convert-overflow.h b/sysdeps/riscv/rv32/fix-fp-int-convert-overflow.h
new file mode 100644
index 0000000000..2ab1497587
--- /dev/null
+++ b/sysdeps/riscv/rv32/fix-fp-int-convert-overflow.h
@@ -0,0 +1,38 @@ 
+/* Fix for conversion of floating point to integer overflow. RISC-V version.
+   Copyright (C) 2020 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <https://www.gnu.org/licenses/>.  */
+
+#ifndef FIX_FP_INT_CONVERT_OVERFLOW_H
+#define FIX_FP_INT_CONVERT_OVERFLOW_H	1
+
+/* The generic libgcc2.c conversions from floating point
+   to long long may not raise the correct exceptions on overflow (and
+   may raise spurious "inexact" exceptions even in non-overflow cases,
+   see <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59412>).  */
+#define FIX_FLT_LONG_CONVERT_OVERFLOW 0
+#define FIX_FLT_LLONG_CONVERT_OVERFLOW 1
+
+#define FIX_DBL_LONG_CONVERT_OVERFLOW 0
+#define FIX_DBL_LLONG_CONVERT_OVERFLOW 1
+
+#define FIX_LDBL_LONG_CONVERT_OVERFLOW 0
+#define FIX_LDBL_LLONG_CONVERT_OVERFLOW 0
+
+#define FIX_FLT128_LONG_CONVERT_OVERFLOW 0
+#define FIX_FLT128_LLONG_CONVERT_OVERFLOW 0
+
+#endif /* fix-fp-int-convert-overflow.h */