diff mbox series

[v2] riscv: Update nofpu libm test ulps

Message ID ZeixBas1PNcz2Fbo@localhost.localdomain
State Committed
Commit f44f3aed31a2d18dc1aa70fce8d466cf6e56b93c
Headers
Series [v2] riscv: Update nofpu libm test ulps |

Checks

Context Check Description
redhat-pt-bot/TryBot-apply_patch success Patch applied to master at the time it was sent
redhat-pt-bot/TryBot-32bit success Build for i686
linaro-tcwg-bot/tcwg_glibc_build--master-arm success Testing passed
linaro-tcwg-bot/tcwg_glibc_build--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_glibc_check--master-arm success Testing passed
linaro-tcwg-bot/tcwg_glibc_check--master-aarch64 success Testing passed

Commit Message

Darius Rad March 6, 2024, 6:08 p.m. UTC 
  Fix two test failures.
---
Changes since v1:
  - Rebase to master
  - Fix corrupted diff line in patch

 sysdeps/riscv/nofpu/libm-test-ulps | 1 +
 1 file changed, 1 insertion(+)

Comments

Florian Weimer March 11, 2024, 1:19 p.m. UTC | #1 
* Darius Rad:

> Fix two test failures.
> ---
> Changes since v1:
>   - Rebase to master
>   - Fix corrupted diff line in patch
>
>  sysdeps/riscv/nofpu/libm-test-ulps | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/sysdeps/riscv/nofpu/libm-test-ulps b/sysdeps/riscv/nofpu/libm-test-ulps
> index 16106f10b0..bc7e615177 100644
> --- a/sysdeps/riscv/nofpu/libm-test-ulps
> +++ b/sysdeps/riscv/nofpu/libm-test-ulps
> @@ -1043,6 +1043,7 @@ ldouble: 8
>  
>  Function: "hypot":
>  double: 1
> +float: 1
>  ldouble: 1
>  
>  Function: "hypot_downward":

Looks okay.

Reviewed-by: Florian Weimer <fweimer@redhat.com>

Do you have sourceware commit access?  If not, I can push the change for
you.

(ULP updates like this can also be pushed without review as obvious, I
think.)

Thanks,
Florian
Darius Rad March 11, 2024, 6:56 p.m. UTC | #2 
On Mon, Mar 11, 2024 at 02:19:03PM +0100, Florian Weimer wrote:
> * Darius Rad:
> 
> > Fix two test failures.
> > ---
> > Changes since v1:
> >   - Rebase to master
> >   - Fix corrupted diff line in patch
> >
> >  sysdeps/riscv/nofpu/libm-test-ulps | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/sysdeps/riscv/nofpu/libm-test-ulps b/sysdeps/riscv/nofpu/libm-test-ulps
> > index 16106f10b0..bc7e615177 100644
> > --- a/sysdeps/riscv/nofpu/libm-test-ulps
> > +++ b/sysdeps/riscv/nofpu/libm-test-ulps
> > @@ -1043,6 +1043,7 @@ ldouble: 8
> >  
> >  Function: "hypot":
> >  double: 1
> > +float: 1
> >  ldouble: 1
> >  
> >  Function: "hypot_downward":
> 
> Looks okay.
> 
> Reviewed-by: Florian Weimer <fweimer@redhat.com>
> 
> Do you have sourceware commit access?  If not, I can push the change for
> you.

I do not.  If you could commit it, I would appreciate it.

> 
> (ULP updates like this can also be pushed without review as obvious, I
> think.)
> 
> Thanks,
> Florian
>
Florian Weimer March 18, 2024, 10:29 a.m. UTC | #3 
* Darius Rad:

> On Mon, Mar 11, 2024 at 02:19:03PM +0100, Florian Weimer wrote:
>> * Darius Rad:
>> 
>> > Fix two test failures.
>> > ---
>> > Changes since v1:
>> >   - Rebase to master
>> >   - Fix corrupted diff line in patch
>> >
>> >  sysdeps/riscv/nofpu/libm-test-ulps | 1 +
>> >  1 file changed, 1 insertion(+)
>> >
>> > diff --git a/sysdeps/riscv/nofpu/libm-test-ulps b/sysdeps/riscv/nofpu/libm-test-ulps
>> > index 16106f10b0..bc7e615177 100644
>> > --- a/sysdeps/riscv/nofpu/libm-test-ulps
>> > +++ b/sysdeps/riscv/nofpu/libm-test-ulps
>> > @@ -1043,6 +1043,7 @@ ldouble: 8
>> >  
>> >  Function: "hypot":
>> >  double: 1
>> > +float: 1
>> >  ldouble: 1
>> >  
>> >  Function: "hypot_downward":
>> 
>> Looks okay.
>> 
>> Reviewed-by: Florian Weimer <fweimer@redhat.com>
>> 
>> Do you have sourceware commit access?  If not, I can push the change for
>> you.
>
> I do not.  If you could commit it, I would appreciate it.

I pushed it on your behalf.

Thanks,
Florian
diff mbox series

Patch

diff --git a/sysdeps/riscv/nofpu/libm-test-ulps b/sysdeps/riscv/nofpu/libm-test-ulps
index 16106f10b0..bc7e615177 100644
--- a/sysdeps/riscv/nofpu/libm-test-ulps
+++ b/sysdeps/riscv/nofpu/libm-test-ulps
@@ -1043,6 +1043,7 @@  ldouble: 8
 
 Function: "hypot":
 double: 1
+float: 1
 ldouble: 1
 
 Function: "hypot_downward":