diff mbox series

Fix up stdbit.texi

Message ID ZbtzXNHAPmyG9LYH@tucnak
State Committed
Commit c62b6265a641aaec4b0fa1b3fe622c2edf9c3821
Headers
Series Fix up stdbit.texi |

Checks

Context Check Description
redhat-pt-bot/TryBot-apply_patch success Patch applied to master at the time it was sent
linaro-tcwg-bot/tcwg_glibc_build--master-aarch64 success Testing passed
redhat-pt-bot/TryBot-32bit success Build for i686
linaro-tcwg-bot/tcwg_glibc_check--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_glibc_build--master-arm success Testing passed
linaro-tcwg-bot/tcwg_glibc_check--master-arm warning Patch is already merged

Commit Message

Jakub Jelinek Feb. 1, 2024, 10:33 a.m. UTC 
  On Thu, Feb 01, 2024 at 11:12:53AM +0100, Mark Wielaard wrote:
> > +a compiler with support for
> > +@uref{https://gcc.gnu.org/onlinedocs/gcc/Other-Builtins.html@code{__builtin_stdc_bit_ceil}},
> > +etc.@:, built-in functions such as GCC 14.1 or later
> > +any unsigned integer type those built-in functions support.
> > +In GCC 14.1 that includes support for @code{unsigned __int128} and
> > +@code{unsigned _BitInt(@var{n})} if supported by the target.
> >  
> >  @deftypefun {unsigned int} stdc_leading_zeros_uc (unsigned char @var{x})
> >  @deftypefunx {unsigned int} stdc_leading_zeros_us (unsigned short @var{x})
> 
> make pdf didn't like that new @uref construct:
> https://builder.sourceware.org/buildbot/#/builders/264/builds/282
> https://builder.sourceware.org/buildbot/api/v2/logs/7481911/raw

Ouch, sorry.

The following patch should fix that, at least make subdirs=manual pdf works
fine then and result looks expectedly.



	Jakub

Comments

Mark Wielaard Feb. 1, 2024, 11:05 a.m. UTC | #1 
Hi Jakub,

On Thu, Feb 01, 2024 at 11:33:00AM +0100, Jakub Jelinek wrote:
> The following patch should fix that, at least make subdirs=manual pdf works
> fine then and result looks expectedly.
> 
> diff --git a/manual/stdbit.texi b/manual/stdbit.texi
> index 8688930f12..6c75ed9a20 100644
> --- a/manual/stdbit.texi
> +++ b/manual/stdbit.texi
> @@ -34,7 +34,7 @@ the functions but without any suffix such as @samp{_uc}.  The
>  type-generic macro can only be used with an argument of an unsigned
>  integer type with a width of 8, 16, 32 or 64 bits, or when using
>  a compiler with support for
> -@uref{https://gcc.gnu.org/onlinedocs/gcc/Other-Builtins.html@code{__builtin_stdc_bit_ceil}},
> +@uref{https://gcc.gnu.org/onlinedocs/gcc/Other-Builtins.html,@code{__builtin_stdc_bit_ceil}},
>  etc.@:, built-in functions such as GCC 14.1 or later
>  any unsigned integer type those built-in functions support.
>  In GCC 14.1 that includes support for @code{unsigned __int128} and

Aha, missing comma. The @code was supposed to be the link target
text. Doh. tex errors can be so confusing. Looks good also for the
html.

Thanks,

Mark
Carlos O'Donell Feb. 1, 2024, 2:42 p.m. UTC | #2 
On 2/1/24 05:33, Jakub Jelinek wrote:
> diff --git a/manual/stdbit.texi b/manual/stdbit.texi
> index 8688930f12..6c75ed9a20 100644
> --- a/manual/stdbit.texi
> +++ b/manual/stdbit.texi
> @@ -34,7 +34,7 @@ the functions but without any suffix such as @samp{_uc}.  The
>  type-generic macro can only be used with an argument of an unsigned
>  integer type with a width of 8, 16, 32 or 64 bits, or when using
>  a compiler with support for
> -@uref{https://gcc.gnu.org/onlinedocs/gcc/Other-Builtins.html@code{__builtin_stdc_bit_ceil}},
> +@uref{https://gcc.gnu.org/onlinedocs/gcc/Other-Builtins.html,@code{__builtin_stdc_bit_ceil}},
>  etc.@:, built-in functions such as GCC 14.1 or later
>  any unsigned integer type those built-in functions support.
>  In GCC 14.1 that includes support for @code{unsigned __int128} and

This is an obvious typo fix.

Please post the final patch to the list as "[COMMITTED]" and push to master.
diff mbox series

Patch

diff --git a/manual/stdbit.texi b/manual/stdbit.texi
index 8688930f12..6c75ed9a20 100644
--- a/manual/stdbit.texi
+++ b/manual/stdbit.texi
@@ -34,7 +34,7 @@  the functions but without any suffix such as @samp{_uc}.  The
 type-generic macro can only be used with an argument of an unsigned
 integer type with a width of 8, 16, 32 or 64 bits, or when using
 a compiler with support for
-@uref{https://gcc.gnu.org/onlinedocs/gcc/Other-Builtins.html@code{__builtin_stdc_bit_ceil}},
+@uref{https://gcc.gnu.org/onlinedocs/gcc/Other-Builtins.html,@code{__builtin_stdc_bit_ceil}},
 etc.@:, built-in functions such as GCC 14.1 or later
 any unsigned integer type those built-in functions support.
 In GCC 14.1 that includes support for @code{unsigned __int128} and