diff mbox series

Build libsupport.a with exception and asynchronous unwind tables

Message ID ZJ8CqKro2a/SkAGb@mx3210.localdomain
State New
Headers
Series Build libsupport.a with exception and asynchronous unwind tables |

Checks

Context Check Description
redhat-pt-bot/TryBot-apply_patch fail Patch failed to apply to master at the time it was sent
redhat-pt-bot/TryBot-32bit success Build for i686
linaro-tcwg-bot/tcwg_glibc_check--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_glibc_build--master-aarch64 warning Patch failed to apply
linaro-tcwg-bot/tcwg_glibc_build--master-arm warning Patch failed to apply
linaro-tcwg-bot/tcwg_glibc_check--master-arm warning Patch failed to apply
redhat-pt-bot/TryBot-still_applies warning Patch no longer applies to master

Commit Message

John David Anglin June 30, 2023, 4:28 p.m. UTC 
  The attached change fixes the nptl/tst-cleanupx4 test on hppa.

Okay to install?

Dave
---

support: Build with exceptions and asynchronous unwind tables [BZ #30587]

Changing tst-cleanup4.c to use xread instead of read caused
the nptl/tst-cleanupx4 test to fail.  The routines in libsupport.a
need to be built with exception handling and asynchronous unwind
table support.

Comments

Florian Weimer June 30, 2023, 4:45 p.m. UTC | #1 
* John David Anglin:

> The attached change fixes the nptl/tst-cleanupx4 test on hppa.
>
> Okay to install?
>
> Dave
> ---
>
> support: Build with exceptions and asynchronous unwind tables [BZ #30587]
>
> Changing tst-cleanup4.c to use xread instead of read caused
> the nptl/tst-cleanupx4 test to fail.  The routines in libsupport.a
> need to be built with exception handling and asynchronous unwind
> table support.
>
> diff --git a/support/Makefile b/support/Makefile
> index c81e3c928c..038d104264 100644
> --- a/support/Makefile
> +++ b/support/Makefile
> @@ -239,6 +239,9 @@ CFLAGS-support_paths.c = \
>  		-DCOMPLOCALEDIR_PATH=\"$(complocaledir)\" \
>  		-DSYSCONFDIR_PATH=\"$(sysconfdir)\"
>  
> +# Build with exception handling and asynchronous unwind table support.
> +override CFLAGS += -fexceptions -fasynchronous-unwind-tables

Could you try if

CFLAGS-.oS += -fexceptions -fasynchronous-unwind-tables

works (without the override)?  That's the more usual way of doing
things.

Thanks,
Florian
diff mbox series

Patch

diff --git a/support/Makefile b/support/Makefile
index c81e3c928c..038d104264 100644
--- a/support/Makefile
+++ b/support/Makefile
@@ -239,6 +239,9 @@  CFLAGS-support_paths.c = \
 		-DCOMPLOCALEDIR_PATH=\"$(complocaledir)\" \
 		-DSYSCONFDIR_PATH=\"$(sysconfdir)\"
 
+# Build with exception handling and asynchronous unwind table support.
+override CFLAGS += -fexceptions -fasynchronous-unwind-tables
+
 # In support_timespec_check_in_range we may be passed a very tight
 # range for which we should produce a correct result for expected
 # being within the observed range.  The code uses double internally