diff mbox

x86: Rename get_common_indeces to get_common_indices

Message ID CAMe9rOqfXDarJNUPfzfNOevRNDM+5SMskfY+vWprC0gTCNa2sA@mail.gmail.com
State New, archived
Headers show

Commit Message

H.J. Lu July 26, 2018, 8:53 p.m. UTC
On Thu, Jul 26, 2018 at 1:37 PM, Carlos O'Donell <carlos@redhat.com> wrote:
> On 07/26/2018 04:32 PM, H.J. Lu wrote:
>> On Thu, Jul 26, 2018 at 1:05 PM, Carlos O'Donell <carlos@redhat.com> wrote:
>>> On 07/26/2018 02:07 PM, H.J. Lu wrote:
>>>>       [BZ #23459]
>>>>       * sysdeps/x86/cpu-features.c (get_extended_indeces): New
>>>>       function.
>>>>       (init_cpu_features): Call get_extended_indeces for both Intel
>>>>       and AMD CPUs.
>>>> ---
>>>
>>> OK for 2.28 after you fix the indexes v.s indices issue.
>>>
>>> Reviewed-by: Carlos O'Donell <carlos@redhat.com>
>>>
>>
>> This is the patch I am checking in.
>
> There are *many* incorrect spellings of indices too which you might
> fix later ;-)
>

Like this?

Comments

Carlos O'Donell July 27, 2018, 12:44 a.m. UTC | #1
On 07/26/2018 04:53 PM, H.J. Lu wrote:
> On Thu, Jul 26, 2018 at 1:37 PM, Carlos O'Donell <carlos@redhat.com> wrote:
>> On 07/26/2018 04:32 PM, H.J. Lu wrote:
>>> On Thu, Jul 26, 2018 at 1:05 PM, Carlos O'Donell <carlos@redhat.com> wrote:
>>>> On 07/26/2018 02:07 PM, H.J. Lu wrote:
>>>>>       [BZ #23459]
>>>>>       * sysdeps/x86/cpu-features.c (get_extended_indeces): New
>>>>>       function.
>>>>>       (init_cpu_features): Call get_extended_indeces for both Intel
>>>>>       and AMD CPUs.
>>>>> ---
>>>>
>>>> OK for 2.28 after you fix the indexes v.s indices issue.
>>>>
>>>> Reviewed-by: Carlos O'Donell <carlos@redhat.com>
>>>>
>>>
>>> This is the patch I am checking in.
>>
>> There are *many* incorrect spellings of indices too which you might
>> fix later ;-)
>>
> 
> Like this?

Exactly. LGTM. There are still 13 other incorrect spellings in comments,
but they don't really impact much. In this case it's annoying to have a
function spelled incorrectly.

Please wait until 2.29 opens before checking this in, I'd like to minimize
churn at this point.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>

Cheers,
Carlos.
diff mbox

Patch

From 3c1caa7a4e216fc651d39a2968d445a06bf0dc4e Mon Sep 17 00:00:00 2001
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Thu, 26 Jul 2018 13:51:49 -0700
Subject: [PATCH] x86: Rename get_common_indeces to get_common_indices

	* sysdeps/x86/cpu-features.c (get_common_indeces): Renamed to
	...
	(get_common_indices): This.
	(init_cpu_features): Updated.
---
 sysdeps/x86/cpu-features.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/sysdeps/x86/cpu-features.c b/sysdeps/x86/cpu-features.c
index ea0b64fdb9..51642f8b6a 100644
--- a/sysdeps/x86/cpu-features.c
+++ b/sysdeps/x86/cpu-features.c
@@ -57,7 +57,7 @@  get_extended_indices (struct cpu_features *cpu_features)
 }
 
 static void
-get_common_indeces (struct cpu_features *cpu_features,
+get_common_indices (struct cpu_features *cpu_features,
 		    unsigned int *family, unsigned int *model,
 		    unsigned int *extended_model, unsigned int *stepping)
 {
@@ -235,7 +235,7 @@  init_cpu_features (struct cpu_features *cpu_features)
 
       kind = arch_kind_intel;
 
-      get_common_indeces (cpu_features, &family, &model, &extended_model,
+      get_common_indices (cpu_features, &family, &model, &extended_model,
 			  &stepping);
 
       get_extended_indices (cpu_features);
@@ -351,7 +351,7 @@  init_cpu_features (struct cpu_features *cpu_features)
 
       kind = arch_kind_amd;
 
-      get_common_indeces (cpu_features, &family, &model, &extended_model,
+      get_common_indices (cpu_features, &family, &model, &extended_model,
 			  &stepping);
 
       get_extended_indices (cpu_features);
@@ -388,7 +388,7 @@  init_cpu_features (struct cpu_features *cpu_features)
   else
     {
       kind = arch_kind_other;
-      get_common_indeces (cpu_features, NULL, NULL, NULL, NULL);
+      get_common_indices (cpu_features, NULL, NULL, NULL, NULL);
     }
 
   /* Support i586 if CX8 is available.  */
-- 
2.17.1