Add LE DSCP code point from RFC-8622.

Message ID 934cab853b750a7614619fe5f4ea0c9ff9051e8c.1697209860.git.mirai@makinata.eu
State Committed
Commit 3333eb55b73ed585b8265f2d5dfcd8624173cf8e
Headers
Series Add LE DSCP code point from RFC-8622. |

Checks

Context Check Description
redhat-pt-bot/TryBot-apply_patch success Patch applied to master at the time it was sent
redhat-pt-bot/TryBot-32bit success Build for i686
linaro-tcwg-bot/tcwg_glibc_build--master-arm success Testing passed
linaro-tcwg-bot/tcwg_glibc_build--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_glibc_check--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_glibc_check--master-arm warning Patch is already merged

Commit Message

Bruno Victal Oct. 13, 2023, 3:11 p.m. UTC
  Signed-off-by: Bruno Victal <mirai@makinata.eu>
---
 sysdeps/generic/netinet/ip.h | 5 +++++
 1 file changed, 5 insertions(+)


base-commit: 69239bd7a216007692470aa9d5f3658024638742
  

Comments

Florian Weimer Oct. 17, 2023, 3:44 p.m. UTC | #1
* Bruno Victal:

> Signed-off-by: Bruno Victal <mirai@makinata.eu>
> ---
>  sysdeps/generic/netinet/ip.h | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/sysdeps/generic/netinet/ip.h b/sysdeps/generic/netinet/ip.h
> index 6bdb31b65e..20139e97af 100644
> --- a/sysdeps/generic/netinet/ip.h
> +++ b/sysdeps/generic/netinet/ip.h
> @@ -191,6 +191,11 @@ struct ip_timestamp
>   */
>  #define	IPTOS_DSCP_VA		0xb0
>  
> +/*
> + * Lower-Effort Per-Hop Behavior DSCP code point from RFC-8622, Section 12.
> + */
> +#define	IPTOS_DSCP_LE		0x04
> +
>  /*
>   * In RFC 2474, Section 4.2.2.1, the Class Selector Codepoints subsume
>   * the old ToS Precedence values.
>
> base-commit: 69239bd7a216007692470aa9d5f3658024638742

Looks okay.  The two lowest bits are taken by the ECN indicator, that's
why the value is 4 and not 1 as in the IANA registry.  I will do a test
build just to be sure and push your patch if it passes.

Reviewed-by: Florian Weimer <fweimer@redhat.com>

Thanks,
Florian
  

Patch

diff --git a/sysdeps/generic/netinet/ip.h b/sysdeps/generic/netinet/ip.h
index 6bdb31b65e..20139e97af 100644
--- a/sysdeps/generic/netinet/ip.h
+++ b/sysdeps/generic/netinet/ip.h
@@ -191,6 +191,11 @@  struct ip_timestamp
  */
 #define	IPTOS_DSCP_VA		0xb0
 
+/*
+ * Lower-Effort Per-Hop Behavior DSCP code point from RFC-8622, Section 12.
+ */
+#define	IPTOS_DSCP_LE		0x04
+
 /*
  * In RFC 2474, Section 4.2.2.1, the Class Selector Codepoints subsume
  * the old ToS Precedence values.