i386: Use generic memrchr in libc (bug 31316)
Checks
Context |
Check |
Description |
redhat-pt-bot/TryBot-apply_patch |
success
|
Patch applied to master at the time it was sent
|
redhat-pt-bot/TryBot-32bit |
success
|
Build for i686
|
linaro-tcwg-bot/tcwg_glibc_build--master-aarch64 |
success
|
Testing passed
|
linaro-tcwg-bot/tcwg_glibc_check--master-aarch64 |
success
|
Testing passed
|
linaro-tcwg-bot/tcwg_glibc_build--master-arm |
success
|
Testing passed
|
linaro-tcwg-bot/tcwg_glibc_check--master-arm |
success
|
Testing passed
|
Commit Message
Before this change, we incorrectly use the SSE2 variant is the
implementation, without checking that the system actually supports
SSE2.
Tested-by: Sam James <sam@gentoo.org>
---
sysdeps/i386/i686/multiarch/memrchr-c.c | 1 +
sysdeps/i386/i686/multiarch/memrchr-sse2.S | 1 -
2 files changed, 1 insertion(+), 1 deletion(-)
base-commit: 491e55beab7457ed310a4a47496f4a333c5d1032
Comments
On Feb 15 2024, Florian Weimer wrote:
> Before this change, we incorrectly use the SSE2 variant is the
s/ is / in /
> implementation, without checking that the system actually supports
> SSE2.
* Andreas Schwab:
> On Feb 15 2024, Florian Weimer wrote:
>
>> Before this change, we incorrectly use the SSE2 variant is the
>
> s/ is / in /
>
>> implementation, without checking that the system actually supports
>> SSE2.
Thanks, fixed locally. Okay to push with that change?
Florian
On Thu, Feb 15, 2024 at 7:18 AM Florian Weimer <fweimer@redhat.com> wrote:
>
> * Andreas Schwab:
>
> > On Feb 15 2024, Florian Weimer wrote:
> >
> >> Before this change, we incorrectly use the SSE2 variant is the
> >
> > s/ is / in /
> >
> >> implementation, without checking that the system actually supports
> >> SSE2.
>
> Thanks, fixed locally. Okay to push with that change?
>
> Florian
>
Yes.
Thanks.
@@ -5,3 +5,4 @@ extern void *__memrchr_ia32 (const void *, int, size_t);
#endif
#include "string/memrchr.c"
+strong_alias (__memrchr_ia32, __GI___memrchr)
@@ -720,5 +720,4 @@ L(ret_null):
ret
END (__memrchr_sse2)
-strong_alias (__memrchr_sse2, __GI___memrchr)
#endif