[AARCH64] End frame record chain correctly
Commit Message
On 05/11/14 10:53, Marcus Shawcroft wrote:
> On 31 October 2014 14:30, Renlin Li<renlin.li@arm.com> wrote:
>> Hi all,
>>
>> This is a simple patch to make the end of frame record chain correctly
>> according to AArch64 AAPCS.
>> Currently, the FP(x29) is overwritten by SP in the very beginning of _start.
>>
>> aarch64-none-linux-gnueabi target has been tested on the model. No new
>> issues.
> Surely aarch64-none-linux-gnu ;-)
>
> The bugzilla # for this is 17555:
>> ChangeLog:
>>
>> 2014-10-31 Renlin Li<Renlin.Li@arm.com>
>>
>> * sysdeps/aarch64/start.S: Delete x29 overwritten assignment.
> Don't forget the () part of the ChangeLog entry. Add a reference to
> the bugzilla ticket:
>
> [BZ #17555]
> * sysdeps/aarch64/start.S (_start): Delete x29 overwritten assignment.
>
> Please also add 17555 to the 2.21 section of the NEWS file.
>
> Can you back port this to 2.20 and 2.19 please.
>
> Thanks
> /Marcus
>
Hi Marcus,
Thank you for the suggestions! I have modified my patch and ChangeLog
accordingly.
The back port patches will come shortly.
aarch64-none-linux-gnu target has been tested on the model. No new issues.
Okay to commit?
ChangeLog:
2014-11-10 Renlin Li <Renlin.Li@arm.com>
[BZ #17555]
* sysdeps/aarch64/start.S (_start): Delete x29 overwritten assignment.
Comments
On 10 November 2014 10:54, Renlin Li <renlin.li@arm.com> wrote:
> Thank you for the suggestions! I have modified my patch and ChangeLog
> accordingly.
>
> The back port patches will come shortly.
>
>
> aarch64-none-linux-gnu target has been tested on the model. No new issues.
> Okay to commit?
Thanks, committed with NEWS update.
/Marcus
@@ -9,7 +9,7 @@ Version 2.21
* The following bugs are resolved with this release:
- 6652, 14171, 17266, 17363, 17370, 17371, 17411.
+ 6652, 14171, 17266, 17363, 17370, 17371, 17411, 17555.
Version 2.20
@@ -47,7 +47,6 @@ _start:
/* Create an initial frame with 0 LR and FP */
mov x29, #0
mov x30, #0
- mov x29, sp
/* Setup rtld_fini in argument register */
mov x5, x0