Message ID | 20240229194642.3398122-2-adhemerval.zanella@linaro.org |
---|---|
State | Superseded |
Delegated to: | Arjun Shankar |
Headers |
Return-Path: <libc-alpha-bounces+patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 40ED03858C74 for <patchwork@sourceware.org>; Thu, 29 Feb 2024 19:48:18 +0000 (GMT) X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by sourceware.org (Postfix) with ESMTPS id 3E76F385829A for <libc-alpha@sourceware.org>; Thu, 29 Feb 2024 19:46:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3E76F385829A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3E76F385829A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::102f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709236013; cv=none; b=NqZf7GseaUXz6SvcUtuB6rWS7yKDxPHdyqTXJmETrcyYNQ7msQl3TyvKki2reoL5pPZ+XbJtOlW4G646OuDwtdQbKGOpT1KiJx/q8j3zKFSenQ1PHmYWsSAtHI+m53D2G+PUN+/KiJNM3iEzyCvbOElU4n1fc57WJ/Egi8eJCCs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709236013; c=relaxed/simple; bh=9wQSkZIhXvyacN+wia2LRkuuffeqRF2czoReUDUGroo=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=VxTB0F3tU8M9TcEnJu/CKnncns/eRrWLuVjLC40QlRsjtWVKE281HaGVzpIzI1P5tg5NZs/cG8cAuAg0BickR6keQoNKYFhpx2IN/A4ZtAGwW62imygoqRMwj4LUERkcHizGd+BGkDUgu9Xa9rbvP6VdeUvFT+7Wx2c3WlTdgfg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pj1-x102f.google.com with SMTP id 98e67ed59e1d1-29954bb87b4so963622a91.2 for <libc-alpha@sourceware.org>; Thu, 29 Feb 2024 11:46:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709236009; x=1709840809; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MJR92ySGcLAUEr/RiArHg/xnmWQ1MLj8la+pJNWsNHQ=; b=BIGDrB63xR7h2LloHRnbbQTV7NT8yZx6/YWgzvXk410lDKFYWs1PhBR9whA9YDMjq5 5Zt/XkpuoeLUqjwOD1MA8fYBrx0M9+uElIPQw1jxY9dTEEsXeAx7+P2XcJxWpFP/MpD+ m8kBT86tdSKmLa93A5RPh+MsXZQ3XiPwnKIOglr3LJ0O3oELU0OvVB3+AlQwSJpEYXSE Lx3TIMd7HFnI4ai4LmgeVr9BwI23sa5GVw7Up+EikCELshIMconD9/qr9nLpFFVz0FmW zyYIqfrrVuRFJhu7u9XxjiL63JmIbWCheI7Cau4MG4OQrbCb2asvdSi8UpvSvGmj1a4m aqXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709236009; x=1709840809; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MJR92ySGcLAUEr/RiArHg/xnmWQ1MLj8la+pJNWsNHQ=; b=okYCJ0VtbQ9zTQNQ2Py8qwzgnDmmkZ7Ha702T8+n+56DGuEpwvoU3Y6wvvJ420AieE Foag9RWMAHcuFtfC8nOYpey1h5I2HIKUXrYvL17NMTBZopq8Afb2csy1M8iaL3zBmxvs 4zpYpWcJNXx9ogyqqHjfaimfRGR3pLjJ0+zoe4nptN8zk5eyaFIG1mv4jDjaKhYCurxm tTjTsQVSXVUZp9BXCL+8sx2q34K3/ZPi8nj+vsigwqWjLBdYjTP29NdbkOoL4dhAlfQf PiBuYkD06wfPVYOh2DXsrTHsBkB3vVZeaLea9xl+JvHJtZ/XyM3/5P04x1CXgJPtIq2W Vl2A== X-Gm-Message-State: AOJu0YwBwEqMq18hUc0MUlWlAYG43AamKWdVHeBCHk8dkWJzs2PzwfFC ukn0uAzRDQsFSHYbjPVWNl+MJk15FoMoP1/NWwhkrr3Eyfhl+ebB8Rwe5uCNMD0uUDqrHoyNd/V F X-Google-Smtp-Source: AGHT+IFoaDlt5w0LqX8Ijxsm1ahLOmb4ZiTQum+ogxq57HdAI97CLB74ORwhILWPgw+Z5bBsQyrgpQ== X-Received: by 2002:a17:90b:3bd0:b0:29a:a37f:22c6 with SMTP id ph16-20020a17090b3bd000b0029aa37f22c6mr40543pjb.28.1709236009480; Thu, 29 Feb 2024 11:46:49 -0800 (PST) Received: from mandiga.. ([2804:1b3:a7c1:3a1a:a62d:15eb:5bb4:832d]) by smtp.gmail.com with ESMTPSA id cz13-20020a17090ad44d00b0029ad44cc063sm3957206pjb.35.2024.02.29.11.46.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 11:46:48 -0800 (PST) From: Adhemerval Zanella <adhemerval.zanella@linaro.org> To: libc-alpha@sourceware.org Cc: Szabolcs Nagy <szabolcs.nagy@arm.com>, "H . J . Lu" <hjl.tools@gmail.com> Subject: [PATCH 1/3] Ignore undefined symbols for -mtls-dialect=gnu2 Date: Thu, 29 Feb 2024 16:46:40 -0300 Message-Id: <20240229194642.3398122-2-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240229194642.3398122-1-adhemerval.zanella@linaro.org> References: <20240229194642.3398122-1-adhemerval.zanella@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=subscribe> Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org |
Series |
Extending TLS testing and fixing TLS gnu2 for ARM
|
|
Commit Message
Adhemerval Zanella Netto
Feb. 29, 2024, 7:46 p.m. UTC
So it is not fail for arm config that defaults to -mtp=soft (which issues a call to __aeabi_read_tp). --- configure | 2 +- configure.ac | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
Comments
On Thu, Feb 29, 2024 at 11:46 AM Adhemerval Zanella <adhemerval.zanella@linaro.org> wrote: > > So it is not fail for arm config that defaults to -mtp=soft (which > issues a call to __aeabi_read_tp). > --- > configure | 2 +- > configure.ac | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/configure b/configure > index 59ff1e415d..ab8a10ed92 100755 > --- a/configure > +++ b/configure > @@ -7020,7 +7020,7 @@ void foo (void) > } > EOF > if { ac_try='${CC-cc} $CFLAGS $CPPFLAGS -fPIC -mtls-dialect=gnu2 -nostdlib -nostartfiles > - conftest.c -o conftest 1>&5' > + -Wl,--unresolved-symbols=ignore-all conftest.c -o conftest 1>&5' > { { eval echo "\"\$as_me\":${as_lineno-$LINENO}: \"$ac_try\""; } >&5 > (eval $ac_try) 2>&5 > ac_status=$? > diff --git a/configure.ac b/configure.ac > index 65799e5685..4bb9aeef95 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -1297,7 +1297,7 @@ void foo (void) > } > EOF > if AC_TRY_COMMAND([${CC-cc} $CFLAGS $CPPFLAGS -fPIC -mtls-dialect=gnu2 -nostdlib -nostartfiles > - conftest.c -o conftest 1>&AS_MESSAGE_LOG_FD]) > + -Wl,--unresolved-symbols=ignore-all conftest.c -o conftest 1>&AS_MESSAGE_LOG_FD]) > then Can we use -shared instead? > libc_cv_mtls_dialect_gnu2=yes > else > -- > 2.34.1 >
On 05/03/24 17:07, H.J. Lu wrote: > On Thu, Feb 29, 2024 at 11:46 AM Adhemerval Zanella > <adhemerval.zanella@linaro.org> wrote: >> >> So it is not fail for arm config that defaults to -mtp=soft (which >> issues a call to __aeabi_read_tp). >> --- >> configure | 2 +- >> configure.ac | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/configure b/configure >> index 59ff1e415d..ab8a10ed92 100755 >> --- a/configure >> +++ b/configure >> @@ -7020,7 +7020,7 @@ void foo (void) >> } >> EOF >> if { ac_try='${CC-cc} $CFLAGS $CPPFLAGS -fPIC -mtls-dialect=gnu2 -nostdlib -nostartfiles >> - conftest.c -o conftest 1>&5' >> + -Wl,--unresolved-symbols=ignore-all conftest.c -o conftest 1>&5' >> { { eval echo "\"\$as_me\":${as_lineno-$LINENO}: \"$ac_try\""; } >&5 >> (eval $ac_try) 2>&5 >> ac_status=$? >> diff --git a/configure.ac b/configure.ac >> index 65799e5685..4bb9aeef95 100644 >> --- a/configure.ac >> +++ b/configure.ac >> @@ -1297,7 +1297,7 @@ void foo (void) >> } >> EOF >> if AC_TRY_COMMAND([${CC-cc} $CFLAGS $CPPFLAGS -fPIC -mtls-dialect=gnu2 -nostdlib -nostartfiles >> - conftest.c -o conftest 1>&AS_MESSAGE_LOG_FD]) >> + -Wl,--unresolved-symbols=ignore-all conftest.c -o conftest 1>&AS_MESSAGE_LOG_FD]) >> then > > Can we use -shared instead? It works as well, I don't have a strong preference. > >> libc_cv_mtls_dialect_gnu2=yes >> else >> -- >> 2.34.1 >> > >
On Tue, Mar 5, 2024 at 12:17 PM Adhemerval Zanella Netto <adhemerval.zanella@linaro.org> wrote: > > > > On 05/03/24 17:07, H.J. Lu wrote: > > On Thu, Feb 29, 2024 at 11:46 AM Adhemerval Zanella > > <adhemerval.zanella@linaro.org> wrote: > >> > >> So it is not fail for arm config that defaults to -mtp=soft (which > >> issues a call to __aeabi_read_tp). > >> --- > >> configure | 2 +- > >> configure.ac | 2 +- > >> 2 files changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/configure b/configure > >> index 59ff1e415d..ab8a10ed92 100755 > >> --- a/configure > >> +++ b/configure > >> @@ -7020,7 +7020,7 @@ void foo (void) > >> } > >> EOF > >> if { ac_try='${CC-cc} $CFLAGS $CPPFLAGS -fPIC -mtls-dialect=gnu2 -nostdlib -nostartfiles > >> - conftest.c -o conftest 1>&5' > >> + -Wl,--unresolved-symbols=ignore-all conftest.c -o conftest 1>&5' > >> { { eval echo "\"\$as_me\":${as_lineno-$LINENO}: \"$ac_try\""; } >&5 > >> (eval $ac_try) 2>&5 > >> ac_status=$? > >> diff --git a/configure.ac b/configure.ac > >> index 65799e5685..4bb9aeef95 100644 > >> --- a/configure.ac > >> +++ b/configure.ac > >> @@ -1297,7 +1297,7 @@ void foo (void) > >> } > >> EOF > >> if AC_TRY_COMMAND([${CC-cc} $CFLAGS $CPPFLAGS -fPIC -mtls-dialect=gnu2 -nostdlib -nostartfiles > >> - conftest.c -o conftest 1>&AS_MESSAGE_LOG_FD]) > >> + -Wl,--unresolved-symbols=ignore-all conftest.c -o conftest 1>&AS_MESSAGE_LOG_FD]) > >> then > > > > Can we use -shared instead? > > It works as well, I don't have a strong preference. > Let's use -shared. OK with that change. Thanks.
diff --git a/configure b/configure index 59ff1e415d..ab8a10ed92 100755 --- a/configure +++ b/configure @@ -7020,7 +7020,7 @@ void foo (void) } EOF if { ac_try='${CC-cc} $CFLAGS $CPPFLAGS -fPIC -mtls-dialect=gnu2 -nostdlib -nostartfiles - conftest.c -o conftest 1>&5' + -Wl,--unresolved-symbols=ignore-all conftest.c -o conftest 1>&5' { { eval echo "\"\$as_me\":${as_lineno-$LINENO}: \"$ac_try\""; } >&5 (eval $ac_try) 2>&5 ac_status=$? diff --git a/configure.ac b/configure.ac index 65799e5685..4bb9aeef95 100644 --- a/configure.ac +++ b/configure.ac @@ -1297,7 +1297,7 @@ void foo (void) } EOF if AC_TRY_COMMAND([${CC-cc} $CFLAGS $CPPFLAGS -fPIC -mtls-dialect=gnu2 -nostdlib -nostartfiles - conftest.c -o conftest 1>&AS_MESSAGE_LOG_FD]) + -Wl,--unresolved-symbols=ignore-all conftest.c -o conftest 1>&AS_MESSAGE_LOG_FD]) then libc_cv_mtls_dialect_gnu2=yes else