x86: Don't check XFD against /proc/cpuinfo

Message ID 20240227194339.2023058-1-hjl.tools@gmail.com
State Committed
Commit 8c7c188d62d76acda1b273b0d4d9c3b32983b28d
Headers
Series x86: Don't check XFD against /proc/cpuinfo |

Checks

Context Check Description
redhat-pt-bot/TryBot-apply_patch success Patch applied to master at the time it was sent
linaro-tcwg-bot/tcwg_glibc_build--master-arm success Testing passed
redhat-pt-bot/TryBot-32bit success Build for i686
linaro-tcwg-bot/tcwg_glibc_build--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_glibc_check--master-arm success Testing passed
linaro-tcwg-bot/tcwg_glibc_check--master-aarch64 success Testing passed

Commit Message

H.J. Lu Feb. 27, 2024, 7:43 p.m. UTC
  Since /proc/cpuinfo doesn't report XFD, don't check it against
/proc/cpuinfo.
---
 sysdeps/x86/tst-cpu-features-cpuinfo.c | 3 +++
 1 file changed, 3 insertions(+)
  

Comments

Sunil Pandey Feb. 28, 2024, 6:26 p.m. UTC | #1
On Tue, Feb 27, 2024 at 11:44 AM H.J. Lu <hjl.tools@gmail.com> wrote:

> Since /proc/cpuinfo doesn't report XFD, don't check it against
> /proc/cpuinfo.
> ---
>  sysdeps/x86/tst-cpu-features-cpuinfo.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/sysdeps/x86/tst-cpu-features-cpuinfo.c
> b/sysdeps/x86/tst-cpu-features-cpuinfo.c
> index c11c6951c3..0251fb5460 100644
> --- a/sysdeps/x86/tst-cpu-features-cpuinfo.c
> +++ b/sysdeps/x86/tst-cpu-features-cpuinfo.c
> @@ -294,7 +294,10 @@ do_test (int argc, char **argv)
>    fails += CHECK_PROC (waitpkg, WAITPKG);
>    fails += CHECK_PROC (wbnoinvd, WBNOINVD);
>    fails += CHECK_PROC (x2apic, X2APIC);
> +#if 0
> +  /* NB: /proc/cpuinfo doesn't report this feature.  */
>    fails += CHECK_PROC (xfd, XFD);
> +#endif
>    fails += CHECK_PROC (xgetbv1, XGETBV_ECX_1);
>    fails += CHECK_PROC (xop, XOP);
>    fails += CHECK_PROC (xsave, XSAVE);
> --
> 2.43.2
>

LGTM
  

Patch

diff --git a/sysdeps/x86/tst-cpu-features-cpuinfo.c b/sysdeps/x86/tst-cpu-features-cpuinfo.c
index c11c6951c3..0251fb5460 100644
--- a/sysdeps/x86/tst-cpu-features-cpuinfo.c
+++ b/sysdeps/x86/tst-cpu-features-cpuinfo.c
@@ -294,7 +294,10 @@  do_test (int argc, char **argv)
   fails += CHECK_PROC (waitpkg, WAITPKG);
   fails += CHECK_PROC (wbnoinvd, WBNOINVD);
   fails += CHECK_PROC (x2apic, X2APIC);
+#if 0
+  /* NB: /proc/cpuinfo doesn't report this feature.  */
   fails += CHECK_PROC (xfd, XFD);
+#endif
   fails += CHECK_PROC (xgetbv1, XGETBV_ECX_1);
   fails += CHECK_PROC (xop, XOP);
   fails += CHECK_PROC (xsave, XSAVE);