trivial doc fix: remove weird phrase "syscall takes zero to five arguments"
Checks
Context |
Check |
Description |
redhat-pt-bot/TryBot-apply_patch |
success
|
Patch applied to master at the time it was sent
|
linaro-tcwg-bot/tcwg_glibc_build--master-aarch64 |
warning
|
Patch is already merged
|
redhat-pt-bot/TryBot-32bit |
success
|
Build for i686
|
linaro-tcwg-bot/tcwg_glibc_build--master-arm |
warning
|
Patch is already merged
|
Commit Message
"number of arguments, from zero to five" is wrong, because on Linux maximal number
of arguments is 6, not 5. Also, maximal number of arguments is kernel-dependent,
so let's not include it here at all.
Moreover, "Each kind of system call has a definite number of arguments" is questionable.
Think about SYS_open on Linux, which takes 2 or 3 arguments. Or SYS_clone on Linux x86_64, which
takes 2 to 5 arguments. So I propose to fully remove this sentence.
Signed-off-by: Askar Safin <safinaskar@zohomail.com>
---
Again: yes, I give up pushing my "syscall_no_errno".
But while I was writing "syscall_no_errno" patch I noticed this manual error,
so I submit it.
manual/startup.texi | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Comments
On 12/02/24 13:48, Askar Safin wrote:
> "number of arguments, from zero to five" is wrong, because on Linux maximal number
> of arguments is 6, not 5. Also, maximal number of arguments is kernel-dependent,
> so let's not include it here at all.
mips o32 supports 7 arguments, but I think this is the only supported
kABI that allows it (csky also have INTERNAL_SYSCALL_RAW7, but I am
not sure it really uses this macro for any syscall).
>
> Moreover, "Each kind of system call has a definite number of arguments" is questionable.
> Think about SYS_open on Linux, which takes 2 or 3 arguments. Or SYS_clone on Linux x86_64, which
> takes 2 to 5 arguments. So I propose to fully remove this sentence.
>
> Signed-off-by: Askar Safin <safinaskar@zohomail.com>
LGTM, thanks.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> ---
>
> Again: yes, I give up pushing my "syscall_no_errno".
> But while I was writing "syscall_no_errno" patch I noticed this manual error,
> so I submit it.
>
> manual/startup.texi | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/manual/startup.texi b/manual/startup.texi
> index 9bf24123f5..96a7a472bb 100644
> --- a/manual/startup.texi
> +++ b/manual/startup.texi
> @@ -727,8 +727,7 @@ identified by a number. Macros for all the possible system call numbers
> are defined in @file{sys/syscall.h}
>
> The remaining arguments are the arguments for the system call, in
> -order, and their meanings depend on the kind of system call. Each kind
> -of system call has a definite number of arguments, from zero to five.
> +order, and their meanings depend on the kind of system call.
> If you code more arguments than the system call takes, the extra ones to
> the right are ignored.
>
@@ -727,8 +727,7 @@ identified by a number. Macros for all the possible system call numbers
are defined in @file{sys/syscall.h}
The remaining arguments are the arguments for the system call, in
-order, and their meanings depend on the kind of system call. Each kind
-of system call has a definite number of arguments, from zero to five.
+order, and their meanings depend on the kind of system call.
If you code more arguments than the system call takes, the extra ones to
the right are ignored.