[v2] sparc: Fix llrint and llround missing exceptions on SPARC V8
Checks
| Context |
Check |
Description |
| redhat-pt-bot/TryBot-apply_patch |
success
|
Patch applied to master at the time it was sent
|
| redhat-pt-bot/TryBot-32bit |
success
|
Build for i686
|
| linaro-tcwg-bot/tcwg_glibc_build--master-aarch64 |
success
|
Testing passed
|
| linaro-tcwg-bot/tcwg_glibc_check--master-aarch64 |
success
|
Testing passed
|
| linaro-tcwg-bot/tcwg_glibc_build--master-arm |
success
|
Testing passed
|
| linaro-tcwg-bot/tcwg_glibc_check--master-arm |
success
|
Testing passed
|
Commit Message
Conversions from a float to a long long on SPARC v8 uses a libgcc function
that may not raise the correct exceptions on overflow. It also may raise
spurious "inexact" exceptions on non overflow cases. This patch fixes the
problem in the same way as for RV32.
Signed-off-by: Daniel Cederman <cederman@gaisler.com>
---
.../sparc32/fpu/fix-fp-int-convert-overflow.h | 43 +++++++++++++++++++
1 file changed, 43 insertions(+)
create mode 100644 sysdeps/sparc/sparc32/fpu/fix-fp-int-convert-overflow.h
Comments
On 16/01/24 05:31, Daniel Cederman wrote:
> Conversions from a float to a long long on SPARC v8 uses a libgcc function
> that may not raise the correct exceptions on overflow. It also may raise
> spurious "inexact" exceptions on non overflow cases. This patch fixes the
> problem in the same way as for RV32.
>
> Signed-off-by: Daniel Cederman <cederman@gaisler.com>
LGTM, thanks.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> ---
> .../sparc32/fpu/fix-fp-int-convert-overflow.h | 43 +++++++++++++++++++
> 1 file changed, 43 insertions(+)
> create mode 100644 sysdeps/sparc/sparc32/fpu/fix-fp-int-convert-overflow.h
>
> diff --git a/sysdeps/sparc/sparc32/fpu/fix-fp-int-convert-overflow.h b/sysdeps/sparc/sparc32/fpu/fix-fp-int-convert-overflow.h
> new file mode 100644
> index 0000000000..4ed2f16a5f
> --- /dev/null
> +++ b/sysdeps/sparc/sparc32/fpu/fix-fp-int-convert-overflow.h
> @@ -0,0 +1,43 @@
> +/* Fix for conversion of floating point to integer overflow. SPARC32 version.
> + Copyright (C) 2015-2020 Free Software Foundation, Inc.
> + This file is part of the GNU C Library.
> +
> + The GNU C Library is free software; you can redistribute it and/or
> + modify it under the terms of the GNU Lesser General Public
> + License as published by the Free Software Foundation; either
> + version 2.1 of the License, or (at your option) any later version.
> +
> + The GNU C Library is distributed in the hope that it will be useful,
> + but WITHOUT ANY WARRANTY; without even the implied warranty of
> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> + Lesser General Public License for more details.
> +
> + You should have received a copy of the GNU Lesser General Public
> + License along with the GNU C Library; if not, see
> + <https://www.gnu.org/licenses/>. */
> +
> +#ifndef FIX_FP_INT_CONVERT_OVERFLOW_H
> +#define FIX_FP_INT_CONVERT_OVERFLOW_H 1
> +
> +/* Define these macros to 1 to workaround conversions of out-of-range
> + floating-point numbers to integer types failing to raise the
> + "invalid" exception, or raising spurious "inexact" or other
> + exceptions. */
> +
> +#define FIX_FLT_LONG_CONVERT_OVERFLOW 0
> +#define FIX_DBL_LONG_CONVERT_OVERFLOW 0
> +#define FIX_LDBL_LONG_CONVERT_OVERFLOW 0
> +#define FIX_LDBL_LLONG_CONVERT_OVERFLOW 0
> +#define FIX_FLT128_LONG_CONVERT_OVERFLOW 0
> +#define FIX_FLT128_LLONG_CONVERT_OVERFLOW 0
> +/* For sparcv9 compiler generates fdtox/fstox for floating point to
> + integer generation. */
> +#ifdef __sparcv9
> +# define FIX_FLT_LLONG_CONVERT_OVERFLOW 0
> +# define FIX_DBL_LLONG_CONVERT_OVERFLOW 0
> +#else
> +# define FIX_FLT_LLONG_CONVERT_OVERFLOW 1
> +# define FIX_DBL_LLONG_CONVERT_OVERFLOW 1
> +#endif
> +
> +#endif /* fix-fp-int-convert-overflow.h */
new file mode 100644
@@ -0,0 +1,43 @@
+/* Fix for conversion of floating point to integer overflow. SPARC32 version.
+ Copyright (C) 2015-2020 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <https://www.gnu.org/licenses/>. */
+
+#ifndef FIX_FP_INT_CONVERT_OVERFLOW_H
+#define FIX_FP_INT_CONVERT_OVERFLOW_H 1
+
+/* Define these macros to 1 to workaround conversions of out-of-range
+ floating-point numbers to integer types failing to raise the
+ "invalid" exception, or raising spurious "inexact" or other
+ exceptions. */
+
+#define FIX_FLT_LONG_CONVERT_OVERFLOW 0
+#define FIX_DBL_LONG_CONVERT_OVERFLOW 0
+#define FIX_LDBL_LONG_CONVERT_OVERFLOW 0
+#define FIX_LDBL_LLONG_CONVERT_OVERFLOW 0
+#define FIX_FLT128_LONG_CONVERT_OVERFLOW 0
+#define FIX_FLT128_LLONG_CONVERT_OVERFLOW 0
+/* For sparcv9 compiler generates fdtox/fstox for floating point to
+ integer generation. */
+#ifdef __sparcv9
+# define FIX_FLT_LLONG_CONVERT_OVERFLOW 0
+# define FIX_DBL_LLONG_CONVERT_OVERFLOW 0
+#else
+# define FIX_FLT_LLONG_CONVERT_OVERFLOW 1
+# define FIX_DBL_LLONG_CONVERT_OVERFLOW 1
+#endif
+
+#endif /* fix-fp-int-convert-overflow.h */