[02/23] hurd: Declare _hurd_intr_rpc_msg* with protected visibility

Message ID 20240103171502.1358371-3-bugaevc@gmail.com
State Committed
Commit b6931d6d14c71fd229cc2ff94c810bd3390687db
Headers
Series aarch64-gnu port |

Checks

Context Check Description
redhat-pt-bot/TryBot-apply_patch success Patch applied to master at the time it was sent

Commit Message

Sergey Bugaev Jan. 3, 2024, 5:14 p.m. UTC
  These symbols are internal and never exported; make sure the compiler
realizes that when compiling hurdsig.c and does not try to emit GOT
reads.

Signed-off-by: Sergey Bugaev <bugaevc@gmail.com>
---
 hurd/hurdsig.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
  

Comments

Samuel Thibault Jan. 3, 2024, 9 p.m. UTC | #1
Applied, thanks!

Sergey Bugaev, le mer. 03 janv. 2024 20:14:35 +0300, a ecrit:
> These symbols are internal and never exported; make sure the compiler
> realizes that when compiling hurdsig.c and does not try to emit GOT
> reads.
> 
> Signed-off-by: Sergey Bugaev <bugaevc@gmail.com>
> ---
>  hurd/hurdsig.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/hurd/hurdsig.c b/hurd/hurdsig.c
> index fe788193..882a0347 100644
> --- a/hurd/hurdsig.c
> +++ b/hurd/hurdsig.c
> @@ -416,9 +416,9 @@ _hurdsig_abort_rpcs (struct hurd_sigstate *ss, int signo, int sigthread,
>  		     struct machine_thread_all_state *state, int *state_change,
>  		     void (*reply) (void))
>  {
> -  extern const void _hurd_intr_rpc_msg_about_to;
> -  extern const void _hurd_intr_rpc_msg_setup_done;
> -  extern const void _hurd_intr_rpc_msg_in_trap;
> +  extern const void _hurd_intr_rpc_msg_about_to attribute_hidden;
> +  extern const void _hurd_intr_rpc_msg_setup_done attribute_hidden;
> +  extern const void _hurd_intr_rpc_msg_in_trap attribute_hidden;
>    mach_port_t rcv_port = MACH_PORT_NULL;
>    mach_port_t intr_port;
>  
> -- 
> 2.43.0
> 
>
  

Patch

diff --git a/hurd/hurdsig.c b/hurd/hurdsig.c
index fe788193..882a0347 100644
--- a/hurd/hurdsig.c
+++ b/hurd/hurdsig.c
@@ -416,9 +416,9 @@  _hurdsig_abort_rpcs (struct hurd_sigstate *ss, int signo, int sigthread,
 		     struct machine_thread_all_state *state, int *state_change,
 		     void (*reply) (void))
 {
-  extern const void _hurd_intr_rpc_msg_about_to;
-  extern const void _hurd_intr_rpc_msg_setup_done;
-  extern const void _hurd_intr_rpc_msg_in_trap;
+  extern const void _hurd_intr_rpc_msg_about_to attribute_hidden;
+  extern const void _hurd_intr_rpc_msg_setup_done attribute_hidden;
+  extern const void _hurd_intr_rpc_msg_in_trap attribute_hidden;
   mach_port_t rcv_port = MACH_PORT_NULL;
   mach_port_t intr_port;