diff mbox series

[htdocs] menu: fix spacing when wrapping links

Message ID 20231220030601.31461-1-vapier@gentoo.org
State Committed
Headers
Series [htdocs] menu: fix spacing when wrapping links |

Checks

Context Check Description
redhat-pt-bot/TryBot-apply_patch fail Patch failed to apply to master at the time it was sent
redhat-pt-bot/TryBot-32bit fail Patch series failed to apply

Commit Message

Mike Frysinger Dec. 20, 2023, 3:06 a.m. UTC 
  On narrow pages, as the links wrap around, they start to overlap
each other makes it visually hard to distinguish & click.  Set the
line-height to 2em which offsets the padding used so that they do
not overlap when wrapping, but the original amount of padding above
and below do not change.
---
 glibc.css | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Carlos O'Donell Feb. 16, 2024, 7:26 p.m. UTC | #1 
On 12/19/23 22:06, Mike Frysinger wrote:
> On narrow pages, as the links wrap around, they start to overlap
> each other makes it visually hard to distinguish & click.  Set the
> line-height to 2em which offsets the padding used so that they do
> not overlap when wrapping, but the original amount of padding above
> and below do not change.
> ---

LGTM. Applied.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>

>  glibc.css | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/glibc.css b/glibc.css
> index 817276a09851..be710b38586b 100644
> --- a/glibc.css
> +++ b/glibc.css
> @@ -35,16 +35,16 @@ h1.title {
>  	border-right:1px solid #000;
>  	border-left:1px solid #000;
>  	border-bottom:0px solid #000;
> -	padding: 10px 10px 10px 10px;
> +	padding: 5px 10px 5px 10px;
>  	voice-family: "\"}\"";
>  	voice-family: inherit;
>  	margin-left: 51px;
>  	margin-right:51px;
>  	margin-bottom:0px;
> -	padding-bottom:10px;
>  }
>  
>  ul.menu {
> +	line-height: 2em;
>  	list-style-type:none;
>  	margin:0px;
>  	padding:0px;
diff mbox series

Patch

diff --git a/glibc.css b/glibc.css
index 817276a09851..be710b38586b 100644
--- a/glibc.css
+++ b/glibc.css
@@ -35,16 +35,16 @@  h1.title {
 	border-right:1px solid #000;
 	border-left:1px solid #000;
 	border-bottom:0px solid #000;
-	padding: 10px 10px 10px 10px;
+	padding: 5px 10px 5px 10px;
 	voice-family: "\"}\"";
 	voice-family: inherit;
 	margin-left: 51px;
 	margin-right:51px;
 	margin-bottom:0px;
-	padding-bottom:10px;
 }
 
 ul.menu {
+	line-height: 2em;
 	list-style-type:none;
 	margin:0px;
 	padding:0px;