diff mbox series

test: Run the tst-tls-allocation-failure-static-patched with test-wrapper.

Message ID 20231026032610.1918997-1-yanzhang.wang@intel.com
State Committed
Commit 2d27dc1c750849f888b38fa7f0dadf6b376095de
Delegated to: Florian Weimer
Headers
Series test: Run the tst-tls-allocation-failure-static-patched with test-wrapper. |

Checks

Context Check Description
redhat-pt-bot/TryBot-apply_patch success Patch applied to master at the time it was sent
redhat-pt-bot/TryBot-32bit success Build for i686
linaro-tcwg-bot/tcwg_glibc_check--master-arm success Testing passed
linaro-tcwg-bot/tcwg_glibc_build--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_glibc_check--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_glibc_build--master-arm success Testing passed

Commit Message

Wang, Yanzhang Oct. 26, 2023, 3:26 a.m. UTC 
  From: Yanzhang Wang <yanzhang.wang@intel.com>

If we use cross test with ssh, this test needs to be ran on the remote.
---
 elf/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Joseph Myers Nov. 1, 2023, 2:28 p.m. UTC | #1 
On Thu, 26 Oct 2023, yanzhang.wang@intel.com wrote:

> From: Yanzhang Wang <yanzhang.wang@intel.com>
> 
> If we use cross test with ssh, this test needs to be ran on the remote.

OK.  (I've seen this same test failure in cross testing.)
Florian Weimer Nov. 13, 2023, 2:56 p.m. UTC | #2 
* yanzhang wang:

> From: Yanzhang Wang <yanzhang.wang@intel.com>
>
> If we use cross test with ssh, this test needs to be ran on the remote.
> ---
>  elf/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/elf/Makefile b/elf/Makefile
> index 9176cbf1e3..1065b5c123 100644
> --- a/elf/Makefile
> +++ b/elf/Makefile
> @@ -2979,7 +2979,7 @@ $(objpfx)tst-tls-allocation-failure-static-patched: \
>  
>  $(objpfx)tst-tls-allocation-failure-static-patched.out: \
>    $(objpfx)tst-tls-allocation-failure-static-patched
> -	$< > $@ 2>&1; echo "status: $$?" >> $@
> +	$(test-wrapper) $< > $@ 2>&1; echo "status: $$?" >> $@
>  	grep -q '^Fatal glibc error: Cannot allocate TLS block$$' $@ \
>  	  && grep -q '^status: 127$$' $@; \
>  	  $(evaluate-test)

Thanks, applied.

Florian
diff mbox series

Patch

diff --git a/elf/Makefile b/elf/Makefile
index 9176cbf1e3..1065b5c123 100644
--- a/elf/Makefile
+++ b/elf/Makefile
@@ -2979,7 +2979,7 @@  $(objpfx)tst-tls-allocation-failure-static-patched: \
 
 $(objpfx)tst-tls-allocation-failure-static-patched.out: \
   $(objpfx)tst-tls-allocation-failure-static-patched
-	$< > $@ 2>&1; echo "status: $$?" >> $@
+	$(test-wrapper) $< > $@ 2>&1; echo "status: $$?" >> $@
 	grep -q '^Fatal glibc error: Cannot allocate TLS block$$' $@ \
 	  && grep -q '^status: 127$$' $@; \
 	  $(evaluate-test)