diff mbox series

[1/5] Define `am_pm` string

Message ID 20230804040608.25464-1-rushing27alien@gmail.com
State New
Headers
Series [1/5] Define `am_pm` string |

Checks

Context Check Description
redhat-pt-bot/TryBot-apply_patch success Patch applied to master at the time it was sent
linaro-tcwg-bot/tcwg_glibc_check--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_glibc_build--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_glibc_build--master-arm success Testing passed
linaro-tcwg-bot/tcwg_glibc_check--master-arm success Testing passed
redhat-pt-bot/TryBot-still_applies warning Patch no longer applies to master

Commit Message

develop--- via Libc-alpha Aug. 4, 2023, 4:06 a.m. UTC 
  From: RushingAlien <rushing27alien@gmail.com>

Current formatting does not define am_pm string, leading to AM and PM
not being specified in 12 H time format. This change defines the string
by changing it from an empty string to "AM";"PM".

`date +%r`
before: 01:23
after : 01.23 AM
---
 localedata/locales/id_ID | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Florian Weimer Aug. 7, 2023, 1:20 p.m. UTC | #1 
* rushing27alien:

> From: RushingAlien <rushing27alien@gmail.com>
>
> Current formatting does not define am_pm string, leading to AM and PM
> not being specified in 12 H time format. This change defines the string
> by changing it from an empty string to "AM";"PM".
>
> `date +%r`
> before: 01:23
> after : 01.23 AM
> ---
>  localedata/locales/id_ID | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/localedata/locales/id_ID b/localedata/locales/id_ID
> index c10306deb7..e306076e8b 100644
> --- a/localedata/locales/id_ID
> +++ b/localedata/locales/id_ID
> @@ -119,7 +119,7 @@ d_t_fmt     "%a %d %b %Y %r"
>  date_fmt    "%a %d %b %Y %r %Z"
>  d_fmt       "%d//%m//%y"
>  t_fmt       "%T"
> -am_pm       "";""
> +am_pm       "AM";"PM"
>  t_fmt_ampm  ""
>  week 7;19971130;1
>  END LC_TIME

Would you please add id_ID to the commit subject?  Thanks.

Maybe fold together some of the patches, too.

I don't know if we have any Indonesian cultural experts on this list who
could review this.  The first-day-of-week change seems correct based on
a quick web search.

Has this already been changed in CLDR?

Thanks,
Florian
diff mbox series

Patch

diff --git a/localedata/locales/id_ID b/localedata/locales/id_ID
index c10306deb7..e306076e8b 100644
--- a/localedata/locales/id_ID
+++ b/localedata/locales/id_ID
@@ -119,7 +119,7 @@  d_t_fmt     "%a %d %b %Y %r"
 date_fmt    "%a %d %b %Y %r %Z"
 d_fmt       "%d//%m//%y"
 t_fmt       "%T"
-am_pm       "";""
+am_pm       "AM";"PM"
 t_fmt_ampm  ""
 week 7;19971130;1
 END LC_TIME