[2/2] posix: Add test case for gai_strerror()
Checks
Context |
Check |
Description |
redhat-pt-bot/TryBot-apply_patch |
success
|
Patch applied to master at the time it was sent
|
redhat-pt-bot/TryBot-32bit |
success
|
Build for i686
|
linaro-tcwg-bot/tcwg_glibc_build--master-aarch64 |
success
|
Testing passed
|
linaro-tcwg-bot/tcwg_glibc_check--master-arm |
success
|
Testing passed
|
linaro-tcwg-bot/tcwg_glibc_build--master-arm |
success
|
Testing passed
|
linaro-tcwg-bot/tcwg_glibc_check--master-aarch64 |
success
|
Testing passed
|
Commit Message
Signed-off-by: Dridi Boukelmoune <dridi.boukelmoune@gmail.com>
---
posix/Makefile | 1 +
posix/tst-gai_strerror.c | 43 ++++++++++++++++++++++++++++++++++++++++
2 files changed, 44 insertions(+)
create mode 100644 posix/tst-gai_strerror.c
Comments
> Signed-off-by: Dridi Boukelmoune <dridi.boukelmoune@gmail.com>
Thanks! This patch looks good except for the copyright line. Since
you're using a developer's certificate of origin, I assume you want to
contribute without assigning copyright to the FSF -- which is a
process you could go through if you so wish. In case you want to
contribute with a DCO, the copyright line in the new test will need to
be changed. More details here:
https://sourceware.org/glibc/wiki/Contribution%20checklist#Update_copyright_information
> ---
> posix/Makefile | 1 +
> posix/tst-gai_strerror.c | 43 ++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 44 insertions(+)
> create mode 100644 posix/tst-gai_strerror.c
>
> diff --git a/posix/Makefile b/posix/Makefile
> index e19b74cd67..ad43cbdec6 100644
> --- a/posix/Makefile
> +++ b/posix/Makefile
> @@ -275,6 +275,7 @@ tests := \
> tst-fnmatch6 \
> tst-fnmatch7 \
> tst-fork \
> + tst-gai_strerror \
OK. Add test to Makefile.
> tst-getaddrinfo \
> tst-getaddrinfo2 \
> tst-getaddrinfo3 \
> diff --git a/posix/tst-gai_strerror.c b/posix/tst-gai_strerror.c
> new file mode 100644
> index 0000000000..2b3c0e057a
> --- /dev/null
> +++ b/posix/tst-gai_strerror.c
> @@ -0,0 +1,43 @@
> +/* Test for gai_strerror()
> + Copyright (C) 2022-2023 Free Software Foundation, Inc.
If you're contributing with a DCO, this will need editing to:
"Copyright The GNU Toolchain Authors."
> + This file is part of the GNU C Library.
> +
> + The GNU C Library is free software; you can redistribute it and/or
> + modify it under the terms of the GNU Lesser General Public
> + License as published by the Free Software Foundation; either
> + version 2.1 of the License, or (at your option) any later version.
> +
> + The GNU C Library is distributed in the hope that it will be useful,
> + but WITHOUT ANY WARRANTY; without even the implied warranty of
> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> + Lesser General Public License for more details.
> +
> + You should have received a copy of the GNU Lesser General Public
> + License along with the GNU C Library; if not, see
> + <https://www.gnu.org/licenses/>. */
> +
> +#include <sys/types.h>
> +#include <sys/socket.h>
> +#include <netdb.h>
> +#include <stdlib.h>
> +#include <locale.h>
> +
> +#include <support/support.h>
> +#include <support/check.h>
> +
> +static int
> +do_test (void)
> +{
> + unsetenv ("LANGUAGE");
> +
> + xsetlocale (LC_ALL, "C");
OK.
> +
> + TEST_COMPARE_STRING (gai_strerror (1), "Unknown error");
> + TEST_COMPARE_STRING (gai_strerror (0), "Success");
> + TEST_COMPARE_STRING (gai_strerror (EAI_OVERFLOW),
> + "Result too large for supplied buffer");
OK.
> +
> + return 0;
> +}
> +
> +#include <support/test-driver.c>
> --
> 2.40.1
>
<snip>
> > +/* Test for gai_strerror()
> > + Copyright (C) 2022-2023 Free Software Foundation, Inc.
>
> If you're contributing with a DCO, this will need editing to:
>
> "Copyright The GNU Toolchain Authors."
I didn't pay enough attention, new patch series submitted.
Thanks!
Dridi
@@ -275,6 +275,7 @@ tests := \
tst-fnmatch6 \
tst-fnmatch7 \
tst-fork \
+ tst-gai_strerror \
tst-getaddrinfo \
tst-getaddrinfo2 \
tst-getaddrinfo3 \
new file mode 100644
@@ -0,0 +1,43 @@
+/* Test for gai_strerror()
+ Copyright (C) 2022-2023 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <https://www.gnu.org/licenses/>. */
+
+#include <sys/types.h>
+#include <sys/socket.h>
+#include <netdb.h>
+#include <stdlib.h>
+#include <locale.h>
+
+#include <support/support.h>
+#include <support/check.h>
+
+static int
+do_test (void)
+{
+ unsetenv ("LANGUAGE");
+
+ xsetlocale (LC_ALL, "C");
+
+ TEST_COMPARE_STRING (gai_strerror (1), "Unknown error");
+ TEST_COMPARE_STRING (gai_strerror (0), "Success");
+ TEST_COMPARE_STRING (gai_strerror (EAI_OVERFLOW),
+ "Result too large for supplied buffer");
+
+ return 0;
+}
+
+#include <support/test-driver.c>