diff mbox series

[v7,4/4] x86: Tune 'Saltwell' microarch the same was a 'Bonnell'

Message ID 20230510221213.765754-3-goldstein.w.n@gmail.com
State Superseded
Headers
Series None |

Commit Message

Noah Goldstein May 10, 2023, 10:12 p.m. UTC 
  Saltwell is just a die shrink of Bonnell, so the same
micro-architectural optimization preferences apply.
---
 sysdeps/x86/cpu-features.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Noah Goldstein May 12, 2023, 5:12 a.m. UTC | #1 
On Wed, May 10, 2023 at 5:12 PM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
>
> Saltwell is just a die shrink of Bonnell, so the same
> micro-architectural optimization preferences apply.
> ---
>  sysdeps/x86/cpu-features.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sysdeps/x86/cpu-features.c b/sysdeps/x86/cpu-features.c
> index 4cc1cd9fed..0fb02d2f39 100644
> --- a/sysdeps/x86/cpu-features.c
> +++ b/sysdeps/x86/cpu-features.c
> @@ -672,7 +672,8 @@ init_cpu_features (struct cpu_features *cpu_features)
>             {
>               /* Atom / KNL tuning.  */
>             case INTEL_ATOM_BONNELL:
> -             /* BSF is slow on Bonnell.  */
> +           case INTEL_ATOM_SALTWELL:
> +             /* BSF is slow on Bonnell/Saltwell.  */
>               cpu_features->preferred[index_arch_Slow_BSF]
>                   |= bit_arch_Slow_BSF;
>               break;
> @@ -710,7 +711,6 @@ init_cpu_features (struct cpu_features *cpu_features)
>               /* Default tuned atom microarch.  */
>             case INTEL_ATOM_SIERRAFOREST:
>             case INTEL_ATOM_GRANDRIDGE:
> -           case INTEL_ATOM_SALTWELL:
>               goto default_tuning;
>
>               /* Bigcore Tuning.  */
> --
> 2.34.1
>

Abandoning this patch. Its not longer needed as we just use the same def for
bonnell and saltwell now.
diff mbox series

Patch

diff --git a/sysdeps/x86/cpu-features.c b/sysdeps/x86/cpu-features.c
index 4cc1cd9fed..0fb02d2f39 100644
--- a/sysdeps/x86/cpu-features.c
+++ b/sysdeps/x86/cpu-features.c
@@ -672,7 +672,8 @@  init_cpu_features (struct cpu_features *cpu_features)
 	    {
 	      /* Atom / KNL tuning.  */
 	    case INTEL_ATOM_BONNELL:
-	      /* BSF is slow on Bonnell.  */
+	    case INTEL_ATOM_SALTWELL:
+	      /* BSF is slow on Bonnell/Saltwell.  */
 	      cpu_features->preferred[index_arch_Slow_BSF]
 		  |= bit_arch_Slow_BSF;
 	      break;
@@ -710,7 +711,6 @@  init_cpu_features (struct cpu_features *cpu_features)
 	      /* Default tuned atom microarch.  */
 	    case INTEL_ATOM_SIERRAFOREST:
 	    case INTEL_ATOM_GRANDRIDGE:
-	    case INTEL_ATOM_SALTWELL:
 	      goto default_tuning;
 
 	      /* Bigcore Tuning.  */