| Message ID | 20220628152735.17863-1-goldstein.w.n@gmail.com |
|---|---|
| State | Superseded |
| Headers |
Return-Path: <libc-alpha-bounces+patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5218738CDA0C for <patchwork@sourceware.org>; Tue, 28 Jun 2022 15:29:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5218738CDA0C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1656430173; bh=AvAfzlnjg/PeYqEGIWN/wP+RjIoliQ5bY8GtbA1m1BY=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=DytGwbgI3KkMbfDOWgFCWiwdWEhXi2LuHo1u4knfQUqXjQV5P7yyX3bosbomcb54d oaqfvgXIaPtLAi9eHrwc+j87I9Lz5TnCawZS29ryo+9twBPqT7D/XrCBG/qYUotNtS yTEfyESaZMYL3RJkRXFznPPSwDKmiCGEbH59GjhQ= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by sourceware.org (Postfix) with ESMTPS id B266E3810B77 for <libc-alpha@sourceware.org>; Tue, 28 Jun 2022 15:27:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B266E3810B77 Received: by mail-pl1-x631.google.com with SMTP id x20so5776403plx.6 for <libc-alpha@sourceware.org>; Tue, 28 Jun 2022 08:27:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=AvAfzlnjg/PeYqEGIWN/wP+RjIoliQ5bY8GtbA1m1BY=; b=B6uTQbt4s2+WALJ+nAWUHiUYuqbmkchwN3cKM5ApPjuLS7M/TIh74VfCkAqKJ5XSuC jCa5Pc+QKicliqaQXRaRquqX3TOYK3qnqvNvB6pncWOp+i5pDVXtwXii93Zqvtv0ZDFd cAsMxbFa3vZjnf6VZ91fE8RrWcSI7qhNQ0qyTFsSDe7eNTYxOU+KqoU5b31+XkpLiTWm pkQ8e0NvMDOtJSzl/G8iOWWe4et9r37W6N6kne6BhnQf8ltl31Tlc8pGImTH93wKPzCF wy4jJm5lYV3NcBkZTbCisyU13EBgw9HS1cHyDlBYSIu1Nf1TUX4NulCjQj5eLbFbYmxa ILvg== X-Gm-Message-State: AJIora+AEjWypNnXT+zcW8GEKVF9JJASKbMC1sbmOKTrfOBzkcoH9x4z fVtPjMPXk+CdorgyqeT0BFhvgCdd/Vk= X-Google-Smtp-Source: AGRyM1vFHvdH5jthGKcyml4r3GUGwZ+kw89uqycW5t3EDELTPMxAFyRNQd2l3DPXIz9S8Xa1nVwzhw== X-Received: by 2002:a17:90b:180f:b0:1ed:28cc:188f with SMTP id lw15-20020a17090b180f00b001ed28cc188fmr164086pjb.25.1656430058676; Tue, 28 Jun 2022 08:27:38 -0700 (PDT) Received: from noah-tgl.. ([192.55.60.43]) by smtp.gmail.com with ESMTPSA id jj2-20020a170903048200b0016a4db1343fsm9445361plb.190.2022.06.28.08.27.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jun 2022 08:27:38 -0700 (PDT) To: libc-alpha@sourceware.org Subject: [PATCH v1 1/3] x86: Add definition for __wmemset_chk AVX2 RTM in ifunc impl list Date: Tue, 28 Jun 2022 08:27:33 -0700 Message-Id: <20220628152735.17863-1-goldstein.w.n@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=subscribe> From: Noah Goldstein via Libc-alpha <libc-alpha@sourceware.org> Reply-To: Noah Goldstein <goldstein.w.n@gmail.com> Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" <libc-alpha-bounces+patchwork=sourceware.org@sourceware.org> |
| Series |
[v1,1/3] x86: Add definition for __wmemset_chk AVX2 RTM in ifunc impl list
|
|
Checks
| Context | Check | Description |
|---|---|---|
| dj/TryBot-apply_patch | success | Patch applied to master at the time it was sent |
Commit Message
Noah Goldstein
June 28, 2022, 3:27 p.m. UTC
This was simply missing and meant we weren't testing it properly. --- sysdeps/x86_64/multiarch/ifunc-impl-list.c | 4 ++++ 1 file changed, 4 insertions(+)
Comments
On Tue, Jun 28, 2022 at 8:27 AM Noah Goldstein <goldstein.w.n@gmail.com> wrote: > > This was simply missing and meant we weren't testing it properly. > --- > sysdeps/x86_64/multiarch/ifunc-impl-list.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/sysdeps/x86_64/multiarch/ifunc-impl-list.c b/sysdeps/x86_64/multiarch/ifunc-impl-list.c > index 251b0022d9..3ae4d49bee 100644 > --- a/sysdeps/x86_64/multiarch/ifunc-impl-list.c > +++ b/sysdeps/x86_64/multiarch/ifunc-impl-list.c > @@ -1028,6 +1028,10 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array, > IFUNC_IMPL_ADD (array, i, __wmemset_chk, > CPU_FEATURE_USABLE (AVX2), > __wmemset_chk_avx2_unaligned) > + IFUNC_IMPL_ADD (array, i, wmemset_chk, > + (CPU_FEATURE_USABLE (AVX2) > + && CPU_FEATURE_USABLE (RTM)), > + __wmemset_chk_avx2_unaligned_rtm) > IFUNC_IMPL_ADD (array, i, __wmemset_chk, > (CPU_FEATURE_USABLE (AVX512VL) > && CPU_FEATURE_USABLE (AVX512BW) > -- > 2.34.1 > LGTM. Thanks.
On Wed, Jun 29, 2022 at 12:22 PM H.J. Lu <hjl.tools@gmail.com> wrote: > > On Tue, Jun 28, 2022 at 8:27 AM Noah Goldstein <goldstein.w.n@gmail.com> wrote: > > > > This was simply missing and meant we weren't testing it properly. > > --- > > sysdeps/x86_64/multiarch/ifunc-impl-list.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/sysdeps/x86_64/multiarch/ifunc-impl-list.c b/sysdeps/x86_64/multiarch/ifunc-impl-list.c > > index 251b0022d9..3ae4d49bee 100644 > > --- a/sysdeps/x86_64/multiarch/ifunc-impl-list.c > > +++ b/sysdeps/x86_64/multiarch/ifunc-impl-list.c > > @@ -1028,6 +1028,10 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array, > > IFUNC_IMPL_ADD (array, i, __wmemset_chk, > > CPU_FEATURE_USABLE (AVX2), > > __wmemset_chk_avx2_unaligned) > > + IFUNC_IMPL_ADD (array, i, wmemset_chk, This wasn't __wmemset_chk > > + (CPU_FEATURE_USABLE (AVX2) > > + && CPU_FEATURE_USABLE (RTM)), > > + __wmemset_chk_avx2_unaligned_rtm) > > IFUNC_IMPL_ADD (array, i, __wmemset_chk, > > (CPU_FEATURE_USABLE (AVX512VL) > > && CPU_FEATURE_USABLE (AVX512BW) > > -- > > 2.34.1 > > > > LGTM. > > Thanks. > There was an issue with this patch standalone. Fixed in V3. > -- > H.J.
On Wed, Jun 29, 2022 at 4:09 PM Noah Goldstein via Libc-alpha <libc-alpha@sourceware.org> wrote: > > On Wed, Jun 29, 2022 at 12:22 PM H.J. Lu <hjl.tools@gmail.com> wrote: > > > > On Tue, Jun 28, 2022 at 8:27 AM Noah Goldstein <goldstein.w.n@gmail.com> wrote: > > > > > > This was simply missing and meant we weren't testing it properly. > > > --- > > > sysdeps/x86_64/multiarch/ifunc-impl-list.c | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/sysdeps/x86_64/multiarch/ifunc-impl-list.c b/sysdeps/x86_64/multiarch/ifunc-impl-list.c > > > index 251b0022d9..3ae4d49bee 100644 > > > --- a/sysdeps/x86_64/multiarch/ifunc-impl-list.c > > > +++ b/sysdeps/x86_64/multiarch/ifunc-impl-list.c > > > @@ -1028,6 +1028,10 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array, > > > IFUNC_IMPL_ADD (array, i, __wmemset_chk, > > > CPU_FEATURE_USABLE (AVX2), > > > __wmemset_chk_avx2_unaligned) > > > + IFUNC_IMPL_ADD (array, i, wmemset_chk, > This wasn't __wmemset_chk > > > + (CPU_FEATURE_USABLE (AVX2) > > > + && CPU_FEATURE_USABLE (RTM)), > > > + __wmemset_chk_avx2_unaligned_rtm) > > > IFUNC_IMPL_ADD (array, i, __wmemset_chk, > > > (CPU_FEATURE_USABLE (AVX512VL) > > > && CPU_FEATURE_USABLE (AVX512BW) > > > -- > > > 2.34.1 > > > > > > > LGTM. > > > > Thanks. > > > > There was an issue with this patch standalone. > > Fixed in V3. > > -- > > H.J. I would like to backport this patch to release branches. Any comments or objections? --Sunil
diff --git a/sysdeps/x86_64/multiarch/ifunc-impl-list.c b/sysdeps/x86_64/multiarch/ifunc-impl-list.c index 251b0022d9..3ae4d49bee 100644 --- a/sysdeps/x86_64/multiarch/ifunc-impl-list.c +++ b/sysdeps/x86_64/multiarch/ifunc-impl-list.c @@ -1028,6 +1028,10 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array, IFUNC_IMPL_ADD (array, i, __wmemset_chk, CPU_FEATURE_USABLE (AVX2), __wmemset_chk_avx2_unaligned) + IFUNC_IMPL_ADD (array, i, wmemset_chk, + (CPU_FEATURE_USABLE (AVX2) + && CPU_FEATURE_USABLE (RTM)), + __wmemset_chk_avx2_unaligned_rtm) IFUNC_IMPL_ADD (array, i, __wmemset_chk, (CPU_FEATURE_USABLE (AVX512VL) && CPU_FEATURE_USABLE (AVX512BW)