x86_64: Disable libmvec tests if multiarch not enabled [BZ# 28869]

Message ID 20220223224255.2077646-1-skpgkp2@gmail.com
State Committed
Commit 1153f7158608cfa3e7372e03bb82566a3dab1a19
Headers
Series x86_64: Disable libmvec tests if multiarch not enabled [BZ# 28869] |

Checks

Context Check Description
dj/TryBot-apply_patch success Patch applied to master at the time it was sent
dj/TryBot-32bit success Build for i686

Commit Message

Sunil Pandey Feb. 23, 2022, 10:42 p.m. UTC
  This patch disable libmvec math tests if multiarch not enabled.

This fixes [BZ# 28869]
---
 sysdeps/x86_64/fpu/Makefile | 3 +++
 1 file changed, 3 insertions(+)
  

Comments

H.J. Lu Feb. 23, 2022, 10:54 p.m. UTC | #1
On Wed, Feb 23, 2022 at 2:43 PM Sunil K Pandey <skpgkp2@gmail.com> wrote:
>
> This patch disable libmvec math tests if multiarch not enabled.
>
> This fixes [BZ# 28869]
> ---
>  sysdeps/x86_64/fpu/Makefile | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/sysdeps/x86_64/fpu/Makefile b/sysdeps/x86_64/fpu/Makefile
> index 9fb587cf8f..8278ce104a 100644
> --- a/sysdeps/x86_64/fpu/Makefile
> +++ b/sysdeps/x86_64/fpu/Makefile
> @@ -24,6 +24,8 @@ libmvec-support += \
>      $(addprefix svml_s_,$(addsuffix $(l),$(libmvec-funcs))))
>  endif
>
> +# Do not run libmvec tests if multiarch not enabled.
> +ifneq ($(multi-arch),no)
>  # Variables for libmvec tests.
>  ifeq ($(subdir)$(build-mathvec),mathyes)
>  libmvec-tests += double-vlen2 double-vlen4 double-vlen4-avx2 \
> @@ -112,3 +114,4 @@ $(objpfx)bench-double-%.c: $(bench-libmvec-deps)
>         $(PYTHON) $(..)sysdeps/x86_64/fpu/scripts/bench_libmvec.py $(basename $(@F)); } > $@-tmp
>         mv -f $@-tmp $@
>  endif
> +endif
> --
> 2.34.1
>

LGTM.

Reviewed-by: H.J. Lu <hjl.tools@gmail.com>

Thanks.
  

Patch

diff --git a/sysdeps/x86_64/fpu/Makefile b/sysdeps/x86_64/fpu/Makefile
index 9fb587cf8f..8278ce104a 100644
--- a/sysdeps/x86_64/fpu/Makefile
+++ b/sysdeps/x86_64/fpu/Makefile
@@ -24,6 +24,8 @@  libmvec-support += \
     $(addprefix svml_s_,$(addsuffix $(l),$(libmvec-funcs))))
 endif
 
+# Do not run libmvec tests if multiarch not enabled.
+ifneq ($(multi-arch),no)
 # Variables for libmvec tests.
 ifeq ($(subdir)$(build-mathvec),mathyes)
 libmvec-tests += double-vlen2 double-vlen4 double-vlen4-avx2 \
@@ -112,3 +114,4 @@  $(objpfx)bench-double-%.c: $(bench-libmvec-deps)
 	$(PYTHON) $(..)sysdeps/x86_64/fpu/scripts/bench_libmvec.py $(basename $(@F)); } > $@-tmp
 	mv -f $@-tmp $@
 endif
+endif