[v3] tst: Provide test for ctime

Message ID 20210127124117.19193-1-lukma@denx.de
State Superseded
Delegated to: Florian Weimer
Headers
Series [v3] tst: Provide test for ctime |

Commit Message

Lukasz Majewski Jan. 27, 2021, 12:41 p.m. UTC
  This change adds new test to assess ctime's functionality.

To be more specific - following use cases are checked:
- Pass time_t value as 0 to check if epoch time is converted
- Pass time_t as max value for 32 bit systems
- Pass time_t as the first value after Y2038 threshold

---
Changes for v2:
- Add setting of TZ env variable

Changes for v3:
- Remove FAIL_UNSUPPORTED() when sizeof (time_t) <= 4
- Use "TZ=:" glibc extension to guarantee UTC time zone
---
 time/Makefile    |  2 +-
 time/tst-ctime.c | 55 ++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 56 insertions(+), 1 deletion(-)
 create mode 100644 time/tst-ctime.c
  

Patch

diff --git a/time/Makefile b/time/Makefile
index 43e5821adc..486fb02ecb 100644
--- a/time/Makefile
+++ b/time/Makefile
@@ -51,7 +51,7 @@  tests	:= test_time clocktest tst-posixtz tst-strptime tst_wcsftime \
 	   tst-clock tst-clock2 tst-clock_nanosleep tst-cpuclock1 \
 	   tst-adjtime tst-clock-y2038 tst-clock2-y2038 \
 	   tst-cpuclock1-y2038 tst-clock_nanosleep-y2038 tst-clock_settime \
-	   tst-clock_adjtime
+	   tst-clock_adjtime tst-ctime
 
 include ../Rules
 
diff --git a/time/tst-ctime.c b/time/tst-ctime.c
new file mode 100644
index 0000000000..e19ccb43f8
--- /dev/null
+++ b/time/tst-ctime.c
@@ -0,0 +1,55 @@ 
+/* Test for ctime
+   Copyright (C) 2021 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <https://www.gnu.org/licenses/>.  */
+
+#include <time.h>
+#include <stdlib.h>
+#include <support/check.h>
+
+static int
+do_test (void)
+{
+  char *str;
+  time_t t;
+
+  /* Use glibc time zone extension "TZ=:" to to guarantee that UTC
+     without leap seconds is used for the test.  */
+  TEST_VERIFY_EXIT (setenv ("TZ", ":", 1) == 0);
+  tzset ();
+
+  /* Check if the epoch time can be converted.  */
+  t = 0;
+  str = ctime (&t);
+  TEST_COMPARE_STRING (str, "Thu Jan  1 00:00:00 1970\n");
+
+  /* Check if the max time value for 32 bit time_t can be converted.  */
+  t = 0x7fffffff;
+  str = ctime (&t);
+  TEST_COMPARE_STRING (str, "Tue Jan 19 03:14:07 2038\n");
+
+  /* Check if the time is converted after 32 bit time_t overflow.  */
+  if (sizeof (time_t) > 4)
+    {
+      t++;
+      str = ctime (&t);
+      TEST_COMPARE_STRING (str, "Tue Jan 19 03:14:08 2038\n");
+    }
+
+  return 0;
+}
+
+#include <support/test-driver.c>