Message ID | 20200812142831.3694409-1-stli@linux.ibm.com |
---|---|
State | Committed |
Headers |
Return-Path: <libc-alpha-bounces@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9FD593861896; Wed, 12 Aug 2020 14:28:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9FD593861896 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1597242520; bh=7ACypcPy6Br0JQuDVtVPpyave1hrjLUK+1/x/cpMNX0=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=PlNNFeBmixWvVqr3DCwT/vvlv/TfwBTwXk65N54UWC5sbpV3AAnsPAmFLOZ2LV0Gm 8qC1gbQVQ0e9M5ippkXfyrh4cQfFefyEpeX3uiaQLCvdvXaCEkd9GC1pfa5Sr6IucA lktqxXEJGE+GD3hJYZtOJJVzErfBqpuchGoKkhNA= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id E2E2E3861038 for <libc-alpha@sourceware.org>; Wed, 12 Aug 2020 14:28:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E2E2E3861038 Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 07CE6dVT024206 for <libc-alpha@sourceware.org>; Wed, 12 Aug 2020 10:28:38 -0400 Received: from ppma03fra.de.ibm.com (6b.4a.5195.ip4.static.sl-reverse.com [149.81.74.107]) by mx0a-001b2d01.pphosted.com with ESMTP id 32utn90kvv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for <libc-alpha@sourceware.org>; Wed, 12 Aug 2020 10:28:37 -0400 Received: from pps.filterd (ppma03fra.de.ibm.com [127.0.0.1]) by ppma03fra.de.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 07CEJwRk021203 for <libc-alpha@sourceware.org>; Wed, 12 Aug 2020 14:28:35 GMT Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by ppma03fra.de.ibm.com with ESMTP id 32skp82sea-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for <libc-alpha@sourceware.org>; Wed, 12 Aug 2020 14:28:35 +0000 Received: from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 07CESWTU29688162 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 12 Aug 2020 14:28:33 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D446C42045; Wed, 12 Aug 2020 14:28:32 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B1F2642041; Wed, 12 Aug 2020 14:28:32 +0000 (GMT) Received: from t35lp57.lnxne.boe (unknown [9.152.108.100]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 12 Aug 2020 14:28:32 +0000 (GMT) To: libc-alpha@sourceware.org Subject: [PATCH] S390: Sync HWCAP names with kernel by adding aliases [BZ #25971] Date: Wed, 12 Aug 2020 16:28:31 +0200 Message-Id: <20200812142831.3694409-1-stli@linux.ibm.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-08-12_06:2020-08-11, 2020-08-12 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 spamscore=0 malwarescore=0 bulkscore=0 mlxscore=0 suspectscore=1 mlxlogscore=535 clxscore=1015 impostorscore=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008120100 X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=subscribe> From: Stefan Liebler via Libc-alpha <libc-alpha@sourceware.org> Reply-To: Stefan Liebler <stli@linux.ibm.com> Cc: Stefan Liebler <stli@linux.ibm.com> Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" <libc-alpha-bounces@sourceware.org> |
Series |
S390: Sync HWCAP names with kernel by adding aliases [BZ #25971]
|
|
Commit Message
Stefan Liebler
Aug. 12, 2020, 2:28 p.m. UTC
Unfortunately some HWCAP names like HWCAP_S390_VX differs between kernel (see <kernel>/arch/s390/include/asm/elf.h) and glibc. Therefore, those HWCAP names from kernel are now introduced as alias to the existing ones in glibc. --- sysdeps/s390/dl-procinfo.h | 3 +++ sysdeps/unix/sysv/linux/s390/bits/hwcap.h | 3 +++ 2 files changed, 6 insertions(+)
Comments
On 8/12/20 4:28 PM, Stefan Liebler wrote: > Unfortunately some HWCAP names like HWCAP_S390_VX differs between > kernel (see <kernel>/arch/s390/include/asm/elf.h) and glibc. > > Therefore, those HWCAP names from kernel are now introduced as alias > to the existing ones in glibc. > --- > sysdeps/s390/dl-procinfo.h | 3 +++ > sysdeps/unix/sysv/linux/s390/bits/hwcap.h | 3 +++ > 2 files changed, 6 insertions(+) > > diff --git a/sysdeps/s390/dl-procinfo.h b/sysdeps/s390/dl-procinfo.h > index 0db4bc39c7..08eee109f7 100644 > --- a/sysdeps/s390/dl-procinfo.h > +++ b/sysdeps/s390/dl-procinfo.h > @@ -51,8 +51,11 @@ enum > HWCAP_S390_HIGH_GPRS = 1 << 9, > HWCAP_S390_TE = 1 << 10, > HWCAP_S390_VX = 1 << 11, > + HWCAP_S390_VXRS = HWCAP_S390_VX, > HWCAP_S390_VXD = 1 << 12, > + HWCAP_S390_VXRS_BCD = HWCAP_S390_VXD, > HWCAP_S390_VXE = 1 << 13, > + HWCAP_S390_VXRS_EXT = HWCAP_S390_VXE, > HWCAP_S390_GS = 1 << 14, > HWCAP_S390_VXRS_EXT2 = 1 << 15, > HWCAP_S390_VXRS_PDE = 1 << 16, > diff --git a/sysdeps/unix/sysv/linux/s390/bits/hwcap.h b/sysdeps/unix/sysv/linux/s390/bits/hwcap.h > index 6adbec018b..f2998ff131 100644 > --- a/sysdeps/unix/sysv/linux/s390/bits/hwcap.h > +++ b/sysdeps/unix/sysv/linux/s390/bits/hwcap.h > @@ -36,8 +36,11 @@ > #define HWCAP_S390_HIGH_GPRS 512 > #define HWCAP_S390_TE 1024 > #define HWCAP_S390_VX 2048 > +#define HWCAP_S390_VXRS HWCAP_S390_VX > #define HWCAP_S390_VXD 4096 > +#define HWCAP_S390_VXRS_BCD HWCAP_S390_VXD > #define HWCAP_S390_VXE 8192 > +#define HWCAP_S390_VXRS_EXT HWCAP_S390_VXE > #define HWCAP_S390_GS 16384 > #define HWCAP_S390_VXRS_EXT2 32768 > #define HWCAP_S390_VXRS_PDE 65536 > Ping
On 8/12/20 10:28 AM, Stefan Liebler via Libc-alpha wrote: > Unfortunately some HWCAP names like HWCAP_S390_VX differs between > kernel (see <kernel>/arch/s390/include/asm/elf.h) and glibc. > > Therefore, those HWCAP names from kernel are now introduced as alias > to the existing ones in glibc. > --- > sysdeps/s390/dl-procinfo.h | 3 +++ > sysdeps/unix/sysv/linux/s390/bits/hwcap.h | 3 +++ > 2 files changed, 6 insertions(+) > > diff --git a/sysdeps/s390/dl-procinfo.h b/sysdeps/s390/dl-procinfo.h > index 0db4bc39c7..08eee109f7 100644 > --- a/sysdeps/s390/dl-procinfo.h > +++ b/sysdeps/s390/dl-procinfo.h > @@ -51,8 +51,11 @@ enum > HWCAP_S390_HIGH_GPRS = 1 << 9, > HWCAP_S390_TE = 1 << 10, > HWCAP_S390_VX = 1 << 11, > + HWCAP_S390_VXRS = HWCAP_S390_VX, > HWCAP_S390_VXD = 1 << 12, > + HWCAP_S390_VXRS_BCD = HWCAP_S390_VXD, > HWCAP_S390_VXE = 1 << 13, > + HWCAP_S390_VXRS_EXT = HWCAP_S390_VXE, > HWCAP_S390_GS = 1 << 14, > HWCAP_S390_VXRS_EXT2 = 1 << 15, > HWCAP_S390_VXRS_PDE = 1 << 16, > diff --git a/sysdeps/unix/sysv/linux/s390/bits/hwcap.h b/sysdeps/unix/sysv/linux/s390/bits/hwcap.h > index 6adbec018b..f2998ff131 100644 > --- a/sysdeps/unix/sysv/linux/s390/bits/hwcap.h > +++ b/sysdeps/unix/sysv/linux/s390/bits/hwcap.h > @@ -36,8 +36,11 @@ > #define HWCAP_S390_HIGH_GPRS 512 > #define HWCAP_S390_TE 1024 > #define HWCAP_S390_VX 2048 > +#define HWCAP_S390_VXRS HWCAP_S390_VX > #define HWCAP_S390_VXD 4096 > +#define HWCAP_S390_VXRS_BCD HWCAP_S390_VXD > #define HWCAP_S390_VXE 8192 > +#define HWCAP_S390_VXRS_EXT HWCAP_S390_VXE > #define HWCAP_S390_GS 16384 > #define HWCAP_S390_VXRS_EXT2 32768 > #define HWCAP_S390_VXRS_PDE 65536 > As the machine maintainer you should assume consensus and just commit this. I assume you know what you're doing synchronizing and matching these names.
On 8/20/20 11:49 PM, Carlos O'Donell wrote: > On 8/12/20 10:28 AM, Stefan Liebler via Libc-alpha wrote: >> Unfortunately some HWCAP names like HWCAP_S390_VX differs between >> kernel (see <kernel>/arch/s390/include/asm/elf.h) and glibc. >> >> Therefore, those HWCAP names from kernel are now introduced as alias >> to the existing ones in glibc. >> --- >> sysdeps/s390/dl-procinfo.h | 3 +++ >> sysdeps/unix/sysv/linux/s390/bits/hwcap.h | 3 +++ >> 2 files changed, 6 insertions(+) >> >> diff --git a/sysdeps/s390/dl-procinfo.h b/sysdeps/s390/dl-procinfo.h >> index 0db4bc39c7..08eee109f7 100644 >> --- a/sysdeps/s390/dl-procinfo.h >> +++ b/sysdeps/s390/dl-procinfo.h >> @@ -51,8 +51,11 @@ enum >> HWCAP_S390_HIGH_GPRS = 1 << 9, >> HWCAP_S390_TE = 1 << 10, >> HWCAP_S390_VX = 1 << 11, >> + HWCAP_S390_VXRS = HWCAP_S390_VX, >> HWCAP_S390_VXD = 1 << 12, >> + HWCAP_S390_VXRS_BCD = HWCAP_S390_VXD, >> HWCAP_S390_VXE = 1 << 13, >> + HWCAP_S390_VXRS_EXT = HWCAP_S390_VXE, >> HWCAP_S390_GS = 1 << 14, >> HWCAP_S390_VXRS_EXT2 = 1 << 15, >> HWCAP_S390_VXRS_PDE = 1 << 16, >> diff --git a/sysdeps/unix/sysv/linux/s390/bits/hwcap.h b/sysdeps/unix/sysv/linux/s390/bits/hwcap.h >> index 6adbec018b..f2998ff131 100644 >> --- a/sysdeps/unix/sysv/linux/s390/bits/hwcap.h >> +++ b/sysdeps/unix/sysv/linux/s390/bits/hwcap.h >> @@ -36,8 +36,11 @@ >> #define HWCAP_S390_HIGH_GPRS 512 >> #define HWCAP_S390_TE 1024 >> #define HWCAP_S390_VX 2048 >> +#define HWCAP_S390_VXRS HWCAP_S390_VX >> #define HWCAP_S390_VXD 4096 >> +#define HWCAP_S390_VXRS_BCD HWCAP_S390_VXD >> #define HWCAP_S390_VXE 8192 >> +#define HWCAP_S390_VXRS_EXT HWCAP_S390_VXE >> #define HWCAP_S390_GS 16384 >> #define HWCAP_S390_VXRS_EXT2 32768 >> #define HWCAP_S390_VXRS_PDE 65536 >> > > As the machine maintainer you should assume consensus and just commit this. > > I assume you know what you're doing synchronizing and matching these names. > Sure. Nevertheless feedback is always welcome and I can also wait a bit before commiting it. Now I've committed the patch and resolved the bugzilla. Thanks. Stefan
diff --git a/sysdeps/s390/dl-procinfo.h b/sysdeps/s390/dl-procinfo.h index 0db4bc39c7..08eee109f7 100644 --- a/sysdeps/s390/dl-procinfo.h +++ b/sysdeps/s390/dl-procinfo.h @@ -51,8 +51,11 @@ enum HWCAP_S390_HIGH_GPRS = 1 << 9, HWCAP_S390_TE = 1 << 10, HWCAP_S390_VX = 1 << 11, + HWCAP_S390_VXRS = HWCAP_S390_VX, HWCAP_S390_VXD = 1 << 12, + HWCAP_S390_VXRS_BCD = HWCAP_S390_VXD, HWCAP_S390_VXE = 1 << 13, + HWCAP_S390_VXRS_EXT = HWCAP_S390_VXE, HWCAP_S390_GS = 1 << 14, HWCAP_S390_VXRS_EXT2 = 1 << 15, HWCAP_S390_VXRS_PDE = 1 << 16, diff --git a/sysdeps/unix/sysv/linux/s390/bits/hwcap.h b/sysdeps/unix/sysv/linux/s390/bits/hwcap.h index 6adbec018b..f2998ff131 100644 --- a/sysdeps/unix/sysv/linux/s390/bits/hwcap.h +++ b/sysdeps/unix/sysv/linux/s390/bits/hwcap.h @@ -36,8 +36,11 @@ #define HWCAP_S390_HIGH_GPRS 512 #define HWCAP_S390_TE 1024 #define HWCAP_S390_VX 2048 +#define HWCAP_S390_VXRS HWCAP_S390_VX #define HWCAP_S390_VXD 4096 +#define HWCAP_S390_VXRS_BCD HWCAP_S390_VXD #define HWCAP_S390_VXE 8192 +#define HWCAP_S390_VXRS_EXT HWCAP_S390_VXE #define HWCAP_S390_GS 16384 #define HWCAP_S390_VXRS_EXT2 32768 #define HWCAP_S390_VXRS_PDE 65536