diff mbox

localedata: Add Minguo calendar support to zh_TW

Message ID 20190213105150.9323-1-felixonmars@archlinux.org
State Superseded
Headers show

Commit Message

Felix Yan Feb. 13, 2019, 10:51 a.m. UTC 
Minguo calendar is the official calendar system, and very widely used in
Taiwan, it would be nice to have the support in glibc.

Some background information: The government website (www.gov.tw) uses it
without the prefix, popular public services like Taiwan HSR also uses
this calendar system.

Link to wikipedia: https://en.wikipedia.org/wiki/Minguo_calendar
---
 localedata/locales/zh_TW | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Rafal Luzynski March 1, 2019, 6:31 p.m. UTC | #1 
Hello Felix,

Thank you for your effort and I'm sorry for the late reply.
I think this is your first contribution for glibc.  Please note
that you don't need a copyright assignment to contribute the
locale data changes but you may need it to contribute to other
modules.

Please see the issue below:

13.02.2019 11:51 Felix Yan <felixonmars@archlinux.org> wrote:
> [...]
> diff --git a/localedata/locales/zh_TW b/localedata/locales/zh_TW
> index 92b04b083d..958992e8be 100644
> --- a/localedata/locales/zh_TW
> +++ b/localedata/locales/zh_TW
> @@ -126,6 +126,10 @@ am_pm	"<U4E0A><U5348>";"<U4E0B><U5348>"
>  % t_fmt_ampm: "%p %I<h>%M<m>%S<s>"
>  t_fmt_ampm  "%p %I<U6642>%M<U5206>%S<U79D2>"
>  week 7;19971130;1
> +
> +era "+:2:1913//01//01:+*:民國:%EC%Ey年";/
> +    "+:1:1912//01//01:1912//12//31:民國:%EC元年";/
> +    "+:1:1911//12//31:-*:民前:%EC%Ey年"

Please use the Unicode sequences like "<U5206>" above instead
of actual Chinese characters.  Recently we have allowed using
actual characters instead of the Unicode sequences but only for
plain ASCII characters and only if they don't have a different
meaning already.  Other characters (including Chinese) may not
be portable, may be difficult or impossible to read, may be
lost while sending etc.

I have not tested your patch further due to this issue.
Please fix this and resend version 2 of your patch.

Regards,

Rafal
diff mbox

Patch

diff --git a/localedata/locales/zh_TW b/localedata/locales/zh_TW
index 92b04b083d..958992e8be 100644
--- a/localedata/locales/zh_TW
+++ b/localedata/locales/zh_TW
@@ -126,6 +126,10 @@  am_pm	"<U4E0A><U5348>";"<U4E0B><U5348>"
 % t_fmt_ampm: "%p %I<h>%M<m>%S<s>"
 t_fmt_ampm  "%p %I<U6642>%M<U5206>%S<U79D2>"
 week 7;19971130;1
+
+era "+:2:1913//01//01:+*:民國:%EC%Ey年";/
+    "+:1:1912//01//01:1912//12//31:民國:%EC元年";/
+    "+:1:1911//12//31:-*:民前:%EC%Ey年"
 END LC_TIME
 
 LC_MESSAGES