[2/3] benchtests: Adjust valid and accepted properties
Commit Message
Benchmark workload-spec2006.wrf does not produce max, min or mean
results but instead produce throughput. This is represented in
benchtests/bench-skeleton.c. This patch adjust benchout.schema.json to consider
bench.out from bench-math benchmarks as valid
2017-11-15 Victor Rodriguez <victor.rodriguez.bahena@intel.com>
(VERSION): Set to 2.27
* benchtests/scripts/benchout.schema.json: Add throughput as accepted
result from property and remove "max", min" and "mean" from required
properties based on benchtests/bench-skeleton.c.
Signed-off-by: Victor Rodriguez <victor.rodriguez.bahena@intel.com>
---
ChangeLog | 7 +++++++
benchtests/scripts/benchout.schema.json | 3 ++-
2 files changed, 9 insertions(+), 1 deletion(-)
Comments
This is OK. But why do you have this:
(VERSION): Set to 2.27
on top of every ChangeLog entry? Please remove that.
Siddhesh
On Friday 17 November 2017 04:22 AM, Victor Rodriguez wrote:
> Benchmark workload-spec2006.wrf does not produce max, min or mean
> results but instead produce throughput. This is represented in
> benchtests/bench-skeleton.c. This patch adjust benchout.schema.json to consider
> bench.out from bench-math benchmarks as valid
>
> 2017-11-15 Victor Rodriguez <victor.rodriguez.bahena@intel.com>
>
> (VERSION): Set to 2.27
> * benchtests/scripts/benchout.schema.json: Add throughput as accepted
> result from property and remove "max", min" and "mean" from required
> properties based on benchtests/bench-skeleton.c.
>
> Signed-off-by: Victor Rodriguez <victor.rodriguez.bahena@intel.com>
> ---
> ChangeLog | 7 +++++++
> benchtests/scripts/benchout.schema.json | 3 ++-
> 2 files changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/ChangeLog b/ChangeLog
> index 7d0fd63..6a6bb62 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,10 @@
> +2017-11-15 Victor Rodriguez <victor.rodriguez.bahena@intel.com>
> +
> + (VERSION): Set to 2.27
> + * benchtests/scripts/benchout.schema.json: Add throughput as accepted
> + result from property and remove "max", min" and "mean" from required
> + properties based on benchtests/bench-skeleton.c.
> +
> 2017-11-15 Victor Rodriguez <victor.rodriguez.bahena@intel.com>
>
> (VERSION): Set to 2.27
> diff --git a/benchtests/scripts/benchout.schema.json b/benchtests/scripts/benchout.schema.json
> index 814c633..7edd2a7 100644
> --- a/benchtests/scripts/benchout.schema.json
> +++ b/benchtests/scripts/benchout.schema.json
> @@ -19,6 +19,7 @@
> "properties": {
> "duration": {"type": "number"},
> "iterations": {"type": "number"},
> + "throughput": {"type": "number"},
> "max": {"type": "number"},
> "min": {"type": "number"},
> "mean": {"type": "number"},
> @@ -27,7 +28,7 @@
> "items": {"type": "number"}
> }
> },
> - "required": ["duration", "iterations", "max", "min", "mean"],
> + "required": ["duration", "iterations"],
> "additionalProperties": false
> }
> },
>
@@ -1,3 +1,10 @@
+2017-11-15 Victor Rodriguez <victor.rodriguez.bahena@intel.com>
+
+ (VERSION): Set to 2.27
+ * benchtests/scripts/benchout.schema.json: Add throughput as accepted
+ result from property and remove "max", min" and "mean" from required
+ properties based on benchtests/bench-skeleton.c.
+
2017-11-15 Victor Rodriguez <victor.rodriguez.bahena@intel.com>
(VERSION): Set to 2.27
@@ -19,6 +19,7 @@
"properties": {
"duration": {"type": "number"},
"iterations": {"type": "number"},
+ "throughput": {"type": "number"},
"max": {"type": "number"},
"min": {"type": "number"},
"mean": {"type": "number"},
@@ -27,7 +28,7 @@
"items": {"type": "number"}
}
},
- "required": ["duration", "iterations", "max", "min", "mean"],
+ "required": ["duration", "iterations"],
"additionalProperties": false
}
},