diff mbox

[v3,3/6] linux ttyname: Change return type of is_pty from int to bool

Message ID 20171108180119.26721-4-lukeshu@parabola.nu
State New, archived
Headers

Commit Message

Luke Shumaker Nov. 8, 2017, 6:01 p.m. UTC 
  is_pty returning a bool is fine since there's no possible outcome other
than true or false, and bool is used throughout the codebase.

v2:
 - Introduce as part of another commit
v3:
 - Split into a separate commit
---
 ChangeLog                         | 3 +++
 sysdeps/unix/sysv/linux/ttyname.h | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)
diff mbox

Patch

diff --git a/ChangeLog b/ChangeLog
index 095baf9eb6..11709a01ac 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,8 @@ 
 2017-11-07  Luke Shumaker  <lukeshu@parabola.nu>
 
+	* sysdeps/unix/sysv/linux/ttyname.h (is_pty): Change return type from
+	int to bool.
+
 	* sysdeps/unix/sysv/linux/ttyname.h (is_pty): Update doc reference.
 
 	* manual/terminal.texi (Is It a Terminal):
diff --git a/sysdeps/unix/sysv/linux/ttyname.h b/sysdeps/unix/sysv/linux/ttyname.h
index cbcdbab607..ce4845a587 100644
--- a/sysdeps/unix/sysv/linux/ttyname.h
+++ b/sysdeps/unix/sysv/linux/ttyname.h
@@ -23,7 +23,7 @@ 
 /* Return true if this is a UNIX98 pty device, as defined in
    linux/Documentation/devices.txt (on linux < 4.10) or
    linux/Documentation/admin-guide/devices.txt (on linux >= 4.10).  */
-static inline int
+static inline bool
 is_pty (struct stat64 *sb)
 {
 #ifdef _STATBUF_ST_RDEV