Message ID | 20160219220955.GA25540@intel.com |
---|---|
State | New, archived |
Headers | show |
On 02/19/2016 05:09 PM, H.J. Lu wrote: > Tested on x86-64. Any comments? Why isn't this DL_RUN*T*IME_UNALIGNED_VEC_SIZE. Typos in macro interfaces are the whole reason we added -Wundef. This looks very very typo prone, I always want to type "DL_RUNTIME_..." > H.J. > --- > [BZ #19679] > * sysdeps/x86_64/dl-trampoline.S (DL_RUNIME_UNALIGNED_VEC_SIZE): > Set to 8. > --- > sysdeps/x86_64/dl-trampoline.S | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/sysdeps/x86_64/dl-trampoline.S b/sysdeps/x86_64/dl-trampoline.S > index 9fb6b13..0a480b6 100644 > --- a/sysdeps/x86_64/dl-trampoline.S > +++ b/sysdeps/x86_64/dl-trampoline.S > @@ -34,8 +34,11 @@ > #endif > > #ifndef DL_RUNIME_UNALIGNED_VEC_SIZE > -/* The maximum size of unaligned vector load and store. */ > -# define DL_RUNIME_UNALIGNED_VEC_SIZE 16 > +/* The maximum size of unaligned vector load and store in the dynamic The maximum size *in bytes* ... > + linker. Since SSE optimized memory/string functions with aligned > + SSE register load and store are used in the dynamic linker, we must > + set this to 8. */ > +# define DL_RUNIME_UNALIGNED_VEC_SIZE 8 OK. > #endif > > /* True if _dl_runtime_resolve should align stack to VEC_SIZE bytes. */ > OK if you: * Fix the name to be DL_RUNTIME_* * Adjust the comment to use a unit of size. Cheers, Carlos.
diff --git a/sysdeps/x86_64/dl-trampoline.S b/sysdeps/x86_64/dl-trampoline.S index 9fb6b13..0a480b6 100644 --- a/sysdeps/x86_64/dl-trampoline.S +++ b/sysdeps/x86_64/dl-trampoline.S @@ -34,8 +34,11 @@ #endif #ifndef DL_RUNIME_UNALIGNED_VEC_SIZE -/* The maximum size of unaligned vector load and store. */ -# define DL_RUNIME_UNALIGNED_VEC_SIZE 16 +/* The maximum size of unaligned vector load and store in the dynamic + linker. Since SSE optimized memory/string functions with aligned + SSE register load and store are used in the dynamic linker, we must + set this to 8. */ +# define DL_RUNIME_UNALIGNED_VEC_SIZE 8 #endif /* True if _dl_runtime_resolve should align stack to VEC_SIZE bytes. */