mbox series

[0/2] Revert "elf: Always call destructors in reverse constructor order (bug 30785)"

Message ID cover.1696583991.git.fweimer@redhat.com
Headers
Series Revert "elf: Always call destructors in reverse constructor order (bug 30785)" |

Message

Florian Weimer Oct. 6, 2023, 9:21 a.m. UTC 
  The change does not work with existing applications.

The first revert is an NDEBUG fix which is no longer needed after the
actual revert.

Tested on i686-linux-gnu and x86_64-linux-gnu.

Thanks,
Florian

Florian Weimer (2):
  Revert "elf: Fix compile error with -DNDEBUG [BZ #18755]"
  Revert "elf: Always call destructors in reverse constructor order (bug
    30785)"

 elf/dl-close.c             | 115 ++++++++++------------------
 elf/dl-fini.c              | 152 ++++++++++++++++++++++++-------------
 elf/dl-init.c              |  16 ----
 elf/dso-sort-tests-1.def   |  19 +++--
 elf/tst-audit23.c          |  44 +++++------
 include/link.h             |   4 -
 sysdeps/generic/ldsodefs.h |   4 -
 7 files changed, 174 insertions(+), 180 deletions(-)


base-commit: a3c50bf46a1ca6d9d2b7d879176d345abf95a9de

Comments

Andreas K. Huettel Oct. 6, 2023, 9:25 a.m. UTC | #1 
Am Freitag, 6. Oktober 2023, 11:21:24 CEST schrieb Florian Weimer:
> The change does not work with existing applications.
> 

I guess we want to revert this on the release branches then too?

> The first revert is an NDEBUG fix which is no longer needed after the
> actual revert.
> 
> Tested on i686-linux-gnu and x86_64-linux-gnu.
> 
> Thanks,
> Florian
> 
> Florian Weimer (2):
>   Revert "elf: Fix compile error with -DNDEBUG [BZ #18755]"
>   Revert "elf: Always call destructors in reverse constructor order (bug
>     30785)"
> 
>  elf/dl-close.c             | 115 ++++++++++------------------
>  elf/dl-fini.c              | 152 ++++++++++++++++++++++++-------------
>  elf/dl-init.c              |  16 ----
>  elf/dso-sort-tests-1.def   |  19 +++--
>  elf/tst-audit23.c          |  44 +++++------
>  include/link.h             |   4 -
>  sysdeps/generic/ldsodefs.h |   4 -
>  7 files changed, 174 insertions(+), 180 deletions(-)
> 
> 
> base-commit: a3c50bf46a1ca6d9d2b7d879176d345abf95a9de
>
Florian Weimer Oct. 6, 2023, 9:30 a.m. UTC | #2 
* Andreas K. Huettel:

> Am Freitag, 6. Oktober 2023, 11:21:24 CEST schrieb Florian Weimer:
>> The change does not work with existing applications.
>> 
>
> I guess we want to revert this on the release branches then too?

Yes. 8-( The application brokenness was actually reported against
glibc 2.37.

I have an idea for a more conservative fix (the reverse constructor
order did fix another application, after all), but that will have to
undergo downstream testing before a backport.

Thanks,
Florian