mbox series

[v2,0/4] Avoid relying on autoconf internals in `preconfigure' scripts

Message ID alpine.DEB.2.20.2205122234010.10833@tpp.orcam.me.uk
Headers
Series Avoid relying on autoconf internals in `preconfigure' scripts |

Message

Maciej W. Rozycki May 12, 2022, 10:28 p.m. UTC 
  Hi,

 I have discovered that we have two kinds of `preconfigure' scripts, 
handwritten ones and autoconf-generated ones.  While it seems perfectly 
fine to have these scripts handwritten, some of them wire into autoconf 
internals or use an ad-hoc way to report errors.  The scripts for the 
C-SKY, m68k, MIPS and RISC-V targets fall into this category.

 This small patch series addresses this problem by converting these 
scripts to autoconf templates with suitable adjustments, then processed 
with autoconf to re-create functionally equivalent almost identical 
scripts.

 The RISC-V script has been verified to still correctly build the library.  
All have been visually inspected to ensure functional equivalence; changes 
are so minimal for this to be straightforward.  There's some noise though 
from a formatting fix to replace octets of spaces with tabs in the new 
templates.

 OK to apply?

  Maciej

Comments

Palmer Dabbelt May 12, 2022, 10:33 p.m. UTC | #1 
On Thu, 12 May 2022 15:28:27 PDT (-0700), macro@embecosm.com wrote:
> Hi,
>
>  I have discovered that we have two kinds of `preconfigure' scripts,
> handwritten ones and autoconf-generated ones.  While it seems perfectly
> fine to have these scripts handwritten, some of them wire into autoconf
> internals or use an ad-hoc way to report errors.  The scripts for the
> C-SKY, m68k, MIPS and RISC-V targets fall into this category.
>
>  This small patch series addresses this problem by converting these
> scripts to autoconf templates with suitable adjustments, then processed
> with autoconf to re-create functionally equivalent almost identical
> scripts.
>
>  The RISC-V script has been verified to still correctly build the library.
> All have been visually inspected to ensure functional equivalence; changes
> are so minimal for this to be straightforward.  There's some noise though
> from a formatting fix to replace octets of spaces with tabs in the new
> templates.
>
>  OK to apply?

OK from me for the RISC-V bits (I'd had a draft up for the v1 waiting 
for me to build it, as that one hadn't said anything), but given that I 
probably broke them in the first place (and likely because I don't 
understand autoconf) that might not be the best ack ;)

Thanks!

>
>   Maciej