mbox series

[0/6] Add loff_t & off64_t, and update off_t

Message ID 20201027162114.47521-1-colomar.6.4.3@gmail.com
Headers
Series Add loff_t & off64_t, and update off_t |

Message

Alejandro Colomar Oct. 27, 2020, 4:21 p.m. UTC 
  Hi M,

I added some details to off_t,
and added loff_t and off64_t to the page.

Maybe you would like to improve some wording on these patches.
There are a few lines that don't convince me fully...

I might start working on fixing the messy *lseek* pages.

Cheers,

A


Alejandro Colomar (6):
  system_data_types.7: off_t: SEE ALSO: Uncomment loff_t, off64_t
  system_data_types.7: off_t: Add note about _FILE_OFFSET_BITS
  system_data_types.7: Add 'loff_t'
  loff_t.3: New link to system_data_types(7)
  system_data_types.7: Add 'off64_t'
  off64_t.3: New link to system_data_types(7)

 man3/loff_t.3            |  1 +
 man3/off64_t.3           |  1 +
 man7/system_data_types.7 | 76 ++++++++++++++++++++++++++++++++++++----
 3 files changed, 71 insertions(+), 7 deletions(-)
 create mode 100644 man3/loff_t.3
 create mode 100644 man3/off64_t.3

Comments

Michael Kerrisk \(man-pages\) Oct. 27, 2020, 4:35 p.m. UTC | #1 
Hi Alex,

On 10/27/20 5:21 PM, Alejandro Colomar wrote:
> Hi M,
> 
> I added some details to off_t,
> and added loff_t and off64_t to the page.
> 
> Maybe you would like to improve some wording on these patches.
> There are a few lines that don't convince me fully...
> 
> I might start working on fixing the messy *lseek* pages.

See my other mail. On reflection, I think that those pages are
in a "good enough" state.

And, you raced off a bit too quick for me. I definitely
think loff_t should not be added. And I'm pretty doubtful
about adding off64_t as well.

I've applied patch 2 in this series.

Thanks,

Michael


> Alejandro Colomar (6):
>   system_data_types.7: off_t: SEE ALSO: Uncomment loff_t, off64_t
>   system_data_types.7: off_t: Add note about _FILE_OFFSET_BITS
>   system_data_types.7: Add 'loff_t'
>   loff_t.3: New link to system_data_types(7)
>   system_data_types.7: Add 'off64_t'
>   off64_t.3: New link to system_data_types(7)
> 
>  man3/loff_t.3            |  1 +
>  man3/off64_t.3           |  1 +
>  man7/system_data_types.7 | 76 ++++++++++++++++++++++++++++++++++++----
>  3 files changed, 71 insertions(+), 7 deletions(-)
>  create mode 100644 man3/loff_t.3
>  create mode 100644 man3/off64_t.3
>