diff mbox

[commit] Misc cleanups in async.exp

Message ID wrbeh1zjdix.fsf@sspiff.org
State Committed
Headers show

Commit Message

Doug Evans March 18, 2014, 11:24 p.m. UTC 
Hi.

I realize this test is currently disabled, but I found it while writing
another test and figured I'd clean up a few things.

Committed.

2014-03-18  Doug Evans  <xdje42@gmail.com>

	* gdb.base/async.exp: Whitespace fixes.  Turn on target-async.
	Fix spelling of exec-done-display.

Comments

Pedro Alves March 19, 2014, 2:47 p.m. UTC | #1 
On 03/18/2014 11:24 PM, Doug Evans wrote:
> Hi.
> 
> I realize this test is currently disabled, but I found it while writing
> another test and figured I'd clean up a few things.

Thanks!  I was also wanting to hack on this, as part of the
async-by-default work.  I think we should just enable the test by now.
I'll send out a series to fix the test's remaining issues in a sec.
diff mbox

Patch

diff --git a/gdb/testsuite/gdb.base/async.exp b/gdb/testsuite/gdb.base/async.exp
index 4475ce7..3cd7dfb 100644
--- a/gdb/testsuite/gdb.base/async.exp
+++ b/gdb/testsuite/gdb.base/async.exp
@@ -39,17 +39,19 @@  return 0
 set board [target_info name]
 set current_target [target_info gdb_protocol]
 if { $current_target == "remote" } {
-  unset_board_info "gdb_protocol"
-  set_board_info "gdb_protocol" "async"
-  } else {
-      return 0
-  }
+    unset_board_info "gdb_protocol"
+    set_board_info "gdb_protocol" "async"
+} else {
+    return 0
+}
 
 gdb_exit
 gdb_start
 gdb_reinitialize_dir $srcdir/$subdir
 gdb_load ${binfile}
 
+gdb_test_no_output "set target-async on"
+
 #
 # set it up at a breakpoint so we can play with it
 #
@@ -63,7 +65,7 @@  gdb_test "break baz" ".*" ""
 #
 # Make sure we get a 'completed' message when the target is done.
 #
-gdb_test "set display-exec-done on" ".*" ""
+gdb_test_no_output "set exec-done-display on"
 
 
 send_gdb "next&\n" 
@@ -126,7 +128,7 @@  gdb_expect {
     timeout  { fail "(timeout) until &" }
 }
 
-gdb_test "set display-exec-done off" ".*" ""
+gdb_test_no_output "set exec-done-display off"
 
 unset_board_info "gdb_protocol"
 set_board_info "gdb_protocol" "remote"