diff mbox

Speedup lnp_state_machine::handle_special_opcode

Message ID nycvar.YFH.7.76.2002131358240.18835@zhemvz.fhfr.qr
State New
Headers show

Commit Message

Richard Biener Feb. 13, 2020, 1:03 p.m. UTC
I see for some program at gdb startup

Samples: 102K of event 'cycles:pu', Event count (approx.): 91710925103          
Overhead  Command     Shared Object        Symbol                               
  15.21%  gdb         gdb                  [.] 
lnp_state_machine::handle_special

where the divisions are the places we stall.  The following 
micro-optimizes things but it smells like m_line_header->line_range
is constant, likewise probably m_line_header->maximum_ops_per_instruction
so eventually the divisions could be avoided completely with some
lookup table.

Well.  Micro-optimizing with the patch below improves things
(don't expect [load] CSE over the gdbarch_adjust_dwarf2_line call).

Care to pick up this one-time patch without myself becoming familiar
with gdb testing & patch submission?

Thanks,
Richard.
diff mbox

Patch

diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c
index 7edbd9d7df..e74383e01d 100644
--- a/gdb/dwarf2/read.c
+++ b/gdb/dwarf2/read.c
@@ -19812,16 +19812,16 @@  void
 lnp_state_machine::handle_special_opcode (unsigned char op_code)
 {
   unsigned char adj_opcode = op_code - m_line_header->opcode_base;
-  CORE_ADDR addr_adj = (((m_op_index
-			  + (adj_opcode / m_line_header->line_range))
+  unsigned char adj_opcode_d = adj_opcode / m_line_header->line_range;
+  unsigned char adj_opcode_r = adj_opcode % m_line_header->line_range;
+  CORE_ADDR addr_adj = (((m_op_index + adj_opcode_d)
 			 / m_line_header->maximum_ops_per_instruction)
 			* m_line_header->minimum_instruction_length);
   m_address += gdbarch_adjust_dwarf2_line (m_gdbarch, addr_adj, true);
-  m_op_index = ((m_op_index + (adj_opcode / m_line_header->line_range))
+  m_op_index = ((m_op_index + adj_opcode_d)
 		% m_line_header->maximum_ops_per_instruction);
 
-  int line_delta = (m_line_header->line_base
-		    + (adj_opcode % m_line_header->line_range));
+  int line_delta = m_line_header->line_base + adj_opcode_r;
   advance_line (line_delta);
   record_line (false);
   m_discriminator = 0;