diff mbox

[review] Remove "boolean" and "var_boolean" checks from ARI

Message ID gerrit.1575560698000.Iaf449b51e8182ffa0b9ed25fe688e0ff64a07a67@gnutoolchain-gerrit.osci.io
State New
Headers show

Commit Message

Simon Marchi (Code Review) Dec. 5, 2019, 3:44 p.m. UTC
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/741
......................................................................

Remove "boolean" and "var_boolean" checks from ARI

The "boolean" and "var_boolean" checks from ARI seem only to generate
false reports.

Now that gdb is in C++, at least the "boolean" check seems unlikely to
ever generate a true report.

The "var_boolean" check likewise doesn't seem valuable any more --
presumably this refers to some ancient way of doing things in gdb, and
isn't likely to find a bug in the future.

Therefore, this patch removes these two checks.

gdb/ChangeLog
2019-12-05  Tom Tromey  <tromey@adacore.com>

	* contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
	checks.

Change-Id: Iaf449b51e8182ffa0b9ed25fe688e0ff64a07a67
---
M gdb/ChangeLog
M gdb/contrib/ari/gdb_ari.sh
2 files changed, 5 insertions(+), 26 deletions(-)

Comments

Simon Marchi (Code Review) Dec. 5, 2019, 4:46 p.m. UTC | #1
Pedro Alves has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/741
......................................................................


Patch Set 1: Code-Review+2

Agreed.
Simon Marchi (Code Review) Dec. 5, 2019, 4:59 p.m. UTC | #2
Christian Biesinger has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/741
......................................................................


Patch Set 1:

(1 comment)

| --- /dev/null
| +++ /COMMIT_MSG
| @@ -1,0 +3,19 @@ Author:     Tom Tromey <tromey@adacore.com>
| +AuthorDate: 2019-12-05 07:53:32 -0700
| +Commit:     Tom Tromey <tromey@adacore.com>
| +CommitDate: 2019-12-05 07:53:32 -0700
| +
| +Remove "boolean" and "var_boolean" checks from ARI
| +
| +The "boolean" and "var_boolean" checks from ARI seem only to generate
| +false reports.
| +
| +Now that gdb is in C++, at least the "boolean" check seems unlikely to

PS1, Line 12:

I don't understand, the check suggests using bool instead of boolean.
So presumably it was added specifically for c++? Still seems fine to
remove it since I don't know why anyone would write boolean.

| +ever generate a true report.
| +
| +The "var_boolean" check likewise doesn't seem valuable any more --
| +presumably this refers to some ancient way of doing things in gdb, and
| +isn't likely to find a bug in the future.
| +
| +Therefore, this patch removes these two checks.
| +
| +gdb/ChangeLog
Simon Marchi (Code Review) Dec. 12, 2019, 5:20 p.m. UTC | #3
Tom Tromey has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/741
......................................................................


Patch Set 1:

(1 comment)

| --- /dev/null
| +++ /COMMIT_MSG
| @@ -1,0 +3,19 @@ Author:     Tom Tromey <tromey@adacore.com>
| +AuthorDate: 2019-12-05 07:53:32 -0700
| +Commit:     Tom Tromey <tromey@adacore.com>
| +CommitDate: 2019-12-05 07:53:32 -0700
| +
| +Remove "boolean" and "var_boolean" checks from ARI
| +
| +The "boolean" and "var_boolean" checks from ARI seem only to generate
| +false reports.
| +
| +Now that gdb is in C++, at least the "boolean" check seems unlikely to

PS1, Line 12:

> I don't understand, the check suggests using bool instead of boolean. So presumably it was added specifically for c++? Still seems fine to remove it since I don't know why anyone would write boolean.

I am not sure but it may refer to some older typedef?
I don't know but basically it's not relevant any longer.

| +ever generate a true report.
| +
| +The "var_boolean" check likewise doesn't seem valuable any more --
| +presumably this refers to some ancient way of doing things in gdb, and
| +isn't likely to find a bug in the future.
| +
| +Therefore, this patch removes these two checks.
| +
| +gdb/ChangeLog
diff mbox

Patch

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 92ee52b..b865214 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@ 
+2019-12-05  Tom Tromey  <tromey@adacore.com>
+
+	* contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
+	checks.
+
 2019-12-04  Christian Biesinger  <cbiesinger@google.com>
 
 	* configure.nat (obsd64): Add missing files x86-nat.o and
diff --git a/gdb/contrib/ari/gdb_ari.sh b/gdb/contrib/ari/gdb_ari.sh
index 7202563..ee9f16a 100755
--- a/gdb/contrib/ari/gdb_ari.sh
+++ b/gdb/contrib/ari/gdb_ari.sh
@@ -1110,18 +1110,6 @@ 
     fail("strnicmp")
 }
 
-# Boolean expressions and conditionals
-
-BEGIN { doc["boolean"] = "\
-Do not use `boolean'\'',  use `bool'\'' instead"
-    category["boolean"] = ari_regression
-}
-/(^|[^_[:alnum:]])boolean([^_[:alnum:]]|$)/ {
-    if (is_yacc_or_lex == 0) {
-       fail("boolean")
-    }
-}
-
 # Typedefs that are either redundant or can be reduced to `struct
 # type *''.
 # Must be placed before if assignment otherwise ARI exceptions
@@ -1143,20 +1131,6 @@ 
     fail("strlen d_name")
 }
 
-BEGIN { doc["var_boolean"] = "\
-Replace var_boolean with add_setshow_boolean_cmd"
-    category["var_boolean"] = ari_regression
-    fix("var_boolean", "gdb/command.h", 1)
-    # fix only uses the last directory level
-    fix("var_boolean", "cli/cli-decode.c", 2)
-}
-/(^|[^_[:alnum:]])var_boolean([^_[:alnum:]]|$)/ {
-    if (($0 !~ /(^|[^_[:alnum:]])case *var_boolean:/) \
-        && ($0 !~ /(^|[^_[:alnum:]])[=!]= *var_boolean/)) {
-	fail("var_boolean")
-    }
-}
-
 BEGIN { doc["generic_use_struct_convention"] = "\
 Replace generic_use_struct_convention with nothing, \
 EXTRACT_STRUCT_VALUE_ADDRESS is a predicate"