diff mbox

[Bug,win32/14529] Make gdb capable of JIT-debugging on W32

Message ID b6881e06-a9a2-7d03-29c3-71532a69b19c@gmail.com
State New, archived
Headers

Commit Message

LRN June 30, 2016, 3:44 p.m. UTC 
  On 30.06.2016 18:25, Eli Zaretskii wrote:
>> From: LRN <lrn1986@gmail.com>
>> Date: Thu, 30 Jun 2016 16:16:40 +0300
>>
>> I did the paperwork and now my rights on code that will be included in gdb
>> are assigned to FSF.
>> So i'm upping the thread. Also, attaching a version of the patch that can
>> be applied to current git master.
> 
> Thanks.  The documentation change is approved, but please include a
> NEWS entry, and also please show the ChangeLog entries for the
> changes.
> 
Attached the NEWS and ChangeLog patches.

There's also a bug report[1] that will have to be updated/closed
(it also has obsolete patch and ChangeLog entries attached).

[1] https://sourceware.org/bugzilla/show_bug.cgi?id=14529

Comments

Eli Zaretskii June 30, 2016, 4:23 p.m. UTC | #1 
> From: LRN <lrn1986@gmail.com>
> Date: Thu, 30 Jun 2016 18:44:28 +0300
> 
> > Thanks.  The documentation change is approved, but please include a
> > NEWS entry, and also please show the ChangeLog entries for the
> > changes.
> > 
> Attached the NEWS and ChangeLog patches.

Thanks, but please format the ChangeLog entries according to our
coding standards.  You should be able to see many examples in the
repository.

The NEWS entry is OK, but this sentence:

> +signal-event EVENTID
> +  Signal ("set") given Windows event object.

lacks "the".  IOW, say "Signal the given Windows event object."
LRN June 30, 2016, 5:18 p.m. UTC | #2 
On 30.06.2016 19:23, Eli Zaretskii wrote:
> On Thu, 30 Jun 2016 18:44:28 +0300, LRN wrote:
>>> Thanks.  The documentation change is approved, but please include a
>>> NEWS entry, and also please show the ChangeLog entries for the
>>> changes.
>>>
>> Attached the NEWS and ChangeLog patches.
> 
> Thanks, but please format the ChangeLog entries according to our
> coding standards.  You should be able to see many examples in the
> repository.

I did. What did i do wrong? Had a single space (instead of two spaces)
after the name? Used "Fix PR gdb/14529" at the end instead of "PR
gdb/14529" at the beginning? No function name in parentheses (should it
have been signal_event_command?)? Can't spot any other differences.
Eli Zaretskii June 30, 2016, 5:42 p.m. UTC | #3 
> From: LRN <lrn1986@gmail.com>
> Date: Thu, 30 Jun 2016 20:18:52 +0300
> 
> > Thanks, but please format the ChangeLog entries according to our
> > coding standards.  You should be able to see many examples in the
> > repository.
> 
> I did. What did i do wrong? Had a single space (instead of two spaces)
> after the name? Used "Fix PR gdb/14529" at the end instead of "PR
> gdb/14529" at the beginning? No function name in parentheses (should it
> have been signal_event_command?)?

The latter.
diff mbox

Patch

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index e98a565..891d125 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,10 @@ 
+2016-06-30  Руслан Ижбулатов <lrn1986@gmail.com>
+
+	* windows-nat.c: New command 'signal-event' for W32 compatibility
+	* gdb.texinfo: document the new 'signal-event' command.
+	* NEWS: Add an entry about the new 'signal-event' command.
+	Fix PR gdb/14529.
+
 2016-06-25  Tom Tromey  <tom@tromey.com>
 
 	* rust-lang.c (rust_get_disr_info, rust_print_type): Fix