diff mbox series

[08/13] gdb: remove use of alloca from linux-nat-trad.c

Message ID b1d3b938ac3ae5239c39ad5dbf749788e9483a11.1677533215.git.aburgess@redhat.com
State New
Headers
Series Remove a bunch of alloca uses |

Commit Message

Andrew Burgess Feb. 27, 2023, 9:29 p.m. UTC 
  Remove use of alloca from linux-nat-trad.c and replace with
gdb::byte_vector.

I've compiled for the mips-linux target (which uses this file) to
ensure that the file still builds, but I've not tested GDB for a
target that uses this file.  Still, I'm pretty confident that I've not
broken anything with this change.

There should be no user visible changes after this commit.
---
 gdb/linux-nat-trad.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
diff mbox series

Patch

diff --git a/gdb/linux-nat-trad.c b/gdb/linux-nat-trad.c
index 8204f3883f5..408d9118766 100644
--- a/gdb/linux-nat-trad.c
+++ b/gdb/linux-nat-trad.c
@@ -32,7 +32,6 @@  linux_nat_trad_target::fetch_register (struct regcache *regcache, int regnum)
   struct gdbarch *gdbarch = regcache->arch ();
   enum bfd_endian byte_order = gdbarch_byte_order (gdbarch);
   CORE_ADDR addr;
-  gdb_byte *buf;
   size_t size;
   pid_t pid;
   int i;
@@ -49,7 +48,8 @@  linux_nat_trad_target::fetch_register (struct regcache *regcache, int regnum)
   pid = get_ptrace_pid (regcache->ptid ());
 
   size = register_size (gdbarch, regnum);
-  buf = (gdb_byte *) alloca (size);
+  gdb::byte_vector buf_storage (size);
+  gdb_byte *buf = buf_storage.data ();
 
   /* Read the register contents from the inferior a chunk at a time.  */
   for (i = 0; i < size; i += sizeof (PTRACE_TYPE_RET))
@@ -95,7 +95,6 @@  linux_nat_trad_target::store_register (const struct regcache *regcache,
   enum bfd_endian byte_order = gdbarch_byte_order (gdbarch);
   CORE_ADDR addr;
   size_t size;
-  gdb_byte *buf;
   pid_t pid;
   int i;
 
@@ -108,7 +107,8 @@  linux_nat_trad_target::store_register (const struct regcache *regcache,
   pid = get_ptrace_pid (regcache->ptid ());
 
   size = register_size (gdbarch, regnum);
-  buf = (gdb_byte *) alloca (size);
+  gdb::byte_vector buf_storage (size);
+  gdb_byte *buf = buf_storage.data ();
 
   /* Write the register contents into the inferior a chunk at a time.  */
   regcache->raw_collect (regnum, buf);