Message ID | alpine.LFD.2.21.2002081623470.18621@redsun52.ssa.fujisawa.hgst.com |
---|---|
State | Committed |
Headers | show |
On Sat, 8 Feb 2020 16:57:30 +0000 (GMT) "Maciej W. Rozycki" <macro@wdc.com> wrote: ... > Note the double curly braces, to take advantage of `&&' operator's lazy > evaluation. > > gdb/testsuite/ > * gdb.base/step-over-no-symbols.exp: Verify that $before_addr > and $after_addr are both integers before making a comparison. Thanks for the detailed explanation! This is okay. Kevin
On Sat, 8 Feb 2020, Kevin Buettner wrote: > > * gdb.base/step-over-no-symbols.exp: Verify that $before_addr > > and $after_addr are both integers before making a comparison. > > Thanks for the detailed explanation! > > This is okay. Committed now, thanks for your review. Maciej
Index: binutils-gdb/gdb/testsuite/gdb.base/step-over-no-symbols.exp =================================================================== --- binutils-gdb.orig/gdb/testsuite/gdb.base/step-over-no-symbols.exp +++ binutils-gdb/gdb/testsuite/gdb.base/step-over-no-symbols.exp @@ -78,7 +78,9 @@ proc test_step_over { displaced } { set after_addr [get_pc "get after PC"] - gdb_assert {$before_addr != $after_addr} "advanced" + gdb_assert {{[string is integer -strict $before_addr] \ + && [string is integer -strict $after_addr] \ + && $before_addr != $after_addr}} "advanced" } foreach displaced { "off" "on" "auto" } {