diff mbox

[PATCHSET,1/4] Fix various issue in TUI

Message ID 83zja3buah.fsf@gnu.org
State New
Headers show

Commit Message

Eli Zaretskii Dec. 31, 2014, 5:31 p.m. UTC
This patch leaves more place on the status line for the process/thread
ID info, so that the probability of chopping it is significantly lower.

OK to commit?

2014-12-31  Eli Zaretskii  <eliz@gnu.org>

	* tui/tui-data.h (LINE_PREFIX): Make shorter.
	(MAX_PID_WIDTH): Leave 5 more characters.

Comments

Pedro Alves Jan. 5, 2015, 7:20 p.m. UTC | #1
On 12/31/2014 05:31 PM, Eli Zaretskii wrote:
> This patch leaves more place on the status line for the process/thread
> ID info, so that the probability of chopping it is significantly lower.
> 
> OK to commit?
> 
> 2014-12-31  Eli Zaretskii  <eliz@gnu.org>
> 
> 	* tui/tui-data.h (LINE_PREFIX): Make shorter.
> 	(MAX_PID_WIDTH): Leave 5 more characters.

OK.

(Please recall to give the commit a more specific subject line
though, rather than having all 4 patches with the same subject.)

>  /* Strings to display in the TUI status line.  */
>  #define PROC_PREFIX             "In: "
> -#define LINE_PREFIX             "Line: "
> +#define LINE_PREFIX             "L"

I have to a admit this one looked a little odd to me,
but I guess it's a matter of habit.

Thanks,
Pedro Alves
Eli Zaretskii Jan. 6, 2015, 3:56 p.m. UTC | #2
> Date: Mon, 05 Jan 2015 19:20:02 +0000
> From: Pedro Alves <palves@redhat.com>
> 
> >  /* Strings to display in the TUI status line.  */
> >  #define PROC_PREFIX             "In: "
> > -#define LINE_PREFIX             "Line: "
> > +#define LINE_PREFIX             "L"
> 
> I have to a admit this one looked a little odd to me,
> but I guess it's a matter of habit.

Well, Emacs shows "Lnnn", so the habit is already here ;-)
Eli Zaretskii Jan. 16, 2015, 11:25 a.m. UTC | #3
> Date: Mon, 05 Jan 2015 19:20:02 +0000
> From: Pedro Alves <palves@redhat.com>
> 
> On 12/31/2014 05:31 PM, Eli Zaretskii wrote:
> > This patch leaves more place on the status line for the process/thread
> > ID info, so that the probability of chopping it is significantly lower.
> > 
> > OK to commit?
> > 
> > 2014-12-31  Eli Zaretskii  <eliz@gnu.org>
> > 
> > 	* tui/tui-data.h (LINE_PREFIX): Make shorter.
> > 	(MAX_PID_WIDTH): Leave 5 more characters.
> 
> OK.
> 
> (Please recall to give the commit a more specific subject line
> though, rather than having all 4 patches with the same subject.)
> 
> >  /* Strings to display in the TUI status line.  */
> >  #define PROC_PREFIX             "In: "
> > -#define LINE_PREFIX             "Line: "
> > +#define LINE_PREFIX             "L"
> 
> I have to a admit this one looked a little odd to me,
> but I guess it's a matter of habit.

Thanks, pushed.
diff mbox

Patch

--- gdb/tui/tui-data.h~0	2014-06-11 18:34:41 +0300
+++ gdb/tui/tui-data.h	2014-12-31 09:55:03 +0200
@@ -75,7 +75,7 @@ 
 
 /* Strings to display in the TUI status line.  */
 #define PROC_PREFIX             "In: "
-#define LINE_PREFIX             "Line: "
+#define LINE_PREFIX             "L"
 #define PC_PREFIX               "PC: "
 #define SINGLE_KEY              "(SingleKey)"
 
@@ -85,7 +85,7 @@ 
 				   numbers.  */
 #define MIN_PROC_WIDTH    12
 #define MAX_TARGET_WIDTH  10
-#define MAX_PID_WIDTH     14
+#define MAX_PID_WIDTH     19
 
 #define TUI_FLOAT_REGS_NAME                  "$FREGS"
 #define TUI_FLOAT_REGS_NAME_LOWER            "$fregs"