diff mbox

[6/11] Add ALPHA_MAX_REGISTER_SIZE

Message ID 772F5764-0F2A-4F53-BC41-C36AF15BED21@arm.com
State New
Headers show

Commit Message

Alan Hayward April 4, 2017, 10:14 a.m. UTC
Max size set to 64bits, which I determined using alpha_register_type()

Tested on a --enable-targets=all build using make check with board files
unix and native-gdbserver.

I do not have an ALPHA machine to test on.

Ok to commit?

Alan.


2017-04-04  Alan Hayward  <alan.hayward@arm.com>

	* alpha-tdep.c (alpha_register_to_value): Use ALPHA_MAX_REGISTER_SIZE
	(alpha_value_to_register): Likewise.
	* alpha-tdep.h (ALPHA_MAX_REGISTER_SIZE): Add.

Comments

Yao Qi April 11, 2017, 9:16 a.m. UTC | #1
Alan Hayward <Alan.Hayward@arm.com> writes:

> diff --git a/gdb/alpha-tdep.h b/gdb/alpha-tdep.h
> index ab46ba56bef1ffb1cea541c506ffed6a5ae9b556..316d94d0bb53e9bc7943d406bf81f7d597437ff3 100644
> --- a/gdb/alpha-tdep.h
> +++ b/gdb/alpha-tdep.h
> @@ -26,6 +26,9 @@ struct regcache;
>     real way to know how big a register is.  */
>  #define ALPHA_REGISTER_SIZE 8
>
> +/* Big enough to hold the size of the largest register in bytes.  */
> +#define ALPHA_MAX_REGISTER_SIZE	8
> +

> --- a/gdb/alpha-tdep.c
> +++ b/gdb/alpha-tdep.c
> @@ -244,7 +244,7 @@ alpha_register_to_value (struct frame_info *frame, int regnum,
>  			int *optimizedp, int *unavailablep)
>  {
>    struct gdbarch *gdbarch = get_frame_arch (frame);
> -  gdb_byte in[MAX_REGISTER_SIZE];
> +  gdb_byte in[ALPHA_MAX_REGISTER_SIZE];
>
>    /* Convert to TYPE.  */
>    if (!get_frame_register_bytes (frame, regnum, 0,

We can use get_frame_register_value, so "in" can be removed.

> @@ -266,7 +266,7 @@ static void
>  alpha_value_to_register (struct frame_info *frame, int regnum,
>  			 struct type *valtype, const gdb_byte *in)
>  {
> -  gdb_byte out[MAX_REGISTER_SIZE];
> +  gdb_byte out[ALPHA_MAX_REGISTER_SIZE];

Why don't you use ALPHA_REGISTER_SIZE?
diff mbox

Patch

diff --git a/gdb/alpha-tdep.h b/gdb/alpha-tdep.h
index ab46ba56bef1ffb1cea541c506ffed6a5ae9b556..316d94d0bb53e9bc7943d406bf81f7d597437ff3 100644
--- a/gdb/alpha-tdep.h
+++ b/gdb/alpha-tdep.h
@@ -26,6 +26,9 @@  struct regcache;
    real way to know how big a register is.  */
 #define ALPHA_REGISTER_SIZE 8

+/* Big enough to hold the size of the largest register in bytes.  */
+#define ALPHA_MAX_REGISTER_SIZE	8
+
 /* Number of machine registers.  */
 #define ALPHA_NUM_REGS 67

diff --git a/gdb/alpha-tdep.c b/gdb/alpha-tdep.c
index 4dd65c58cc2896ea6038399128e3eb376d1ee672..5a1024e8697a14963b226d275c19721cb6d4e327 100644
--- a/gdb/alpha-tdep.c
+++ b/gdb/alpha-tdep.c
@@ -244,7 +244,7 @@  alpha_register_to_value (struct frame_info *frame, int regnum,
 			int *optimizedp, int *unavailablep)
 {
   struct gdbarch *gdbarch = get_frame_arch (frame);
-  gdb_byte in[MAX_REGISTER_SIZE];
+  gdb_byte in[ALPHA_MAX_REGISTER_SIZE];

   /* Convert to TYPE.  */
   if (!get_frame_register_bytes (frame, regnum, 0,
@@ -266,7 +266,7 @@  static void
 alpha_value_to_register (struct frame_info *frame, int regnum,
 			 struct type *valtype, const gdb_byte *in)
 {
-  gdb_byte out[MAX_REGISTER_SIZE];
+  gdb_byte out[ALPHA_MAX_REGISTER_SIZE];

   switch (TYPE_LENGTH (valtype))
     {